From: Junio C Hamano <gitster@pobox.com>
To: Matt Stark <msta@google.com>
Cc: git@vger.kernel.org, ps@pks.im, phillip.wood@dunelm.org.uk,
Martin von Zweigbergk <martinvonz@google.com>,
remo@buenzli.dev, Edwin Kempin <ekempin@google.com>,
schacon@gmail.com, philipmetzger@bluewin.ch,
konstantin@linuxfoundation.org, newren@gmail.com,
tytso@mit.edu, nico@cryptonector.com, rikingcoding@gmail.com
Subject: Re: [PATCH] headers: Preserve 'change-id' header in rebase / cherry-pick.
Date: Mon, 06 Apr 2026 21:09:54 -0700 [thread overview]
Message-ID: <xmqqqzor76nh.fsf@gitster.g> (raw)
In-Reply-To: <CAH7WC73-4p0RrqKNSh2G-xfpfO7QHZiXHbU_UFRkM3Q=bMWTDw@mail.gmail.com> (Matt Stark's message of "Tue, 7 Apr 2026 13:13:18 +1000")
Matt Stark <msta@google.com> writes:
> In the discussions on
> https://lore.kernel.org/git/Z_OGMb-1oV0Ex05e@pks.im/T/#m038be849b9b4020c16c562d810cf77bad91a2c87,
> it seems to be that:
> * There is consensus that a `change-id` header provides good value
I doubt it.
There are multiple people who wanted it, but as far as I can recall,
I did not get the sense that they had the same semantics in mind.
> * There is not consenus on what precise format that should take
Format is one thing, but what it means is much more important. When
is it inherited? What happens when you split a single commit into
three pieces, which piece, if any, among the resulting three will
inherit thee parent's? Should rebase, cherry-pick, and replay
behave the same way (IIRC, rebase and cherry-pick behaves
differently while propagating notes). Etc., etc.
next prev parent reply other threads:[~2026-04-07 4:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 3:13 [PATCH] headers: Preserve 'change-id' header in rebase / cherry-pick Matt Stark
2026-04-07 4:09 ` Junio C Hamano [this message]
2026-04-07 4:58 ` Nico Williams
2026-04-07 5:02 ` Nico Williams
2026-04-07 14:33 ` Junio C Hamano
2026-04-07 9:55 ` Phillip Wood
2026-04-07 15:52 ` Nico Williams
2026-04-07 16:20 ` Junio C Hamano
2026-04-07 20:13 ` Nico Williams
2026-04-07 14:42 ` Junio C Hamano
2026-04-07 9:41 ` Phillip Wood
2026-04-07 23:28 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzor76nh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ekempin@google.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=martinvonz@google.com \
--cc=msta@google.com \
--cc=newren@gmail.com \
--cc=nico@cryptonector.com \
--cc=philipmetzger@bluewin.ch \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=remo@buenzli.dev \
--cc=rikingcoding@gmail.com \
--cc=schacon@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox