From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Jeff King <peff@peff.net>, Tanay Abhra <tanayabh@gmail.com>,
git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH] config.c: change the function signature of `git_config_string()`
Date: Wed, 23 Jul 2014 10:25:51 -0700 [thread overview]
Message-ID: <xmqqr41cdm1s.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqegxccvq9.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 23 Jul 2014 10:42:06 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> *1* We have safe_create_leading_directories_const() that works
>> around this for input parameter around its _const less counterpart,
>> which is ugly but livable solution.
>
> I think it would actually be a reasonable solution to avoid casting here
> and there on the caller side.
"Ugly" primarily refers to the fact that we are forced to do this in
the first place by the language. I agree with you, especially if we
have very many call sites, and I suspect config-get-string actually
would.
> Another option would be to _return_ a non-const char * instead of
> outputing it as a by-address parameter.
Here, too, I agree that it is the most C-ish interface.
prev parent reply other threads:[~2014-07-23 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 10:49 [PATCH] config.c: change the function signature of `git_config_string()` Tanay Abhra
2014-07-22 11:07 ` Jeff King
2014-07-22 11:41 ` Tanay Abhra
2014-07-22 11:44 ` Matthieu Moy
2014-07-22 11:48 ` Tanay Abhra
2014-07-22 15:53 ` Junio C Hamano
2014-07-22 16:03 ` Matthieu Moy
2014-07-22 16:47 ` Junio C Hamano
2014-07-23 8:42 ` Matthieu Moy
2014-07-23 17:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr41cdm1s.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox