* [PATCH] completion: add "diff.compactionHeuristic" to git config
@ 2016-06-17 16:42 Martin Vladev
2016-06-17 17:04 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Martin Vladev @ 2016-06-17 16:42 UTC (permalink / raw)
To: git; +Cc: szeder, spearce, felipe.contreras, lee.marlow, Martin Vladev
Signed-off-by: Martin Vladev <martin.vladev@gmail.com>
---
contrib/completion/git-completion.bash | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3402475..55862d6 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2066,6 +2066,7 @@ _git_config ()
core.whitespace
core.worktree
diff.autorefreshindex
+ diff.compactionHeuristic
diff.external
diff.ignoreSubmodules
diff.mnemonicprefix
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] completion: add "diff.compactionHeuristic" to git config
2016-06-17 16:42 [PATCH] completion: add "diff.compactionHeuristic" to git config Martin Vladev
@ 2016-06-17 17:04 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2016-06-17 17:04 UTC (permalink / raw)
To: Martin Vladev
Cc: git, szeder, spearce, felipe.contreras, lee.marlow, Martin Vladev
Martin Vladev <martinvladev@gmail.com> writes:
> Signed-off-by: Martin Vladev <martin.vladev@gmail.com>
> ---
The reason why existing documentation marks this feature as
experimental is because we would eventually want to end the
experiment (and use the better heuristics, if the experiment yields
one, unconditionally).
Making it more discoverable by completing like this will make it
harder to end the experiment, so I am moderately negative on this
change.
Thanks.
> contrib/completion/git-completion.bash | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 3402475..55862d6 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2066,6 +2066,7 @@ _git_config ()
> core.whitespace
> core.worktree
> diff.autorefreshindex
> + diff.compactionHeuristic
> diff.external
> diff.ignoreSubmodules
> diff.mnemonicprefix
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-17 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 16:42 [PATCH] completion: add "diff.compactionHeuristic" to git config Martin Vladev
2016-06-17 17:04 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox