From: Junio C Hamano <gitster@pobox.com>
To: kerylefondji7@gmail.com
Cc: phillip.wood123@gmail.com, christian.couder@gmail.com,
siddharthasthana31@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v6 1/1] archive-zip: refactor 'path too long' error message to use Q_()
Date: Mon, 26 Oct 2026 10:33:10 -0700 [thread overview]
Message-ID: <xmqqtsm8qsdl.fsf@gitster.g> (raw)
In-Reply-To: <20261026172456.561-1-kerylefondji7@gmail.com> (kerylefondji7@gmail.com's message of "Mon, 26 Oct 2026 18:24:56 +0100")
kerylefondji7@gmail.com writes:
> Hi everyone,
>
> Just a gentle follow-up on this v6 patch. I have rebased the commit directly on top of master as suggested by Phillip, ensuring a clean single-commit structure and proper indentation.
>
> Please let me know if this version looks good to you or if any further adjustments are needed.
>
> Thank you for your time and guidance!
>
> Best regards,
> Keryle
It is not so friendly to send a reply to v4's review when the one
you want people to take a look at is v6, though.
According to Documentation/SubmittingPatches
https://lore.kernel.org/git/20261023213813.3318-2-kerylefondji7@gmail.com/
is not ready. No commit log message to explain and justify the
changes, and it is not signed-off. The shape of the submission
looked nicer in v5 iteration in this regard.
next prev parent reply other threads:[~2026-10-26 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 8:44 [PATCH] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7
2026-10-19 13:58 ` Phillip Wood
2026-10-19 21:12 ` Junio C Hamano
2026-10-20 10:22 ` [PATCH v3 0/1] archive-zip: refactor 'path too long' error message kerylefondji7
2026-10-20 10:22 ` [PATCH v3 1/1] archive-zip: refactor 'path too long' error message to use Q_() kerylefondji7
2026-10-20 15:05 ` Phillip Wood
2026-10-20 18:39 ` [PATCH v4 0/1] " kerylefondji7
2026-10-20 18:39 ` [PATCH v4 1/1] " kerylefondji7
2026-10-22 14:29 ` Phillip Wood
2026-10-22 17:41 ` Junio C Hamano
2026-10-23 12:03 ` [PATCH v5 0/1] " kerylefondji7
2026-10-23 12:03 ` [PATCH v5 1/1] " kerylefondji7
2026-10-23 15:09 ` Phillip Wood
2026-10-23 21:38 ` [PATCH v6 0/1] " kerylefondji7
2026-10-23 21:38 ` [PATCH v6 1/1] " kerylefondji7
2026-10-26 17:24 ` kerylefondji7
2026-10-26 17:33 ` Junio C Hamano [this message]
2026-10-22 10:28 ` [PATCH v4] archive-zip: refactor 'path too long' error kerylefondji7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsm8qsdl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kerylefondji7@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox