From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>, git@vger.kernel.org
Subject: Re: [PULL] git-svn updates from Ramkumar
Date: Thu, 15 Jan 2015 15:24:59 -0800 [thread overview]
Message-ID: <xmqqtwzr4ofo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150115224652.GA25482@dcvr.yhbt.net> (Eric Wong's message of "Thu, 15 Jan 2015 22:46:52 +0000")
Eric Wong <normalperson@yhbt.net> writes:
> Junio C Hamano <gitster@pobox.com> wrote:
>> Thanks. No tests necessary/feasible? Just being curious.
>
> They seemed simple and obvious enough to me,
> (and most importantly, didn't trigger regressions).
I can see that the top-most one is about .git that is a textual
symlink ".gitdir: <elsewhere>" and the code after this part needed
to convert it to the real place in order to be able to read/write
"${GIT_DIR}/<some file>", so that is obvious to me.
But the other one just says "handle missing ref_id case correctly"
without clarifying what is incorrect in the original and how the
desired correct behaviour is different (in other words, what breaks
without this change)
To which a natural reaction was "Can the existing breakage
demonstrated by a test?".
If it is obvious for git-svn folks, then I wouldn't complain,
though.
next prev parent reply other threads:[~2015-01-15 23:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 9:07 [PULL] git-svn updates from Ramkumar Eric Wong
2015-01-15 18:51 ` Junio C Hamano
2015-01-15 22:46 ` Eric Wong
2015-01-15 23:24 ` Junio C Hamano [this message]
2015-01-15 23:52 ` Ramkumar Ramachandra
2015-01-16 0:08 ` Eric Wong
2015-01-16 0:18 ` Ramkumar Ramachandra
2015-01-16 0:39 ` Eric Wong
2015-01-21 17:47 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwzr4ofo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox