Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: martin.agren@gmail.com, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: symbol string_list_appendf() unused
Date: Tue, 22 May 2018 08:59:36 +0900	[thread overview]
Message-ID: <xmqqvabgzhjr.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <d203f6ef-f684-cf6b-07b0-553b6b79e189@ramsayjones.plus.com> (Ramsay Jones's message of "Tue, 22 May 2018 00:56:21 +0100")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> I strongly suspect that I haven't followed the discussion on
> the list closely enough, but your 'ma/unpack-trees-free-msgs'
> branch in 'pu', seems to define string_list_appendf() but then
> never call it. This is despite commit 40ebd6c7b0 ("string-list:
> provide `string_list_appendf()`", 2018-05-20) claiming that:
> 'The next commit will add a user'. ;-)
>
> Have I missed something?

Yes, I pushed out a tentative "how about doing it this way" update
that goes alongside his version, making some solutions (including
the function you found) he had obsoleted, yet without removing
them.  That is what you saw on 'pu'.

There is a reroll by Martin that ties all the loose ends.

Thanks for paying great attention to the details. Always
appreciated.


  reply	other threads:[~2018-05-21 23:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 23:56 symbol string_list_appendf() unused Ramsay Jones
2018-05-21 23:59 ` Junio C Hamano [this message]
2018-05-22  0:08   ` Ramsay Jones
2018-05-22 10:55     ` Martin Ågren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvabgzhjr.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox