* symbol string_list_appendf() unused
@ 2018-05-21 23:56 Ramsay Jones
2018-05-21 23:59 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Ramsay Jones @ 2018-05-21 23:56 UTC (permalink / raw)
To: martin.agren; +Cc: GIT Mailing-list
Hi Martin,
I strongly suspect that I haven't followed the discussion on
the list closely enough, but your 'ma/unpack-trees-free-msgs'
branch in 'pu', seems to define string_list_appendf() but then
never call it. This is despite commit 40ebd6c7b0 ("string-list:
provide `string_list_appendf()`", 2018-05-20) claiming that:
'The next commit will add a user'. ;-)
Have I missed something?
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: symbol string_list_appendf() unused
2018-05-21 23:56 symbol string_list_appendf() unused Ramsay Jones
@ 2018-05-21 23:59 ` Junio C Hamano
2018-05-22 0:08 ` Ramsay Jones
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2018-05-21 23:59 UTC (permalink / raw)
To: Ramsay Jones; +Cc: martin.agren, GIT Mailing-list
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> I strongly suspect that I haven't followed the discussion on
> the list closely enough, but your 'ma/unpack-trees-free-msgs'
> branch in 'pu', seems to define string_list_appendf() but then
> never call it. This is despite commit 40ebd6c7b0 ("string-list:
> provide `string_list_appendf()`", 2018-05-20) claiming that:
> 'The next commit will add a user'. ;-)
>
> Have I missed something?
Yes, I pushed out a tentative "how about doing it this way" update
that goes alongside his version, making some solutions (including
the function you found) he had obsoleted, yet without removing
them. That is what you saw on 'pu'.
There is a reroll by Martin that ties all the loose ends.
Thanks for paying great attention to the details. Always
appreciated.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: symbol string_list_appendf() unused
2018-05-21 23:59 ` Junio C Hamano
@ 2018-05-22 0:08 ` Ramsay Jones
2018-05-22 10:55 ` Martin Ågren
0 siblings, 1 reply; 4+ messages in thread
From: Ramsay Jones @ 2018-05-22 0:08 UTC (permalink / raw)
To: Junio C Hamano; +Cc: martin.agren, GIT Mailing-list
On 22/05/18 00:59, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> I strongly suspect that I haven't followed the discussion on
>> the list closely enough, but your 'ma/unpack-trees-free-msgs'
>> branch in 'pu', seems to define string_list_appendf() but then
>> never call it. This is despite commit 40ebd6c7b0 ("string-list:
>> provide `string_list_appendf()`", 2018-05-20) claiming that:
>> 'The next commit will add a user'. ;-)
>>
>> Have I missed something?
>
> Yes, I pushed out a tentative "how about doing it this way" update
> that goes alongside his version, making some solutions (including
> the function you found) he had obsoleted, yet without removing
> them. That is what you saw on 'pu'.
>
> There is a reroll by Martin that ties all the loose ends.
Ah, OK, sorry for the noise.
Thanks!
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: symbol string_list_appendf() unused
2018-05-22 0:08 ` Ramsay Jones
@ 2018-05-22 10:55 ` Martin Ågren
0 siblings, 0 replies; 4+ messages in thread
From: Martin Ågren @ 2018-05-22 10:55 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
Hi Ramsay
On 22 May 2018 at 02:08, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> On 22/05/18 00:59, Junio C Hamano wrote:
>> There is a reroll by Martin that ties all the loose ends.
>
> Ah, OK, sorry for the noise.
No worry. Thanks for pointing out the unused function to me. I
appreciate it.
Martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-21 23:56 symbol string_list_appendf() unused Ramsay Jones
2018-05-21 23:59 ` Junio C Hamano
2018-05-22 0:08 ` Ramsay Jones
2018-05-22 10:55 ` Martin Ågren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox