[GSoC PATCH] t0410: use test_path_exists instead of test -e

[GSoC PATCH] t0410: use test_path_exists instead of test -e

[Tilak Kumar]

Use the test_path_exists helper so that a missing
promisor packfile is reported with a clear message
instead of failing silently.

Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
---
 t/t0410-partial-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
index a54685e3c7..c3c5fd6e33 100755
--- a/t/t0410-partial-clone.sh
+++ b/t/t0410-partial-clone.sh
@@ -627,7 +627,7 @@ test_expect_success 'gc stops traversal when a missing but promised object is re
 	git -C repo gc &&
 
 	# Ensure that the promisor packfile still exists, and remove it
-	test -e repo/.git/objects/pack/pack-$HASH.pack &&
+	test_path_exists repo/.git/objects/pack/pack-$HASH.pack &&
 	rm repo/.git/objects/pack/pack-$HASH.* &&
 
 	# Ensure that the single other pack contains the commit, but not the tree
-- 
2.55.0

Re: [GSoC PATCH] t0410: use test_path_exists instead of test -e

[Junio C Hamano]

Tilak Kumar <raaztilak07@gmail.com> writes:

> Use the test_path_exists helper so that a missing
> promisor packfile is reported with a clear message
> instead of failing silently.
>
> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>
> ---
>  t/t0410-partial-clone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Makes sense.  Will queue.

Thanks.