From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Patrick Steinhardt <ps@pks.im>,
Karthik Nayak <karthik.188@gmail.com>,
Jeff King <peff@peff.net>, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2 0/5] Introduce 'uploadpack.lazyFetchTrusted'
Date: Thu, 13 Aug 2026 13:31:30 -0700 [thread overview]
Message-ID: <xmqqy0e9rcd9.fsf@gitster.g> (raw)
In-Reply-To: <20260813154748.2378747-1-christian.couder@gmail.com> (Christian Couder's message of "Thu, 13 Aug 2026 17:47:43 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> Recently the "promisor-remote" capability was added to protocol v2,
> allowing servers and clients to agree on the promisor remotes they can
> safely use.
I do not know what you did, but it seems that an attempt to futz
with the thread structure i.e.,
This version is also sent as a separate 'v2' iteration in reply to v1,
instead of being threaded onto the previous "Introduce a
'fromAccepted' option to GIT_NO_LAZY_FETCH" series, and it now
contains a 'base-commit' trailer, so that 'b4' and other tools can
find the right base and the right patches.
made the patches totally unusable.
This [v2 0/5] has
Message-ID: <20260813154748.2378747-1-christian.couder@gmail.com>
In-reply-to: <20260807135511.1818458-1-christian.couder@gmail.com>
which is *correct*. It is a reply to [0/5] of the original thread.
However, [v2 1/5] says:
Message-ID: <20260813154748.2378747-2-christian.couder@gmail.com>
In-reply-to: <20260807135511.1818458-1-christian.couder@gmail.com>
which is quite wrong. [v2 1/5] should be a reply to the cover
letter of the v2 iteration. [v2 2/5], [v2 3/5], ... should also be
replies to the cover letter of the v2 iteration.
I have never seen either plain vanilla send-email or GitGitGadget
produce misthreaded series like this one. Do you have some custom
settings to send things out?
Here is _one_ way to create a thread of the right shape:
1. Develop this 5-patch series.
2. Run
$ git format-patch -v2 --cover-letter -5
to grab 0000-cover-letter.patch to 0005-builtin-upload-...patch
files. You may also want to pass --range-diff option.
3. Edit 0000-cover-letter.patch to your satisfaction. Do not futz
with In-Reply-To or References or Message-Id yourself there;
the tool will do this part better than manual editing.
4. Run
$ git send-email --no-chain-reply-to \
--in-reply-to='<20260807135511.1818458-1-christian.couder@gmail.com>' \
000[0-5]-*.patch
This will make the initial message (which is the cover letter of
this iteration) a reply to the named message (which is the cover
letter of the v1 iteration), and then the remainder replies to
the initial message, which is what we want to see.
There surely are other right ways to do so. As long as the end
result would look like
* vN (1 < N) cover letter is a reply to v1 cover letter
* vN patch M (0 < M) is a reply to vN cover letter
things will flow more smoothly.
HTH.
next prev parent reply other threads:[~2026-08-13 20:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 8:51 [PATCH 0/3] Introduce a 'fromAccepted' option to GIT_NO_LAZY_FETCH Christian Couder
2026-07-10 8:51 ` [PATCH 1/3] promisor-remote: factor out lazy_fetch_objects() Christian Couder
2026-07-10 8:51 ` [PATCH 2/3] promisor-remote: introduce enum allow_lazy_fetch Christian Couder
2026-07-10 8:51 ` [PATCH 3/3] promisor-remote: teach 'fromAccepted' to GIT_NO_LAZY_FETCH Christian Couder
2026-07-10 19:50 ` [PATCH 0/3] Introduce a 'fromAccepted' option " brian m. carlson
2026-07-12 9:06 ` Christian Couder
2026-08-07 13:55 ` [PATCH 0/5] Introduce 'uploadpack.lazyFetchTrusted' Christian Couder
2026-08-07 13:55 ` [PATCH 1/5] promisor-remote: factor out lazy_fetch_objects() Christian Couder
2026-08-07 13:58 ` Christian Couder
2026-08-07 13:55 ` [PATCH 2/5] setup: extract path_allowlist_apply() Christian Couder
2026-08-07 13:55 ` [PATCH 3/5] setup: add 'allow_dot' arg to path_allowlist_apply() Christian Couder
2026-08-07 13:55 ` [PATCH 4/5] upload-pack: read uploadpack.lazyFetchTrusted Christian Couder
2026-08-07 13:55 ` [PATCH 5/5] builtin/upload-pack: set GIT_NO_LAZY_FETCH to 0 on trusted repo Christian Couder
2026-08-07 18:31 ` [PATCH 0/5] Introduce 'uploadpack.lazyFetchTrusted' Junio C Hamano
2026-08-10 8:06 ` Christian Couder
2026-08-11 5:55 ` Junio C Hamano
2026-08-13 15:47 ` [PATCH v2 " Christian Couder
2026-08-13 20:31 ` Junio C Hamano [this message]
2026-08-13 15:47 ` [PATCH v2 1/5] promisor-remote: factor out lazy_fetch_objects() Christian Couder
2026-08-13 15:47 ` [PATCH v2 2/5] setup: extract path_allowlist_apply() Christian Couder
2026-08-13 15:47 ` [PATCH v2 3/5] setup: add 'allow_dot' arg to path_allowlist_apply() Christian Couder
2026-08-13 15:47 ` [PATCH v2 4/5] upload-pack: read uploadpack.lazyFetchTrusted Christian Couder
2026-08-13 15:47 ` [PATCH v2 5/5] builtin/upload-pack: set GIT_NO_LAZY_FETCH to 0 on trusted repo Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0e9rcd9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox