From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Kenneth Lorber <keni@his.com>,
git@vger.kernel.org, redoste <redoste@redoste.xyz>,
Fabian Stelzer <fs@gigacodes.de>,
Xi Ruoyao <xry111@xry111.site>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 1/1] t7528: fix failure under csh
Date: Mon, 03 Aug 2026 07:42:03 -0700 [thread overview]
Message-ID: <xmqqy0enz2o4.fsf@gitster.g> (raw)
In-Reply-To: <am_5YymI-UnCT_s1@fruit.crustytoothpaste.net> (brian m. carlson's message of "Mon, 3 Aug 2026 02:13:56 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> @@ -82,7 +82,7 @@ test_expect_success GPGSSH 'create signed commits' '
>> test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agent' '
>> test_when_finished "test_unconfig commit.gpgsign" &&
>> test_config gpg.format ssh &&
>> - eval $(ssh-agent -T || ssh-agent) &&
>> + eval $(ssh-agent -T -s || ssh-agent -s) &&
>> test_when_finished "kill ${SSH_AGENT_PID}" &&
>> test_when_finished "test_unconfig user.signingkey" &&
>> mkdir tmpdir &&
>
> This seems reasonable. SHELL is defined by POSIX as "a pathname of the
> user's preferred command language interpreter." When we're running the
> testsuite, we don't care what that is and always want a POSIX
> sh-compatible output, so using `-s` is the right thing.
>
> I also don't see any other instances of `ssh-agent` in the codebase, so
> this looks like the only place we need to fix.
Thanks for being careful. Will queue.
prev parent reply other threads:[~2026-08-03 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 0:41 [PATCH 0/1] t7528: fix failure under csh Kenneth Lorber
2026-08-03 0:41 ` [PATCH 1/1] " Kenneth Lorber
2026-08-03 2:13 ` brian m. carlson
2026-08-03 14:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0enz2o4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=keni@his.com \
--cc=ps@pks.im \
--cc=redoste@redoste.xyz \
--cc=sandals@crustytoothpaste.net \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox