* [PATCH] completion: add git stash push
@ 2017-05-16 19:59 Thomas Gummerer
2017-05-16 20:12 ` Jonathan Nieder
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gummerer @ 2017-05-16 19:59 UTC (permalink / raw)
To: git; +Cc: Thomas Gummerer
When introducing git stash push in f5727e26e4 ("stash: introduce push
verb", 2017-02-19), I forgot to add it to the completion code. Add it
now.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---
contrib/completion/git-completion.bash | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index af658995d5..3f01249116 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2810,7 +2810,7 @@ _git_show_branch ()
_git_stash ()
{
local save_opts='--all --keep-index --no-keep-index --quiet --patch --include-untracked'
- local subcommands='save list show apply clear drop pop create branch'
+ local subcommands='push save list show apply clear drop pop create branch'
local subcommand="$(__git_find_on_cmdline "$subcommands")"
if [ -z "$subcommand" ]; then
case "$cur" in
@@ -2825,6 +2825,9 @@ _git_stash ()
esac
else
case "$subcommand,$cur" in
+ push,--*)
+ __gitcomp "$save_opts --message"
+ ;;
save,--*)
__gitcomp "$save_opts"
;;
--
2.13.0.rc2.279.g813ba54fc
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] completion: add git stash push
2017-05-16 19:59 [PATCH] completion: add git stash push Thomas Gummerer
@ 2017-05-16 20:12 ` Jonathan Nieder
2017-05-17 3:16 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2017-05-16 20:12 UTC (permalink / raw)
To: Thomas Gummerer; +Cc: git
Thomas Gummerer wrote:
> When introducing git stash push in f5727e26e4 ("stash: introduce push
> verb", 2017-02-19), I forgot to add it to the completion code. Add it
> now.
>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
> contrib/completion/git-completion.bash | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] completion: add git stash push
2017-05-16 20:12 ` Jonathan Nieder
@ 2017-05-17 3:16 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2017-05-17 3:16 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Thomas Gummerer, git
Jonathan Nieder <jrnieder@gmail.com> writes:
> Thomas Gummerer wrote:
>
>> When introducing git stash push in f5727e26e4 ("stash: introduce push
>> verb", 2017-02-19), I forgot to add it to the completion code. Add it
>> now.
>>
>> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
>> ---
>> contrib/completion/git-completion.bash | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks, both. Will queue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-17 3:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-16 19:59 [PATCH] completion: add git stash push Thomas Gummerer
2017-05-16 20:12 ` Jonathan Nieder
2017-05-17 3:16 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox