Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] allow user-configurable menucolor
Date: Thu, 3 Jan 2008 00:55:48 +0100	[thread overview]
Message-ID: <200801030055.48575.okuji@enbug.org> (raw)
In-Reply-To: <20080102214831.GA6322@thorin>

On Wednesday 02 January 2008 22:48, Robert Millan wrote:
> On Tue, Jan 01, 2008 at 06:38:06PM +0100, Robert Millan wrote:
> > `color' command is necessary to propagate user setting from environment
> > variables to the internal color of our current terminal.
>
> Vesa suggested (on IRC) to use write hooks (grub_env_write_hook_t) in
> variables to avoid this.  I tend to agree.  What do others think?

Generally speaking, if you are planning to read settings by scripting, it is 
better to use a variable. If you are planning to change the behavior by 
options, it is better to use a command.

Or, semantically, if you want to make an action, a command is suitable. If you 
want to set a state, a variable is more appropriate.

Anyway, you can accomplish nearly the same thing with both, thanks to the 
hooks, so the choice is mostly a matter of taste.

Personally, I think this should come up with variables. It is just like a 
prompt in bash for me.

Okuji



  reply	other threads:[~2008-01-02 23:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 12:47 [PATCH] allow user-configurable menucolor Robert Millan
2008-01-01 13:14 ` Vesa Jääskeläinen
2008-01-01 13:40   ` Robert Millan
2008-01-01 13:51     ` Vesa Jääskeläinen
2008-01-01 14:45       ` Robert Millan
2008-01-01 17:38         ` Robert Millan
2008-01-02 21:48           ` Robert Millan
2008-01-02 23:55             ` Yoshinori K. Okuji [this message]
2008-01-03  0:56               ` Robert Millan
2008-01-02 23:42 ` Yoshinori K. Okuji
2008-01-03  1:04   ` Robert Millan
2008-01-03 15:35     ` Robert Millan
2008-01-03 16:04       ` Vesa Jääskeläinen
2008-01-03 16:38         ` Robert Millan
2008-01-23  8:56           ` Marco Gerards
2008-01-04  8:02         ` opening new context (was: [PATCH] allow user-configurable menucolor) Robert Millan
2008-01-05  1:34           ` Yoshinori K. Okuji
2008-01-05 11:49             ` Robert Millan
2008-01-05 12:03               ` Yoshinori K. Okuji
2008-01-05 12:09                 ` Robert Millan
2008-01-05 21:45       ` [PATCH] allow user-configurable menucolor Jeroen Dekkers
2008-01-05 23:42         ` Robert Millan
2008-01-06 11:33           ` Jeroen Dekkers
2008-01-06 12:54             ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801030055.48575.okuji@enbug.org \
    --to=okuji@enbug.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox