Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: phcoder@gmail.com, bean123ch@gmail.com,
	David Miller <davem@davemloft.net>
Subject: Re: powerpc/sparc problems
Date: Sat, 17 Oct 2009 12:11:10 +0200	[thread overview]
Message-ID: <20091017101110.GA11305@thorin> (raw)
In-Reply-To: <1255742496.2746.26.camel@mj>

On Fri, Oct 16, 2009 at 09:21:36PM -0400, Pavel Roskin wrote:
> On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote:
> > 
> > They worked perfectly fine for me on a real system with
> > a real compiler and glibc.
> > 
> > If you're going to use cross compilation to test, use
> > a full cross toolset and glibc build not some hacked
> > up uclibc thing.

But we're testing a feature of libgcc, not glibc.

> I have tested the current GRUB on PowerPC.  It's Fedora 11 with a real
> glibc.  I added __ashldi3 to the arguments of AC_CHECK_FUNCS.  The check
> fails.  Yet __ashldi3 is present in libgcc and is exported
> unconditionally.
> 
> The reason is that -nostdlib is added to CFLAGS immediately above 
> AC_CHECK_FUNCS.  -nostdlib disables linking against libgcc.
> 
> I believe the checks for __bswapsi2 __bswapdi2 would fail on sparc64 for
> the same reason.

Then why not just add -lgcc after -nostdlib?

> I'm surprised that my code is being reverted immediately before the
> release and the result is not tested.

I was under the impression that there was consensus that it should be
reverted.  Excuse me for not having tracked this more closely.

Looking at 2631:2632, it seems to me that:

  - Using configure checks is the right way, we just need to make them
    work (I think -lgcc should do it).

  - The ifdef wraps that have been added to sparc64/libgcc.h should also be
    in powerpc/libgcc.h.

>  It's one thing to revert the code
> that has just been committed, and it's entirely different when the code
> has been in the repository for months.

Yes.  There's been a long freeze period during which it'd have been more
appropiate to discuss this kind of things...

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  parent reply	other threads:[~2009-10-17 10:11 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12  8:55 powerpc/sparc problems Felix Zielcke
2009-10-12  9:05 ` David Miller
2009-10-12  9:42   ` Felix Zielcke
2009-10-12  9:56   ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:11     ` David Miller
2009-10-12 10:27     ` Felix Zielcke
2009-10-12  9:26 ` Vladimir 'phcoder' Serbinenko
2009-10-12  9:33 ` Felix Zielcke
2009-10-20 18:07   ` rubisher
2009-10-20 20:24     ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:59       ` rubisher
2009-10-12  9:58 ` Bean
2009-10-12 10:14   ` David Miller
2009-10-12 10:26     ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:28       ` David Miller
2009-10-12 15:29         ` Pavel Roskin
2009-10-12 15:45           ` Vladimir 'phcoder' Serbinenko
2009-10-12 22:03             ` Pavel Roskin
2009-10-12 23:39             ` David Miller
2009-10-15 11:58         ` Vladimir 'phcoder' Serbinenko
2009-10-15 22:41           ` Pavel Roskin
2009-10-16 12:44             ` David Miller
2009-10-16 14:10               ` Pavel Roskin
2009-10-17  1:21               ` Pavel Roskin
2009-10-17  9:08                 ` Vladimir 'phcoder' Serbinenko
2009-10-17 10:11                 ` Robert Millan [this message]
2009-10-20 21:38                   ` [PATCH] auto-generate libgcc.h Robert Millan
2009-10-21  6:28                     ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:55                       ` rubisher
2009-10-21 21:00                         ` Vladimir 'phcoder' Serbinenko
2009-10-23 16:19                           ` rubisher
2009-10-12 10:31     ` powerpc/sparc problems Bean
2009-10-12 11:07       ` David Miller
2009-10-12 14:05         ` Bean
2009-10-14 16:37       ` Robert Millan
2009-10-21 16:03   ` rubisher
2009-10-21 20:15     ` Bean
2009-10-28 10:24 ` Felix Zielcke
2009-10-28 10:29   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-10-22  9:12 rubisher
2009-10-22  9:31 ` Bean
2009-10-23 20:34   ` rubisher
2009-10-24  6:13     ` Bean
2009-10-25 15:22       ` rubisher
2009-10-25 15:57         ` Bean
2009-10-26 21:06           ` rubisher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091017101110.GA11305@thorin \
    --to=rmh@aybabtu.com \
    --cc=bean123ch@gmail.com \
    --cc=davem@davemloft.net \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox