From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: David Miller <davem@davemloft.net>
Subject: Re: powerpc/sparc problems
Date: Mon, 12 Oct 2009 11:26:38 +0200 [thread overview]
Message-ID: <4AD2F64E.5020403@gmail.com> (raw)
In-Reply-To: <1255337746.3204.23.camel@fz.local>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
Felix Zielcke wrote:
> David are you still there?
> And also anyone who has access to a powerpc machine (and experience)?
>
> In Debian we the problem that the `__ashldi3' and `__bswapsi2' symbols
> can't be found in the grub-ieee1275 build on powerpc and also sparc.
>
>
I've come across the same problem when porting grub2 to MIPS. The
solution is the attached patch. I'll test it today on my imac g3
> Jordi already noticed this with the 1.96+20090721-4 IIRC and now other
> people noticed this with 1.97~beta3
> AFAICS there wasn't anything relevant changed on our side, so seems to
> be a gcc issue.
>
> `__ashldi3' is listed in include/grub/powerpc/libgcc.h and `__bswapsi2'
> in the sparc64 header.
> But something has now changed that this isn't enough anymore, at least
> in Debian.
>
> We used gcc 4.3.3 at the time Jordi noticed this and now switched to
> gcc-4.4.1.
>
> And David we still have this sparc bug open, which I forwared to
> grub-devel:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538030
>
>
>
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
[-- Attachment #2: ppcfix.diff --]
[-- Type: text/x-patch, Size: 1425 bytes --]
diff --git a/include/grub/powerpc/libgcc.h b/include/grub/powerpc/libgcc.h
index ea4b073..0ff8964 100644
--- a/include/grub/powerpc/libgcc.h
+++ b/include/grub/powerpc/libgcc.h
@@ -16,9 +16,9 @@
* along with GRUB. If not, see <http://www.gnu.org/licenses/>.
*/
-void EXPORT_FUNC (memset) (void) __attribute__ ((weak));
-void EXPORT_FUNC (__ashldi3) (void) __attribute__ ((weak));
-void EXPORT_FUNC (__ashrdi3) (void) __attribute__ ((weak));
-void EXPORT_FUNC (__lshrdi3) (void) __attribute__ ((weak));
-void EXPORT_FUNC (__trampoline_setup) (void) __attribute__ ((weak));
-void EXPORT_FUNC (__ucmpdi2) (void) __attribute__ ((weak));
+void EXPORT_FUNC (memset) (void);
+void EXPORT_FUNC (__ashldi3) (void);
+void EXPORT_FUNC (__ashrdi3) (void);
+void EXPORT_FUNC (__lshrdi3) (void);
+void EXPORT_FUNC (__trampoline_setup) (void);
+void EXPORT_FUNC (__ucmpdi2) (void);
diff --git a/include/grub/sparc64/libgcc.h b/include/grub/sparc64/libgcc.h
index 5d18c5c..6a3d804 100644
--- a/include/grub/sparc64/libgcc.h
+++ b/include/grub/sparc64/libgcc.h
@@ -21,7 +21,7 @@
void EXPORT_FUNC (memset) (void);
typedef int SItype __attribute__ ((mode (SI)));
-SItype EXPORT_FUNC (__bswapsi2) (SItype) __attribute__ ((weak));
+SItype EXPORT_FUNC (__bswapsi2) (SItype);
typedef int DItype __attribute__ ((mode (DI)));
-DItype EXPORT_FUNC (__bswapdi2) (DItype) __attribute__ ((weak));
+DItype EXPORT_FUNC (__bswapdi2) (DItype);
next prev parent reply other threads:[~2009-10-12 9:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 8:55 powerpc/sparc problems Felix Zielcke
2009-10-12 9:05 ` David Miller
2009-10-12 9:42 ` Felix Zielcke
2009-10-12 9:56 ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:11 ` David Miller
2009-10-12 10:27 ` Felix Zielcke
2009-10-12 9:26 ` Vladimir 'phcoder' Serbinenko [this message]
2009-10-12 9:33 ` Felix Zielcke
2009-10-20 18:07 ` rubisher
2009-10-20 20:24 ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:59 ` rubisher
2009-10-12 9:58 ` Bean
2009-10-12 10:14 ` David Miller
2009-10-12 10:26 ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:28 ` David Miller
2009-10-12 15:29 ` Pavel Roskin
2009-10-12 15:45 ` Vladimir 'phcoder' Serbinenko
2009-10-12 22:03 ` Pavel Roskin
2009-10-12 23:39 ` David Miller
2009-10-15 11:58 ` Vladimir 'phcoder' Serbinenko
2009-10-15 22:41 ` Pavel Roskin
2009-10-16 12:44 ` David Miller
2009-10-16 14:10 ` Pavel Roskin
2009-10-17 1:21 ` Pavel Roskin
2009-10-17 9:08 ` Vladimir 'phcoder' Serbinenko
2009-10-17 10:11 ` Robert Millan
2009-10-20 21:38 ` [PATCH] auto-generate libgcc.h Robert Millan
2009-10-21 6:28 ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:55 ` rubisher
2009-10-21 21:00 ` Vladimir 'phcoder' Serbinenko
2009-10-23 16:19 ` rubisher
2009-10-12 10:31 ` powerpc/sparc problems Bean
2009-10-12 11:07 ` David Miller
2009-10-12 14:05 ` Bean
2009-10-14 16:37 ` Robert Millan
2009-10-21 16:03 ` rubisher
2009-10-21 20:15 ` Bean
2009-10-28 10:24 ` Felix Zielcke
2009-10-28 10:29 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-10-22 9:12 rubisher
2009-10-22 9:31 ` Bean
2009-10-23 20:34 ` rubisher
2009-10-24 6:13 ` Bean
2009-10-25 15:22 ` rubisher
2009-10-25 15:57 ` Bean
2009-10-26 21:06 ` rubisher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD2F64E.5020403@gmail.com \
--to=phcoder@gmail.com \
--cc=davem@davemloft.net \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox