From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU
Date: Thu, 08 Oct 2009 14:17:16 +0200 [thread overview]
Message-ID: <4ACDD84C.4030102@gmail.com> (raw)
In-Reply-To: <1254996731.2857.13.camel@fz.local>
Felix Zielcke wrote:
> Am Mittwoch, den 07.10.2009, 23:13 +0200 schrieb Robert Millan:
>
>
>> (grub_cpuid_has_longmode): ... this. Update all users. Remove
>> `unsigned' attribute.
>>
>
> I think that should be `static' not `unsigned':
>
> -static unsigned char has_longmode = 0;
> +unsigned char grub_cpuid_has_longmode = 0;
>
> But don't we need to add now an `insmod cpuid' in grub-mkconfig so that
> this actually works / is useful?
> Or does the cpuid command get loaded automatically somewhere already?
>
>
It gets loaded because of symbol dependency of bsd.mod on
grub_cpuid_has_longmode
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
next prev parent reply other threads:[~2009-10-08 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 21:13 [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU Robert Millan
2009-10-08 10:12 ` Felix Zielcke
2009-10-08 12:17 ` Vladimir 'phcoder' Serbinenko [this message]
2009-10-09 17:51 ` Robert Millan
2009-10-08 23:10 ` Vladimir 'phcoder' Serbinenko
2009-10-09 18:25 ` Robert Millan
2009-10-09 20:39 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACDD84C.4030102@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox