Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU
Date: Fri, 09 Oct 2009 22:39:26 +0200	[thread overview]
Message-ID: <4ACF9F7E.7010408@gmail.com> (raw)
In-Reply-To: <20091009182553.GD4645@thorin>

Robert Millan wrote:
> Hi,
>
> I didn't notice this mail untill a few minutes ago (was still in fetch
> queue), so my first patch was already checked in.
>
> On Fri, Oct 09, 2009 at 01:10:12AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>   
>>> Index: include/grub/i386/cpuid.h
>>> ===================================================================
>>> --- include/grub/i386/cpuid.h	(revision 0)
>>> +++ include/grub/i386/cpuid.h	(revision 0)
>>>       
>> This file doesn't follow convention of having an ifdef around the file
>>     
>
> Thanks, I've added it now.
>
>   
>>> +extern unsigned char grub_cpuid_has_longmode;
>>>       
>> I don't like it being declared as a variable: user may inadvertently assign a value to it. I would be more confortable with a function
>>     
>
> I tend to prefer a (const) function too, but this required some restructuring
> in cpuid.c so for 1.97 I opted for keeping the changes minimal.
>
>   
Why would these changes be intrusive? It's just a function returning  a
static value or did I miss something?

-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git 




      reply	other threads:[~2009-10-09 20:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 21:13 [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU Robert Millan
2009-10-08 10:12 ` Felix Zielcke
2009-10-08 12:17   ` Vladimir 'phcoder' Serbinenko
2009-10-09 17:51   ` Robert Millan
2009-10-08 23:10 ` Vladimir 'phcoder' Serbinenko
2009-10-09 18:25   ` Robert Millan
2009-10-09 20:39     ` Vladimir 'phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ACF9F7E.7010408@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox