Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix grub.d/10_windows for Cygwin 1.7
Date: Sun, 09 May 2010 16:37:12 +0200	[thread overview]
Message-ID: <4BE6C898.4070704@t-online.de> (raw)
In-Reply-To: <4BE6B89F.1020406@gmail.com>

Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Christian Franke wrote:
>    
>> This change is already included in Cygwin package grub-1.98-2.
>>
>>      
> -
> +  test -z "$needmap" || cat<<EOF
> +	drivemap -s (hd0) \$root
> +EOF
> You can't be sure on script runtime that C: is on hd0. Ironically especially when drivemap is used.
> But drivemap -s (hd0) (hd0) is a nop, so no harm done.
> On the other hand Vista and 7 are incompatible with drivemap so you have to skip drivemap on those systems. Look at 30_os-prober.in:
>        case ${LONGNAME} in
>          Windows\ Vista*|Windows\ 7*)
>          ;;
>          *)
>            cat<<  EOF
>          drivemap -s (hd0) \${root}
> EOF
>          ;;
>        esac
>    

This is already considered in the script: $needmap is set if ntldr is 
found but not if bootmgr is found.


-- 
Regards,
Christian Franke




  reply	other threads:[~2010-05-09 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 20:16 [PATCH] Fix grub.d/10_windows for Cygwin 1.7 Christian Franke
2010-05-09 13:29 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-09 14:37   ` Christian Franke [this message]
2010-05-09 14:56     ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE6C898.4070704@t-online.de \
    --to=christian.franke@t-online.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox