Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix grub.d/10_windows for Cygwin 1.7
Date: Sun, 09 May 2010 16:56:22 +0200	[thread overview]
Message-ID: <4BE6CD16.8040602@gmail.com> (raw)
In-Reply-To: <4BE6C898.4070704@t-online.de>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

Christian Franke wrote: 
>> -
>> +  test -z "$needmap" || cat<<EOF
>> +    drivemap -s (hd0) \$root
>> +EOF
>> You can't be sure on script runtime that C: is on hd0. Ironically
>> especially when drivemap is used.
>> But drivemap -s (hd0) (hd0) is a nop, so no harm done.
>> On the other hand Vista and 7 are incompatible with drivemap so you
>> have to skip drivemap on those systems.
>>    
>
> This is already considered in the script: $needmap is set if ntldr is
> found but not if bootmgr is found.
>
I misread your script then. You can commit the patch into mainline.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]

      reply	other threads:[~2010-05-09 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 20:16 [PATCH] Fix grub.d/10_windows for Cygwin 1.7 Christian Franke
2010-05-09 13:29 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-09 14:37   ` Christian Franke
2010-05-09 14:56     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE6CD16.8040602@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox