From: "Grégoire Sutre" <gregoire.sutre@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix grub-probe partition naming on FreeBSD
Date: Sun, 13 Jun 2010 17:53:30 +0200 [thread overview]
Message-ID: <4C14FEFA.2070209@gmail.com> (raw)
In-Reply-To: <20100613104811.GM21862@riva.ucam.org>
Hi Colin,
> The following patch is aimed at fixing this Debian bug:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585068
>
> I've tested it on Debian GNU/kFreeBSD and it seems to be producing sensible
> output now.
In another thread [1], it was observed that offsets are not absolute in
FreeBSD disklabels, whereas they are absolute in NetBSD disklabels.
I believe that find_partition_start is supposed to return absolute
offsets. Does DIOCGDINFO convert the on-disk label into absolute
offsets on FreeBSD?
> The one glitch is that if you ask it to probe /dev/ad0s1a, it returns
> (hd0,msdos1) rather than (hd0,msdos1,bsd1): this is because both /dev/ad0s1
> and /dev/ad0s1a have the same start sector, and it just uses the first one
> it finds. When I set prefix to (hd0,msdos1)/boot/grub, GRUB can read from
> that perfectly well, so can I ignore this glitch on the basis that it
> doesn't cause a practical problem?
We get a similar behavior on NetBSD. As I mentioned in [2], this may
have an impact when the kernel is (a) loaded with the multiboot
protocol, and (b) relies on the MBI boot_device field to find its
root -- which it shouldn't anyway, so it's not a big deal. I am not
aware of other impacts.
I know that hybrid msdos+gpt are not recommended, but, for the record,
I guess that another glitch could happen if /dev/ad0s1X (msdos) and
/dev/ad0p1Y (gpt) are actually the same partition: grub-probe would
return the same answer for both, thus ignoring the user's desire to use
a specific partitioning scheme. I believe that such a partitioning is
supported by FreeBSD, but I may be wrong (please tell me if so), I did
not test this myself.
Grégoire
[1] http://lists.gnu.org/archive/html/grub-devel/2010-05/msg00065.html
[2] http://lists.gnu.org/archive/html/grub-devel/2010-06/msg00075.html
next prev parent reply other threads:[~2010-06-13 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 10:48 [PATCH] Fix grub-probe partition naming on FreeBSD Colin Watson
2010-06-13 15:53 ` Grégoire Sutre [this message]
2010-07-01 20:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C14FEFA.2070209@gmail.com \
--to=gregoire.sutre@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox