From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Fix grub-probe partition naming on FreeBSD
Date: Thu, 01 Jul 2010 22:57:00 +0200 [thread overview]
Message-ID: <4C2D011C.3020401@gmail.com> (raw)
In-Reply-To: <20100613104811.GM21862@riva.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On 06/13/2010 12:48 PM, Colin Watson wrote:
> The following patch is aimed at fixing this Debian bug:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585068
>
>
> +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> +static int
> +device_is_wholedisk (const char *os_dev)
> +{
> + const char *p;
> +
> + if (strncmp (os_dev, "/dev/", 5) != 0)
> + return 0;
> +
> + for (p = os_dev + 5; *p; ++p)
>
Please use sizeof. Other than that please go ahead.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-07-01 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 10:48 [PATCH] Fix grub-probe partition naming on FreeBSD Colin Watson
2010-06-13 15:53 ` Grégoire Sutre
2010-07-01 20:57 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2D011C.3020401@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox