From: Daniel Axtens <dja@axtens.net>
To: grub-devel@gnu.org
Cc: rashmica.g@gmail.com, alastair@d-silva.org
Subject: Re: [PATCH 13/18] grub-install: support embedding x509 certificates
Date: Mon, 12 Oct 2020 14:38:50 +1100 [thread overview]
Message-ID: <87eem4w1th.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20201002051321.1538488-14-dja@axtens.net>
> + case 'x':
> + arguments->x509keys = xrealloc (arguments->x509keys,
> + sizeof (arguments->x509keys[0])
> + * (arguments->nx509keys + 1));
> + arguments->pubkeys[arguments->nx509keys++] = xstrdup (arg);
This should be arguments->x509keys[]. I will fix this in v2. (We caught
this internally but I failed to apply the fix to my tree before sending
it out!)
Kind regards,
Daniel
next prev parent reply other threads:[~2020-10-12 3:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 5:13 [PATCH 00/18] Verify appended signatures from grub Daniel Axtens
2020-10-02 5:13 ` [PATCH 01/18] docs/grub: grub-install is no longer a shell script Daniel Axtens
2020-10-02 5:13 ` [PATCH 02/18] docs/grub: --pubkey has been supported for some time Daniel Axtens
2020-10-02 5:13 ` [PATCH 03/18] dl: provide a fake grub_dl_set_persistent for the emu target Daniel Axtens
2020-10-02 5:13 ` [PATCH 04/18] verifiers: factor unsafe module handling out of shim_lock Daniel Axtens
2020-10-02 5:13 ` [PATCH 05/18] pgp: factor out rsa_pad Daniel Axtens
2020-10-02 5:13 ` [PATCH 06/18] crypto: move storage for grub_crypto_pk_* to crypto.c Daniel Axtens
2020-10-02 5:13 ` [PATCH 07/18] posix_wrap: tweaks in preparation for libtasn1 Daniel Axtens
2020-10-02 5:13 ` [PATCH 08/18] libtasn1: import libtasn1-4.16.0 Daniel Axtens
2020-10-02 17:58 ` Konrad Rzeszutek Wilk
2020-10-06 23:54 ` Daniel Axtens
2020-10-02 5:13 ` [PATCH 09/18] libtasn1: disable code not needed in grub Daniel Axtens
2020-10-02 5:13 ` [PATCH 10/18] libtasn1: changes for grub compatibility Daniel Axtens
2020-10-02 5:13 ` [PATCH 11/18] libtasn1: compile into asn1 module Daniel Axtens
2020-10-02 5:13 ` [PATCH 12/18] test_asn1: test module for libtasn1 Daniel Axtens
2020-10-02 5:13 ` [PATCH 13/18] grub-install: support embedding x509 certificates Daniel Axtens
2020-10-12 3:38 ` Daniel Axtens [this message]
2020-10-02 5:13 ` [PATCH 14/18] appended signatures: import GNUTLS's ASN.1 description files Daniel Axtens
2020-10-02 5:13 ` [PATCH 15/18] appended signatures: parse PKCS#7 signedData and X.509 certificates Daniel Axtens
2020-10-02 5:13 ` [PATCH 16/18] appended signatures: support verifying appended signatures Daniel Axtens
2020-10-02 5:13 ` [PATCH 17/18] appended signatures: verification tests Daniel Axtens
2020-10-02 5:13 ` [PATCH 18/18] appended signatures: documentation Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eem4w1th.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=alastair@d-silva.org \
--cc=grub-devel@gnu.org \
--cc=rashmica.g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox