From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix warning in fs/xfs.c
Date: Thu, 03 Jul 2008 20:21:43 +0200 [thread overview]
Message-ID: <87tzf66d6w.fsf@xs4all.nl> (raw)
In-Reply-To: <20080702001046.7554.37059.stgit@dv.roinet.com> (Pavel Roskin's message of "Tue, 01 Jul 2008 20:10:46 -0400")
Pavel Roskin <proski@gnu.org> writes:
> ChangeLog:
> * fs/xfs.c (struct grub_xfs_dir_header): Use names similar to
> those in Linux XFS code. Provide a way to access 64-bit parent
> inode.
> (grub_xfs_iterate_dir): Use the new names. Avoid reading past
> the end of struct grub_xfs_dir_header.
*please* do not look at Linux code or whatever *and* contribute to
GRUB. It might cause copyright troubles I will have to deal with :-/
I do not see the advantage of this patch. Can you please explain why
we need these name changes?
--
Marco
next prev parent reply other threads:[~2008-07-03 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 0:10 [PATCH] Fix warning in fs/xfs.c Pavel Roskin
2008-07-03 18:21 ` Marco Gerards [this message]
2008-07-03 18:48 ` Pavel Roskin
2008-07-20 18:50 ` Marco Gerards
2008-07-20 20:28 ` Pavel Roskin
2008-07-21 21:40 ` Cesare Leonardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzf66d6w.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox