From: James Bottomley <jejb@linux.ibm.com>
To: development@efficientek.com
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com,
ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com,
david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com,
frankeh@us.ibm.com,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 1/3] cryptodisk: make the password getter and additional argument to recover_key
Date: Fri, 13 Nov 2020 07:44:44 -0800 [thread overview]
Message-ID: <ba23999887d74f6ecd7773ba281d1a3537b65893.camel@linux.ibm.com> (raw)
In-Reply-To: <20201113000256.47578926@crass-HP-ZBook-15-G2>
On Fri, 2020-11-13 at 00:02 -0600, Glenn Washburn wrote:
[...]
> diff --git a/grub-core/disk/geli.c b/grub-core/disk/geli.c
> > index e9d23299a..5514c16a3 100644
> > --- a/grub-core/disk/geli.c
> > +++ b/grub-core/disk/geli.c
> > @@ -398,7 +398,8 @@ configure_ciphers (grub_disk_t disk, const char
> > *check_uuid, }
> >
> > static grub_err_t
> > -recover_key (grub_disk_t source, grub_cryptodisk_t dev)
> > +recover_key (grub_disk_t source, grub_cryptodisk_t dev,
> > + grub_passwd_cb *password_get)
> > {
> > grub_size_t keysize;
> > grub_uint8_t digest[GRUB_CRYPTO_MAX_MDLEN];
> > @@ -442,7 +443,7 @@ recover_key (grub_disk_t source,
> > grub_cryptodisk_t dev) source->partition ? "," : "", tmp ? : "",
> > dev->uuid);
> > grub_free (tmp);
>
> In luks.c and luks2.c below, grub_printf_ is made conditional, but
> not here. It probably should be.
Yes, I can add that.
James
next prev parent reply other threads:[~2020-11-13 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 1:22 [PATCH 0/3] Add ability to use SEV provisioned secrets for disk decryption James Bottomley
2020-11-13 1:22 ` [PATCH 1/3] cryptodisk: make the password getter and additional argument to recover_key James Bottomley
2020-11-13 6:02 ` Glenn Washburn
2020-11-13 15:44 ` James Bottomley [this message]
2020-11-13 1:22 ` [PATCH 2/3] cryptodisk: add OS provided secret support James Bottomley
2020-11-13 13:23 ` Dr. David Alan Gilbert
2020-11-13 15:49 ` James Bottomley
2020-11-13 1:22 ` [PATCH 3/3] efi: Add API for retrieving the AMD SEV injected secret for cryptodisk James Bottomley
2020-11-13 17:50 ` [PATCH 0/3] Add ability to use SEV provisioned secrets for disk decryption Dr. David Alan Gilbert
2020-11-13 17:58 ` James Bottomley
2020-11-13 18:21 ` Dr. David Alan Gilbert
2020-11-13 19:26 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba23999887d74f6ecd7773ba281d1a3537b65893.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=Dov.Murik1@il.ibm.com \
--cc=ashish.kalra@amd.com \
--cc=brijesh.singh@amd.com \
--cc=david.kaplan@amd.com \
--cc=development@efficientek.com \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=frankeh@us.ibm.com \
--cc=grub-devel@gnu.org \
--cc=jon.grimm@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=tobin@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox