* [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test
@ 2018-11-15 15:51 Juha-Pekka Heikkila
2018-11-15 16:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Juha-Pekka Heikkila @ 2018-11-15 15:51 UTC (permalink / raw)
To: igt-dev
Add test which create fb bigger than plane and clamp fb from all sides.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_plane.c | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 45e0a30..d79c22e 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -41,6 +41,7 @@ typedef struct {
int drm_fd;
igt_display_t display;
igt_pipe_crc_t *pipe_crc;
+ uint32_t crop;
} data_t;
static color_t red = { 1.0f, 0.0f, 0.0f };
@@ -412,12 +413,22 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
const color_t *c = &colors[color];
struct igt_fb old_fb = *fb;
- igt_create_color_fb(data->drm_fd, width, height,
- format, LOCAL_DRM_FORMAT_MOD_NONE,
+ igt_create_color_fb(data->drm_fd, width+data->crop*2,
+ height+data->crop*2, format,
+ LOCAL_DRM_FORMAT_MOD_NONE,
c->red, c->green, c->blue, fb);
igt_plane_set_fb(plane, fb);
+ /*
+ * if clamping test
+ */
+ if (width-data->crop != 0) {
+ igt_plane_set_size(plane, width, height);
+ igt_fb_set_position(fb, plane, data->crop, data->crop);
+ igt_fb_set_size(fb, plane, width, height);
+ }
+
igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
@@ -435,6 +446,12 @@ static void test_format_plane(data_t *data, enum pipe pipe,
uint64_t width, height;
igt_crc_t ref_crc[ARRAY_SIZE(colors)];
+ /*
+ * No clamping test for cursor plane
+ */
+ if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR)
+ return;
+
mode = igt_output_get_mode(output);
if (plane->type != DRM_PLANE_TYPE_CURSOR) {
width = mode->hdisplay;
@@ -554,6 +571,13 @@ run_tests_for_pipe_plane(data_t *data, enum pipe pipe)
kmstest_pipe_name(pipe))
test_pixel_formats(data, pipe);
+ igt_subtest_f("pixel-format-pipe-%s-planes-source-clamping",
+ kmstest_pipe_name(pipe)) {
+ data->crop = 4;
+ test_pixel_formats(data, pipe);
+ }
+
+ data->crop = 0;
igt_subtest_f("plane-position-covered-pipe-%s-planes",
kmstest_pipe_name(pipe))
test_plane_position(data, pipe, TEST_POSITION_FULLY_COVERED);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add source clamping test 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila @ 2018-11-15 16:16 ` Patchwork 2018-11-15 19:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (4 subsequent siblings) 5 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2018-11-15 16:16 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev == Series Details == Series: tests/kms_plane: add source clamping test URL : https://patchwork.freedesktop.org/series/52541/ State : success == Summary == = CI Bug Log - changes from IGT_4715 -> IGTPW_2064 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/52541/revisions/1/mbox/ == Known issues == Here are the changes found in IGTPW_2064 that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_ctx_create@basic-files: fi-icl-u2: PASS -> DMESG-WARN (fdo#107724) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-icl-u: PASS -> INCOMPLETE (fdo#107713) ==== Possible fixes ==== igt@drv_selftest@live_execlists: fi-apl-guc: INCOMPLETE (fdo#103927, fdo#108622) -> PASS igt@gem_exec_suspend@basic-s3: fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS +2 fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362 fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713 fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724 fdo#108622 https://bugs.freedesktop.org/show_bug.cgi?id=108622 == Participating hosts (51 -> 45) == Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-s3 == Build changes == * IGT: IGT_4715 -> IGTPW_2064 CI_DRM_5141: fcdadbabc3216aa16c6d8236d55c5e5c8261cc91 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2064: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2064/ IGT_4715: 111593c49d812a4f4ff9ab0ef053a3ab88a6f73f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_plane@pixel-format-pipe-a-planes-source-clamping +igt@kms_plane@pixel-format-pipe-b-planes-source-clamping +igt@kms_plane@pixel-format-pipe-c-planes-source-clamping +igt@kms_plane@pixel-format-pipe-d-planes-source-clamping +igt@kms_plane@pixel-format-pipe-e-planes-source-clamping +igt@kms_plane@pixel-format-pipe-f-planes-source-clamping == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2064/issues.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: add source clamping test 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila 2018-11-15 16:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2018-11-15 19:40 ` Patchwork 2018-11-20 11:30 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst ` (3 subsequent siblings) 5 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2018-11-15 19:40 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev == Series Details == Series: tests/kms_plane: add source clamping test URL : https://patchwork.freedesktop.org/series/52541/ State : success == Summary == = CI Bug Log - changes from IGT_4715_full -> IGTPW_2064_full = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/52541/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in IGTPW_2064_full: === IGT changes === ==== Possible regressions ==== {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}: shard-glk: NOTRUN -> FAIL +1 {igt@runner@aborted}: shard-snb: NOTRUN -> FAIL == Known issues == Here are the changes found in IGTPW_2064_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_pwrite@big-gtt-fbr: shard-apl: PASS -> INCOMPLETE (fdo#103927) igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: shard-glk: PASS -> DMESG-WARN (fdo#107956) igt@kms_color@pipe-a-legacy-gamma: shard-kbl: PASS -> FAIL (fdo#104782, fdo#108145) shard-apl: PASS -> FAIL (fdo#104782, fdo#108145) igt@kms_color@pipe-b-legacy-gamma: shard-apl: PASS -> FAIL (fdo#104782) shard-kbl: PASS -> FAIL (fdo#104782) igt@kms_cursor_crc@cursor-256x256-random: shard-glk: PASS -> FAIL (fdo#103232) +2 shard-apl: PASS -> FAIL (fdo#103232) +3 igt@kms_cursor_crc@cursor-64x64-dpms: shard-kbl: PASS -> FAIL (fdo#103232) +1 igt@kms_cursor_crc@cursor-64x64-suspend: shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359) igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt: shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763) +4 igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu: shard-kbl: PASS -> FAIL (fdo#103167) +1 igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: shard-apl: PASS -> FAIL (fdo#103167) +4 igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt: shard-glk: PASS -> FAIL (fdo#103167) +6 igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: shard-glk: PASS -> DMESG-FAIL (fdo#106538, fdo#103167, fdo#105763) igt@kms_plane@pixel-format-pipe-c-planes: shard-glk: PASS -> FAIL (fdo#103166) +1 shard-kbl: PASS -> FAIL (fdo#103166) igt@kms_plane_multiple@atomic-pipe-b-tiling-y: shard-apl: PASS -> FAIL (fdo#103166) +2 igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) shard-hsw: PASS -> FAIL (fdo#99912) igt@kms_vblank@pipe-c-ts-continuation-idle-hang: shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +11 igt@perf@polling: shard-hsw: PASS -> FAIL (fdo#102252) igt@prime_vgem@fence-wait-blt: shard-snb: PASS -> DMESG-WARN (fdo#107469) ==== Possible fixes ==== igt@gem_eio@in-flight-suspend: shard-kbl: INCOMPLETE (fdo#103665, fdo#106702) -> PASS igt@gem_ppgtt@blt-vs-render-ctx0: shard-kbl: INCOMPLETE (fdo#103665, fdo#106023, fdo#106887) -> PASS igt@gem_tiled_blits@normal: shard-apl: INCOMPLETE (fdo#103927) -> PASS igt@kms_color@pipe-b-degamma: shard-apl: FAIL (fdo#104782) -> PASS igt@kms_cursor_crc@cursor-128x128-sliding: shard-kbl: FAIL (fdo#103232) -> PASS igt@kms_cursor_crc@cursor-256x256-dpms: shard-glk: FAIL (fdo#103232) -> PASS +4 igt@kms_cursor_crc@cursor-256x256-suspend: shard-apl: FAIL (fdo#103191, fdo#103232) -> PASS igt@kms_cursor_crc@cursor-256x85-random: shard-apl: FAIL (fdo#103232) -> PASS +2 igt@kms_flip@dpms-vs-vblank-race-interruptible: shard-glk: FAIL (fdo#103060) -> PASS igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack: shard-snb: INCOMPLETE (fdo#105411) -> PASS igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: shard-apl: FAIL (fdo#103167) -> PASS +3 igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move: shard-kbl: FAIL (fdo#103167) -> PASS +1 igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu: shard-glk: FAIL (fdo#103167) -> PASS +5 igt@kms_plane@plane-position-covered-pipe-a-planes: shard-glk: FAIL (fdo#103166) -> PASS +4 igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: shard-apl: FAIL (fdo#108145) -> PASS +1 igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: shard-glk: FAIL (fdo#108145) -> PASS shard-kbl: FAIL (fdo#108145) -> PASS igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: shard-apl: FAIL (fdo#103166) -> PASS +4 shard-kbl: FAIL (fdo#103166) -> PASS +2 {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166 fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167 fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232 fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359 fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602 fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763 fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023 fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538 fdo#106702 https://bugs.freedesktop.org/show_bug.cgi?id=106702 fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887 fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469 fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956 fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133 == Participating hosts (6 -> 5) == Missing (1): shard-skl == Build changes == * IGT: IGT_4715 -> IGTPW_2064 CI_DRM_5141: fcdadbabc3216aa16c6d8236d55c5e5c8261cc91 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2064: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2064/ IGT_4715: 111593c49d812a4f4ff9ab0ef053a3ab88a6f73f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2064/shards.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila 2018-11-15 16:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-11-15 19:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2018-11-20 11:30 ` Maarten Lankhorst 2018-11-21 9:45 ` Juha-Pekka Heikkila 2018-11-22 16:45 ` Juha-Pekka Heikkila ` (2 subsequent siblings) 5 siblings, 1 reply; 9+ messages in thread From: Maarten Lankhorst @ 2018-11-20 11:30 UTC (permalink / raw) To: Juha-Pekka Heikkila, igt-dev Op 15-11-18 om 16:51 schreef Juha-Pekka Heikkila: > Add test which create fb bigger than plane and clamp fb from all sides. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > tests/kms_plane.c | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 45e0a30..d79c22e 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -41,6 +41,7 @@ typedef struct { > int drm_fd; > igt_display_t display; > igt_pipe_crc_t *pipe_crc; > + uint32_t crop; > } data_t; > > static color_t red = { 1.0f, 0.0f, 0.0f }; > @@ -412,12 +413,22 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, > const color_t *c = &colors[color]; > struct igt_fb old_fb = *fb; > > - igt_create_color_fb(data->drm_fd, width, height, > - format, LOCAL_DRM_FORMAT_MOD_NONE, > + igt_create_color_fb(data->drm_fd, width+data->crop*2, > + height+data->crop*2, format, > + LOCAL_DRM_FORMAT_MOD_NONE, > c->red, c->green, c->blue, fb); > > igt_plane_set_fb(plane, fb); > > + /* > + * if clamping test > + */ > + if (width-data->crop != 0) { if (data->crop) ? > + igt_plane_set_size(plane, width, height); > + igt_fb_set_position(fb, plane, data->crop, data->crop); > + igt_fb_set_size(fb, plane, width, height); > + } > + If you don't fill the color fb outside the visible boundaries with a different color, I don't think you're testing anything.. ~Maarten _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test 2018-11-20 11:30 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst @ 2018-11-21 9:45 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 9+ messages in thread From: Juha-Pekka Heikkila @ 2018-11-21 9:45 UTC (permalink / raw) To: Maarten Lankhorst, igt-dev On 20.11.2018 13:30, Maarten Lankhorst wrote: > Op 15-11-18 om 16:51 schreef Juha-Pekka Heikkila: >> Add test which create fb bigger than plane and clamp fb from all sides. >> >> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> >> --- >> tests/kms_plane.c | 28 ++++++++++++++++++++++++++-- >> 1 file changed, 26 insertions(+), 2 deletions(-) >> >> diff --git a/tests/kms_plane.c b/tests/kms_plane.c >> index 45e0a30..d79c22e 100644 >> --- a/tests/kms_plane.c >> +++ b/tests/kms_plane.c >> @@ -41,6 +41,7 @@ typedef struct { >> int drm_fd; >> igt_display_t display; >> igt_pipe_crc_t *pipe_crc; >> + uint32_t crop; >> } data_t; >> >> static color_t red = { 1.0f, 0.0f, 0.0f }; >> @@ -412,12 +413,22 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, >> const color_t *c = &colors[color]; >> struct igt_fb old_fb = *fb; >> >> - igt_create_color_fb(data->drm_fd, width, height, >> - format, LOCAL_DRM_FORMAT_MOD_NONE, >> + igt_create_color_fb(data->drm_fd, width+data->crop*2, >> + height+data->crop*2, format, >> + LOCAL_DRM_FORMAT_MOD_NONE, >> c->red, c->green, c->blue, fb); >> >> igt_plane_set_fb(plane, fb); >> >> + /* >> + * if clamping test >> + */ >> + if (width-data->crop != 0) { > if (data->crop) ? Oops, I have been sleeping here. >> + igt_plane_set_size(plane, width, height); >> + igt_fb_set_position(fb, plane, data->crop, data->crop); >> + igt_fb_set_size(fb, plane, width, height); >> + } >> + > > If you don't fill the color fb outside the visible boundaries with a different color, I don't think you're testing anything.. > That's a good idea. Originally I just thought if source clamping would ever fail it would produce some garbage. This is how IFT version of this test went but I don't think it ever got any reasonable results anyway. /Juha-Pekka _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila ` (2 preceding siblings ...) 2018-11-20 11:30 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst @ 2018-11-22 16:45 ` Juha-Pekka Heikkila 2018-11-22 18:51 ` Maarten Lankhorst 2018-11-23 11:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add source clamping test (rev2) Patchwork 2018-11-23 12:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 5 siblings, 1 reply; 9+ messages in thread From: Juha-Pekka Heikkila @ 2018-11-22 16:45 UTC (permalink / raw) To: igt-dev Add test which create fb bigger than plane and clamp fb from all sides. v2 (Maarten Lankhorst): Fix typo, create different color border around clamped fb where during test border should stay outside visible area. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- tests/kms_plane.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 45e0a30..b26fda6 100644 --- a/tests/kms_plane.c +++ b/tests/kms_plane.c @@ -41,6 +41,7 @@ typedef struct { int drm_fd; igt_display_t display; igt_pipe_crc_t *pipe_crc; + uint32_t crop; } data_t; static color_t red = { 1.0f, 0.0f, 0.0f }; @@ -412,12 +413,49 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, const color_t *c = &colors[color]; struct igt_fb old_fb = *fb; - igt_create_color_fb(data->drm_fd, width, height, - format, LOCAL_DRM_FORMAT_MOD_NONE, - c->red, c->green, c->blue, fb); + if (data->crop == 0 || format == DRM_FORMAT_XRGB8888) { + igt_create_color_fb(data->drm_fd, width, height, format, + LOCAL_DRM_FORMAT_MOD_NONE, + c->red, c->green, c->blue, fb); + } else { + /* + * paint border in inverted color, then visible area in middle + * with correct color for clamping test + */ + cairo_t *cr; + + igt_create_fb(data->drm_fd, width + data->crop * 2, + height + data->crop * 2, format, + LOCAL_DRM_FORMAT_MOD_NONE, + fb); + + cr = igt_get_cairo_ctx(data->drm_fd, fb); + + igt_paint_color(cr, 0, 0, + width+data->crop * 2, + height+data->crop * 2, + 1.0f - c->red, + 1.0f - c->green, + 1.0f - c->blue); + + igt_paint_color(cr, data->crop, data->crop, + width, height, + c->red, c->green, c->blue); + + igt_put_cairo_ctx(data->drm_fd, fb, cr); + } igt_plane_set_fb(plane, fb); + /* + * if clamping test. DRM_FORMAT_XRGB8888 is used for reference color. + */ + if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) { + igt_plane_set_size(plane, width, height); + igt_fb_set_position(fb, plane, data->crop, data->crop); + igt_fb_set_size(fb, plane, width, height); + } + igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc); @@ -435,6 +473,12 @@ static void test_format_plane(data_t *data, enum pipe pipe, uint64_t width, height; igt_crc_t ref_crc[ARRAY_SIZE(colors)]; + /* + * No clamping test for cursor plane + */ + if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR) + return; + mode = igt_output_get_mode(output); if (plane->type != DRM_PLANE_TYPE_CURSOR) { width = mode->hdisplay; @@ -554,6 +598,13 @@ run_tests_for_pipe_plane(data_t *data, enum pipe pipe) kmstest_pipe_name(pipe)) test_pixel_formats(data, pipe); + igt_subtest_f("pixel-format-pipe-%s-planes-source-clamping", + kmstest_pipe_name(pipe)) { + data->crop = 4; + test_pixel_formats(data, pipe); + } + + data->crop = 0; igt_subtest_f("plane-position-covered-pipe-%s-planes", kmstest_pipe_name(pipe)) test_plane_position(data, pipe, TEST_POSITION_FULLY_COVERED); -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test 2018-11-22 16:45 ` Juha-Pekka Heikkila @ 2018-11-22 18:51 ` Maarten Lankhorst 0 siblings, 0 replies; 9+ messages in thread From: Maarten Lankhorst @ 2018-11-22 18:51 UTC (permalink / raw) To: Juha-Pekka Heikkila, igt-dev Op 22-11-18 om 17:45 schreef Juha-Pekka Heikkila: > Add test which create fb bigger than plane and clamp fb > from all sides. > > v2 (Maarten Lankhorst): Fix typo, create different color > border around clamped fb where during test border should > stay outside visible area. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > tests/kms_plane.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 54 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 45e0a30..b26fda6 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -41,6 +41,7 @@ typedef struct { > int drm_fd; > igt_display_t display; > igt_pipe_crc_t *pipe_crc; > + uint32_t crop; > } data_t; > > static color_t red = { 1.0f, 0.0f, 0.0f }; > @@ -412,12 +413,49 @@ static void test_format_plane_color(data_t *data, enum pipe pipe, > const color_t *c = &colors[color]; > struct igt_fb old_fb = *fb; > > - igt_create_color_fb(data->drm_fd, width, height, > - format, LOCAL_DRM_FORMAT_MOD_NONE, > - c->red, c->green, c->blue, fb); > + if (data->crop == 0 || format == DRM_FORMAT_XRGB8888) { > + igt_create_color_fb(data->drm_fd, width, height, format, > + LOCAL_DRM_FORMAT_MOD_NONE, > + c->red, c->green, c->blue, fb); > + } else { > + /* > + * paint border in inverted color, then visible area in middle > + * with correct color for clamping test > + */ > + cairo_t *cr; > + > + igt_create_fb(data->drm_fd, width + data->crop * 2, > + height + data->crop * 2, format, > + LOCAL_DRM_FORMAT_MOD_NONE, > + fb); > + > + cr = igt_get_cairo_ctx(data->drm_fd, fb); > + > + igt_paint_color(cr, 0, 0, > + width+data->crop * 2, > + height+data->crop * 2, > + 1.0f - c->red, > + 1.0f - c->green, > + 1.0f - c->blue); > + > + igt_paint_color(cr, data->crop, data->crop, > + width, height, > + c->red, c->green, c->blue); > + > + igt_put_cairo_ctx(data->drm_fd, fb, cr); > + } > > igt_plane_set_fb(plane, fb); > > + /* > + * if clamping test. DRM_FORMAT_XRGB8888 is used for reference color. > + */ > + if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) { > + igt_plane_set_size(plane, width, height); > + igt_fb_set_position(fb, plane, data->crop, data->crop); > + igt_fb_set_size(fb, plane, width, height); > + } > + > igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); > igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc); > > @@ -435,6 +473,12 @@ static void test_format_plane(data_t *data, enum pipe pipe, > uint64_t width, height; > igt_crc_t ref_crc[ARRAY_SIZE(colors)]; > > + /* > + * No clamping test for cursor plane > + */ > + if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR) > + return; > + > mode = igt_output_get_mode(output); > if (plane->type != DRM_PLANE_TYPE_CURSOR) { > width = mode->hdisplay; > @@ -554,6 +598,13 @@ run_tests_for_pipe_plane(data_t *data, enum pipe pipe) > kmstest_pipe_name(pipe)) > test_pixel_formats(data, pipe); > > + igt_subtest_f("pixel-format-pipe-%s-planes-source-clamping", > + kmstest_pipe_name(pipe)) { > + data->crop = 4; > + test_pixel_formats(data, pipe); > + } > + > + data->crop = 0; > igt_subtest_f("plane-position-covered-pipe-%s-planes", > kmstest_pipe_name(pipe)) > test_plane_position(data, pipe, TEST_POSITION_FULLY_COVERED); Much better. :) Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add source clamping test (rev2) 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila ` (3 preceding siblings ...) 2018-11-22 16:45 ` Juha-Pekka Heikkila @ 2018-11-23 11:51 ` Patchwork 2018-11-23 12:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 5 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2018-11-23 11:51 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev == Series Details == Series: tests/kms_plane: add source clamping test (rev2) URL : https://patchwork.freedesktop.org/series/52541/ State : success == Summary == = CI Bug Log - changes from IGT_4725 -> IGTPW_2087 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/52541/revisions/2/mbox/ == Known issues == Here are the changes found in IGTPW_2087 that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_close_race@basic-threads: fi-bsw-n3050: PASS -> FAIL (fdo#108656) igt@i915_selftest@live_coherency: fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164) igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence: fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) +1 igt@kms_pipe_crc_basic@read-crc-pipe-b: fi-byt-clapper: PASS -> FAIL (fdo#107362) ==== Possible fixes ==== igt@i915_selftest@live_contexts: fi-kbl-7560u: INCOMPLETE -> PASS igt@kms_frontbuffer_tracking@basic: fi-byt-clapper: FAIL (fdo#103167) -> PASS fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167 fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164 fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362 fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656 == Participating hosts (51 -> 44) == Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3 == Build changes == * IGT: IGT_4725 -> IGTPW_2087 CI_DRM_5185: 08f3cf2314cc0484a5b332e8dc206e778709bf21 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2087: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2087/ IGT_4725: 9dc7c41d1c600133d6e3e63f1941c2e75d23bd3b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@kms_plane@pixel-format-pipe-a-planes-source-clamping +igt@kms_plane@pixel-format-pipe-b-planes-source-clamping +igt@kms_plane@pixel-format-pipe-c-planes-source-clamping +igt@kms_plane@pixel-format-pipe-d-planes-source-clamping +igt@kms_plane@pixel-format-pipe-e-planes-source-clamping +igt@kms_plane@pixel-format-pipe-f-planes-source-clamping == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2087/issues.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: add source clamping test (rev2) 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila ` (4 preceding siblings ...) 2018-11-23 11:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add source clamping test (rev2) Patchwork @ 2018-11-23 12:40 ` Patchwork 5 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2018-11-23 12:40 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev == Series Details == Series: tests/kms_plane: add source clamping test (rev2) URL : https://patchwork.freedesktop.org/series/52541/ State : success == Summary == = CI Bug Log - changes from IGT_4725_full -> IGTPW_2087_full = == Summary - WARNING == Minor unknown changes coming with IGTPW_2087_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_2087_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/52541/revisions/2/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in IGTPW_2087_full: === IGT changes === ==== Warnings ==== igt@perf_pmu@rc6: shard-kbl: SKIP -> PASS igt@pm_rc6_residency@rc6-accuracy: shard-kbl: PASS -> SKIP shard-snb: SKIP -> PASS +1 == Known issues == Here are the changes found in IGTPW_2087_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@kms_ccs@pipe-a-crc-sprite-planes-basic: shard-glk: PASS -> FAIL (fdo#108145) igt@kms_cursor_crc@cursor-256x256-random: shard-glk: PASS -> FAIL (fdo#103232) +2 igt@kms_cursor_crc@cursor-256x256-suspend: shard-apl: PASS -> FAIL (fdo#103232, fdo#103191) igt@kms_cursor_crc@cursor-64x21-onscreen: shard-apl: PASS -> FAIL (fdo#103232) igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: shard-apl: PASS -> FAIL (fdo#103167) +3 igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move: shard-kbl: PASS -> FAIL (fdo#103167) +1 igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-pwrite: shard-glk: PASS -> FAIL (fdo#103167) +7 igt@kms_plane@pixel-format-pipe-a-planes: shard-kbl: PASS -> FAIL (fdo#103166) shard-glk: PASS -> FAIL (fdo#103166) igt@kms_plane_multiple@atomic-pipe-a-tiling-x: shard-apl: PASS -> FAIL (fdo#103166) +1 igt@perf@polling: shard-hsw: PASS -> FAIL (fdo#102252) ==== Possible fixes ==== igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c: shard-snb: INCOMPLETE (fdo#107469, fdo#105411) -> SKIP igt@kms_cursor_crc@cursor-128x128-random: shard-apl: FAIL (fdo#103232) -> PASS +5 shard-kbl: FAIL (fdo#103232) -> PASS +1 igt@kms_cursor_crc@cursor-64x21-sliding: shard-glk: FAIL (fdo#103232) -> PASS igt@kms_cursor_crc@cursor-64x64-suspend: shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: shard-apl: FAIL (fdo#103167) -> PASS +1 shard-kbl: FAIL (fdo#103167) -> PASS igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: shard-glk: FAIL (fdo#103167) -> PASS +6 igt@kms_pipe_crc_basic@read-crc-pipe-a: shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS +1 igt@kms_plane@plane-position-covered-pipe-b-planes: shard-glk: FAIL (fdo#103166) -> PASS +3 igt@kms_plane_multiple@atomic-pipe-c-tiling-yf: shard-apl: FAIL (fdo#103166) -> PASS +4 shard-kbl: FAIL (fdo#103166) -> PASS +2 igt@kms_setmode@basic: shard-kbl: FAIL (fdo#99912) -> PASS fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166 fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167 fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763 fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538 fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469 fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (7 -> 5) == Missing (2): shard-skl shard-iclb == Build changes == * IGT: IGT_4725 -> IGTPW_2087 CI_DRM_5185: 08f3cf2314cc0484a5b332e8dc206e778709bf21 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2087: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2087/ IGT_4725: 9dc7c41d1c600133d6e3e63f1941c2e75d23bd3b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2087/shards.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-23 12:40 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-15 15:51 [igt-dev] [PATCH i-g-t] tests/kms_plane: add source clamping test Juha-Pekka Heikkila 2018-11-15 16:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-11-15 19:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2018-11-20 11:30 ` [igt-dev] [PATCH i-g-t] " Maarten Lankhorst 2018-11-21 9:45 ` Juha-Pekka Heikkila 2018-11-22 16:45 ` Juha-Pekka Heikkila 2018-11-22 18:51 ` Maarten Lankhorst 2018-11-23 11:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: add source clamping test (rev2) Patchwork 2018-11-23 12:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox