Re: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 03.07.2024 13:12, Jakub Kolakowski wrote:
> This commit adds SR-IOV tests to fast-feedback testlist so that

nit: not sure about IGT rules, but usually we don't start commit message
with "This commit", from [1]

"Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to
do frotz”, as if you are giving orders to the codebase to change its
behaviour."


[1] https://docs.kernel.org/process/submitting-patches.html

> they will be executed in BAT runs. Added tests are about basic
> single VF enablement with and without autoprobe.
> 
> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Adam Miszczak <adam.miszczak@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index aa98b37e6..fc312a123 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -65,6 +65,8 @@ igt@kms_prop_blob@basic
>  igt@kms_psr@psr-primary-page-flip
>  igt@kms_psr@psr-cursor-plane-move
>  igt@kms_psr@psr-sprite-plane-onoff
> +igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-1

maybe instead of numvfs-1 we should select numvfs-all variant:

	igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-all

as otherwise this case will be fully duplicated by the test below (where
auto-provisioning of one VF will be exactly the same, just a VF driver
will be probed on that config), while with numvfs-all variant we will
check auto-provisioning for all available VFs

> +igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1
>  igt@xe_compute@compute-square
>  igt@xe_create@create-execqueues-noleak
>  igt@xe_create@create-execqueues-leak