[PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Jakub Kolakowski]

This commit adds SR-IOV tests to fast-feedback testlist so that
they will be executed in BAT runs. Added tests are about basic
single VF enablement with and without autoprobe.

Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Adam Miszczak <adam.miszczak@intel.com>
Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/intel-ci/xe-fast-feedback.testlist | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index aa98b37e6..fc312a123 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -65,6 +65,8 @@ igt@kms_prop_blob@basic
 igt@kms_psr@psr-primary-page-flip
 igt@kms_psr@psr-cursor-plane-move
 igt@kms_psr@psr-sprite-plane-onoff
+igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-1
+igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1
 igt@xe_compute@compute-square
 igt@xe_create@create-execqueues-noleak
 igt@xe_create@create-execqueues-leak
-- 
2.25.1

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

Re: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Kamil Konieczny]

Hi Jakub,
On 2024-07-03 at 11:12:21 +0000, Jakub Kolakowski wrote:
> This commit adds SR-IOV tests to fast-feedback testlist so that

s/fast-feedback/xe-fast-feedback/
here and in subject, with this

Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> they will be executed in BAT runs. Added tests are about basic
> single VF enablement with and without autoprobe.
> 
> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Adam Miszczak <adam.miszczak@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index aa98b37e6..fc312a123 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -65,6 +65,8 @@ igt@kms_prop_blob@basic
>  igt@kms_psr@psr-primary-page-flip
>  igt@kms_psr@psr-cursor-plane-move
>  igt@kms_psr@psr-sprite-plane-onoff
> +igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-1
> +igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1
>  igt@xe_compute@compute-square
>  igt@xe_create@create-execqueues-noleak
>  igt@xe_create@create-execqueues-leak
> -- 
> 2.25.1
> 

Re: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Michal Wajdeczko]

On 03.07.2024 13:12, Jakub Kolakowski wrote:
> This commit adds SR-IOV tests to fast-feedback testlist so that

nit: not sure about IGT rules, but usually we don't start commit message
with "This commit", from [1]

"Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to
do frotz”, as if you are giving orders to the codebase to change its
behaviour."


[1] https://docs.kernel.org/process/submitting-patches.html

> they will be executed in BAT runs. Added tests are about basic
> single VF enablement with and without autoprobe.
> 
> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Adam Miszczak <adam.miszczak@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index aa98b37e6..fc312a123 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -65,6 +65,8 @@ igt@kms_prop_blob@basic
>  igt@kms_psr@psr-primary-page-flip
>  igt@kms_psr@psr-cursor-plane-move
>  igt@kms_psr@psr-sprite-plane-onoff
> +igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-1

maybe instead of numvfs-1 we should select numvfs-all variant:

	igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-all

as otherwise this case will be fully duplicated by the test below (where
auto-provisioning of one VF will be exactly the same, just a VF driver
will be probed on that config), while with numvfs-all variant we will
check auto-provisioning for all available VFs

> +igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1
>  igt@xe_compute@compute-square
>  igt@xe_create@create-execqueues-noleak
>  igt@xe_create@create-execqueues-leak

RE: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Kolakowski, Jakub1]

Hi Michał,

I have just sent patch with corrections applied.

-----Original Message-----
From: Wajdeczko, Michal <Michal.Wajdeczko@intel.com> 
Sent: Thursday, July 4, 2024 4:21 PM
To: Kolakowski, Jakub1 <jakub1.kolakowski@intel.com>; igt-dev@lists.freedesktop.org
Cc: Miszczak, Adam <adam.miszczak@intel.com>; Bernatowicz, Marcin <marcin.bernatowicz@intel.com>; Laguna, Lukasz <lukasz.laguna@intel.com>; Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: Re: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests



> On 03.07.2024 13:12, Jakub Kolakowski wrote:
>> This commit adds SR-IOV tests to fast-feedback testlist so that
>
> nit: not sure about IGT rules, but usually we don't start commit message with "This commit", from [1]
>
> "Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
> instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour."
>
>
> [1] https://docs.kernel.org/process/submitting-patches.html
>
>> they will be executed in BAT runs. Added tests are about basic single 
>> VF enablement with and without autoprobe.
>> 
>> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
>> Cc: Adam Miszczak <adam.miszczak@intel.com>
>> Cc: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
>> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
>> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> ---
>>  tests/intel-ci/xe-fast-feedback.testlist | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/tests/intel-ci/xe-fast-feedback.testlist 
>> b/tests/intel-ci/xe-fast-feedback.testlist
>> index aa98b37e6..fc312a123 100644
>> --- a/tests/intel-ci/xe-fast-feedback.testlist
>> +++ b/tests/intel-ci/xe-fast-feedback.testlist
>> @@ -65,6 +65,8 @@ igt@kms_prop_blob@basic  
>> igt@kms_psr@psr-primary-page-flip  igt@kms_psr@psr-cursor-plane-move  
>> igt@kms_psr@psr-sprite-plane-onoff
>> +igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-1
>
> maybe instead of numvfs-1 we should select numvfs-all variant:
>
>	igt@sriov_basic@enable-vfs-autoprobe-off@numvfs-all
>
> as otherwise this case will be fully duplicated by the test below (where auto-provisioning of one VF will be exactly the same, just a VF driver will be probed on that config), while with numvfs-all variant we will check auto-provisioning for all available VFs
>
>> +igt@sriov_basic@enable-vfs-autoprobe-on@numvfs-1
>>  igt@xe_compute@compute-square
>>  igt@xe_create@create-execqueues-noleak
>>  igt@xe_create@create-execqueues-leak
>