[PATCH i-g-t 0/3] Add dsc+bigjoiner subtest

[PATCH i-g-t 0/3] Add dsc+bigjoiner subtest

[Swati Sharma]

This series uses big joiner debugfs from
https://patchwork.freedesktop.org/series/124730/
New subtest is added to validate dsc + big joiner use case.

Swati Sharma (3):
  lib/igt_kms: add helpers for big joiner debugfs
  tests/intel/kms_dsc: add new subtest
  tests/intel/kms_dsc_helper: add dsc+big joiner helper func

 lib/igt_kms.c                | 75 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h                |  3 ++
 tests/intel/kms_dsc.c        | 16 ++++++++
 tests/intel/kms_dsc_helper.c | 32 +++++++++++++++
 tests/intel/kms_dsc_helper.h |  3 ++
 5 files changed, 129 insertions(+)

-- 
2.25.1

[PATCH i-g-t 1/3] lib/igt_kms: add helpers for big joiner debugfs

[Swati Sharma]

Add helpers for big joiner debugfs.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt_kms.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  3 +++
 2 files changed, 78 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index e4dea1a60..d8ed81e9b 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6368,3 +6368,78 @@ int get_num_scalers(int drm_fd, enum pipe pipe)
 
 	return num_scalers;
 }
+
+static int write_bigjoiner_debugfs(int drmfd, char *connector_name, const char *file_name,
+				   const char *write_buf)
+{
+	int debugfs_fd = igt_debugfs_dir(drmfd);
+	int len = strlen(write_buf);
+	int ret;
+	char file_path[128] = {0};
+
+	sprintf(file_path, "%s/%s", connector_name, file_name);
+
+	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
+
+	close(debugfs_fd);
+
+	if (ret > 0)
+		return 0;
+
+	return ret;
+}
+
+static bool check_bigjoiner_debugfs(int drmfd, char *connector_name,
+				    const char *check_str)
+{
+	char file_name[128] = {0};
+	char buf[512];
+
+	sprintf(file_name, "%s/i915_bigjoiner_force_enable", connector_name);
+
+	igt_debugfs_read(drmfd, file_name, buf);
+
+	return strstr(buf, check_str);
+}
+
+/**
+ * igt_is_force_bigjoiner_enabled:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: True if Big Joiner is force enabled (via debugfs) for the given connector,
+ * false otherwise.
+ */
+bool igt_is_force_bigjoiner_enabled(int drmfd, char *connector_name)
+{
+	return check_bigjoiner_debugfs(drmfd, connector_name, "Bigjoiner enable: 1");
+}
+
+/**
+ * igt_force_bigjoiner_enable:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: 0 on success or negative error code, in case of failure.
+ */
+int igt_force_bigjoiner_enable(int drmfd, char *connector_name)
+{
+	return write_bigjoiner_debugfs(drmfd, connector_name, "i915_bigjoiner_force_enable", "1");
+}
+
+/**
+ * igt_get_bigjoiner_debugfs_fd:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: fd of the Big Joiner debugfs for the given connector,
+ * else returns -1.
+ */
+int igt_get_bigjoiner_debugfs_fd(int drmfd, char *connector_name)
+{
+	char file_name[128] = {0};
+
+	sprintf(file_name, "%s/i915_bigjoiner_force_enable", connector_name);
+
+	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
+}
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index b3882808b..1b973a7fc 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -1218,5 +1218,8 @@ bool intel_pipe_output_combo_valid(igt_display_t *display);
 bool igt_check_output_is_dp_mst(igt_output_t *output);
 int igt_get_dp_mst_connector_id(igt_output_t *output);
 int get_num_scalers(int drm_fd, enum pipe pipe);
+bool igt_is_force_bigjoiner_enabled(int drmfd, char *connector_name);
+int igt_force_bigjoiner_enable(int drmfd, char *connector_name);
+int igt_get_bigjoiner_debugfs_fd(int drmfd, char *connector_name);
 
 #endif /* __IGT_KMS_H__ */
-- 
2.25.1

[PATCH i-g-t 2/3] tests/intel/kms_dsc: add new subtest

[Swati Sharma]

Add new subtest to validate dsc and big joiner usecase.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_dsc.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 3433e0907..a71c69e16 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -50,6 +50,7 @@
  * arg[1]:
  *
  * @basic:                        DSC with default parameters
+ * @with-bigjoiner:               DSC with default parameters and big joiner
  * @with-bpc:                     DSC with certain input BPC for the connector
  * @with-bpc-formats:             DSC with certain input BPC for the connector and diff formats
  * @with-formats:                 DSC with default parameters and creating fb with diff formats
@@ -69,6 +70,7 @@ IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 #define TEST_DSC_FORMAT		(1<<1)
 #define TEST_DSC_OUTPUT_FORMAT	(1<<2)
 #define TEST_DSC_FRACTIONAL_BPP (1<<3)
+#define TEST_DSC_BIGJOINER	(1<<4)
 
 typedef struct {
 	int drm_fd;
@@ -177,6 +179,12 @@ static void update_display(data_t *data, uint32_t test_type)
 		force_dsc_fractional_bpp_enable(data->drm_fd, data->output);
 	}
 
+	if (test_type & TEST_DSC_BIGJOINER) {
+		igt_debug("DSC big joiner is supported on %s\n", data->output->name);
+		save_force_dsc_bigjoiner_en(data->drm_fd, data->output);
+		force_dsc_bigjoiner_enable(data->drm_fd, data->output);
+	}
+
 	igt_output_set_pipe(output, data->pipe);
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 
@@ -237,6 +245,7 @@ static void update_display(data_t *data, uint32_t test_type)
 
 	restore_force_dsc_en();
 	restore_force_dsc_fractional_bpp_en();
+	restore_force_dsc_bigjoiner_en();
 
 	if (test_type & TEST_DSC_BPC) {
 		current_bpc = igt_get_pipe_current_bpc(data->drm_fd, data->pipe);
@@ -349,6 +358,13 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
 			test_dsc(&data, TEST_DSC_BASIC, DEFAULT_BPC,
 				 DRM_FORMAT_XRGB8888, DSC_FORMAT_RGB);
 
+	igt_describe("Tests basic display stream compression functionality with big joiner "
+		     "if supported by a connector by forcing DSC and big joiner on all connectors "
+		     "that support it with default parameters");
+	igt_subtest_with_dynamic("dsc-with-bigjoiner")
+			test_dsc(&data, TEST_DSC_BASIC | TEST_DSC_BIGJOINER, DEFAULT_BPC,
+				 DRM_FORMAT_XRGB8888, DSC_FORMAT_RGB);
+
 	igt_describe("Tests basic display stream compression functionality if supported "
 		     "by a connector by forcing DSC on all connectors that support it "
 		     "with default parameters and creating fb with diff formats");
-- 
2.25.1

[PATCH i-g-t 3/3] tests/intel/kms_dsc_helper: add dsc+big joiner helper func

[Swati Sharma]

Add helper functions dsc with big joiner helper functions.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_dsc_helper.c | 32 ++++++++++++++++++++++++++++++++
 tests/intel/kms_dsc_helper.h |  3 +++
 2 files changed, 35 insertions(+)

diff --git a/tests/intel/kms_dsc_helper.c b/tests/intel/kms_dsc_helper.c
index 58057aca3..91ce21062 100644
--- a/tests/intel/kms_dsc_helper.c
+++ b/tests/intel/kms_dsc_helper.c
@@ -7,8 +7,10 @@
 
 static bool force_dsc_en_orig;
 static bool force_dsc_fractional_bpp_en_orig;
+static bool force_dsc_bigjoiner_en_orig;
 static int force_dsc_restore_fd = -1;
 static int force_dsc_fractional_bpp_restore_fd = -1;
+static int force_dsc_bigjoiner_restore_fd = -1;
 
 void force_dsc_enable(int drmfd, igt_output_t *output)
 {
@@ -201,3 +203,33 @@ bool is_dsc_fractional_bpp_supported(int disp_ver, int drmfd, igt_output_t *outp
 
 	return true;
 }
+
+void force_dsc_bigjoiner_enable(int drmfd, igt_output_t *output)
+{
+	int ret;
+
+	igt_debug("Forcing DSC Big Joiner on %s\n", output->name);
+	ret = igt_force_bigjoiner_enable(drmfd, output->name);
+	igt_assert_f(ret == 0, "forcing dsc big joiner debugfs_write failed\n");
+}
+
+void save_force_dsc_bigjoiner_en(int drmfd, igt_output_t *output)
+{
+	force_dsc_bigjoiner_en_orig =
+		igt_is_force_bigjoiner_enabled(drmfd, output->name);
+	force_dsc_bigjoiner_restore_fd =
+		igt_get_bigjoiner_debugfs_fd(drmfd, output->name);
+	igt_assert(force_dsc_bigjoiner_restore_fd >= 0);
+}
+
+void restore_force_dsc_bigjoiner_en(void)
+{
+	if (force_dsc_bigjoiner_restore_fd < 0)
+		return;
+
+	igt_debug("Restoring DSC Big Joiner enable\n");
+	igt_assert(write(force_dsc_bigjoiner_restore_fd, force_dsc_bigjoiner_en_orig ? "1" : "0", 1) == 1);
+
+	close(force_dsc_bigjoiner_restore_fd);
+	force_dsc_bigjoiner_restore_fd = -1;
+}
diff --git a/tests/intel/kms_dsc_helper.h b/tests/intel/kms_dsc_helper.h
index 4dbd88fe7..b2f8ea1ca 100644
--- a/tests/intel/kms_dsc_helper.h
+++ b/tests/intel/kms_dsc_helper.h
@@ -38,5 +38,8 @@ void force_dsc_fractional_bpp_enable(int drmfd, igt_output_t *output);
 void save_force_dsc_fractional_bpp_en(int drmfd, igt_output_t *output);
 void restore_force_dsc_fractional_bpp_en(void);
 bool is_dsc_fractional_bpp_supported(int disp_ver, int drmfd, igt_output_t *output);
+void force_dsc_bigjoiner_enable(int drmfd, igt_output_t *output);
+void save_force_dsc_bigjoiner_en(int drmfd, igt_output_t *output);
+void restore_force_dsc_bigjoiner_en(void);
 
 #endif
-- 
2.25.1

✗ Fi.CI.BAT: failure for Add dsc+bigjoiner subtest

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4021 bytes --]

== Series Details ==

Series: Add dsc+bigjoiner subtest
URL   : https://patchwork.freedesktop.org/series/128266/
State : failure

== Summary ==

CI Bug Log - changes from IGT_7658 -> IGTPW_10480
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10480 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10480, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/index.html

Participating hosts (37 -> 35)
------------------------------

  Additional (1): fi-bsw-n3050 
  Missing    (3): bat-kbl-2 bat-jsl-1 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10480:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - fi-bsw-n3050:       NOTRUN -> [ABORT][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/fi-bsw-n3050/igt@i915_selftest@live@hangcheck.html

  
Known issues
------------

  Here are the changes found in IGTPW_10480 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@random-engines:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][2] ([fdo#109271]) +15 other tests skip
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-adlp-9:         NOTRUN -> [SKIP][3] ([i915#9826]) +2 other tests skip
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/bat-adlp-9/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [PASS][4] -> [ABORT][5] ([i915#8668] / [i915#9368])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7658/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  * igt@kms_pm_rpm@basic-rte:
    - bat-rpls-2:         [PASS][6] -> [ABORT][7] ([i915#8668] / [i915#9368] / [i915#9897])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7658/bat-rpls-2/igt@kms_pm_rpm@basic-rte.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/bat-rpls-2/igt@kms_pm_rpm@basic-rte.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@guc:
    - bat-jsl-3:          [INCOMPLETE][8] -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7658/bat-jsl-3/igt@i915_selftest@live@guc.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/bat-jsl-3/igt@i915_selftest@live@guc.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#9368]: https://gitlab.freedesktop.org/drm/intel/issues/9368
  [i915#9826]: https://gitlab.freedesktop.org/drm/intel/issues/9826
  [i915#9897]: https://gitlab.freedesktop.org/drm/intel/issues/9897


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7658 -> IGTPW_10480

  CI-20190529: 20190529
  CI_DRM_14080: d7426b5fc261046501ca418fe0e69ad1d6ba59be @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10480: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/index.html
  IGT_7658: 97b342e1e5de7c6bcf7d76edc388392f7a340d62 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@kms_dsc@dsc-with-bigjoiner

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/index.html

[-- Attachment #2: Type: text/html, Size: 4909 bytes --]

Re: [PATCH i-g-t 2/3] tests/intel/kms_dsc: add new subtest

[Kamil Konieczny]

Hi Swati,
On 2024-01-05 at 21:29:50 +0530, Swati Sharma wrote:
> Add new subtest to validate dsc and big joiner usecase.
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/intel/kms_dsc.c | 16 ++++++++++++++++

This should be last patch in series.

Regards,
Kamil

>  1 file changed, 16 insertions(+)
> 
> diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
> index 3433e0907..a71c69e16 100644
> --- a/tests/intel/kms_dsc.c
> +++ b/tests/intel/kms_dsc.c
> @@ -50,6 +50,7 @@
>   * arg[1]:
>   *
>   * @basic:                        DSC with default parameters
> + * @with-bigjoiner:               DSC with default parameters and big joiner
>   * @with-bpc:                     DSC with certain input BPC for the connector
>   * @with-bpc-formats:             DSC with certain input BPC for the connector and diff formats
>   * @with-formats:                 DSC with default parameters and creating fb with diff formats
> @@ -69,6 +70,7 @@ IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>  #define TEST_DSC_FORMAT		(1<<1)
>  #define TEST_DSC_OUTPUT_FORMAT	(1<<2)
>  #define TEST_DSC_FRACTIONAL_BPP (1<<3)
> +#define TEST_DSC_BIGJOINER	(1<<4)
>  
>  typedef struct {
>  	int drm_fd;
> @@ -177,6 +179,12 @@ static void update_display(data_t *data, uint32_t test_type)
>  		force_dsc_fractional_bpp_enable(data->drm_fd, data->output);
>  	}
>  
> +	if (test_type & TEST_DSC_BIGJOINER) {
> +		igt_debug("DSC big joiner is supported on %s\n", data->output->name);
> +		save_force_dsc_bigjoiner_en(data->drm_fd, data->output);
> +		force_dsc_bigjoiner_enable(data->drm_fd, data->output);
> +	}
> +
>  	igt_output_set_pipe(output, data->pipe);
>  	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>  
> @@ -237,6 +245,7 @@ static void update_display(data_t *data, uint32_t test_type)
>  
>  	restore_force_dsc_en();
>  	restore_force_dsc_fractional_bpp_en();
> +	restore_force_dsc_bigjoiner_en();
>  
>  	if (test_type & TEST_DSC_BPC) {
>  		current_bpc = igt_get_pipe_current_bpc(data->drm_fd, data->pipe);
> @@ -349,6 +358,13 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
>  			test_dsc(&data, TEST_DSC_BASIC, DEFAULT_BPC,
>  				 DRM_FORMAT_XRGB8888, DSC_FORMAT_RGB);
>  
> +	igt_describe("Tests basic display stream compression functionality with big joiner "
> +		     "if supported by a connector by forcing DSC and big joiner on all connectors "
> +		     "that support it with default parameters");
> +	igt_subtest_with_dynamic("dsc-with-bigjoiner")
> +			test_dsc(&data, TEST_DSC_BASIC | TEST_DSC_BIGJOINER, DEFAULT_BPC,
> +				 DRM_FORMAT_XRGB8888, DSC_FORMAT_RGB);
> +
>  	igt_describe("Tests basic display stream compression functionality if supported "
>  		     "by a connector by forcing DSC on all connectors that support it "
>  		     "with default parameters and creating fb with diff formats");
> -- 
> 2.25.1
> 

✓ CI.xeBAT: success for Add dsc+bigjoiner subtest

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2111 bytes --]

== Series Details ==

Series: Add dsc+bigjoiner subtest
URL   : https://patchwork.freedesktop.org/series/128266/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7658_BAT -> XEIGTPW_10480_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_10480_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@xe_prime_self_import@basic-with_fd_dup:
    - bat-atsm-2:         [FAIL][1] ([Intel XE#999]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7658/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10480/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@basic:
    - bat-adlp-7:         [DMESG-FAIL][3] ([Intel XE#1033]) -> [DMESG-WARN][4] ([Intel XE#1033])
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7658/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10480/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html

  
  [Intel XE#1033]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1033
  [Intel XE#999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/999


Build changes
-------------

  * IGT: IGT_7658 -> IGTPW_10480
  * Linux: xe-601-1525770606970ebaeb0ae7d9907991f899f153f3 -> xe-602-2f34bf674c7dad8d0cb6ae92d4e56805d63d0513

  IGTPW_10480: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10480/index.html
  IGT_7658: 97b342e1e5de7c6bcf7d76edc388392f7a340d62 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-601-1525770606970ebaeb0ae7d9907991f899f153f3: 1525770606970ebaeb0ae7d9907991f899f153f3
  xe-602-2f34bf674c7dad8d0cb6ae92d4e56805d63d0513: 2f34bf674c7dad8d0cb6ae92d4e56805d63d0513

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10480/index.html

[-- Attachment #2: Type: text/html, Size: 2779 bytes --]

Re: [i-g-t, 3/3] tests/intel/kms_dsc_helper: add dsc+big joiner helper func

[Joshi, Kunal1]

[-- Attachment #1: Type: text/plain, Size: 2238 bytes --]


On 1/5/2024 9:29 PM, Swati Sharma wrote:
> Add helper functions dsc with big joiner helper functions.
>
> Signed-off-by: Swati Sharma<swati2.sharma@intel.com>
> ---
>   tests/intel/kms_dsc_helper.c | 32 ++++++++++++++++++++++++++++++++
>   tests/intel/kms_dsc_helper.h |  3 +++
>   2 files changed, 35 insertions(+)
>
> diff --git a/tests/intel/kms_dsc_helper.c b/tests/intel/kms_dsc_helper.c
> index 58057aca3..91ce21062 100644
> --- a/tests/intel/kms_dsc_helper.c
> +++ b/tests/intel/kms_dsc_helper.c
> @@ -7,8 +7,10 @@
>   
>   static bool force_dsc_en_orig;
>   static bool force_dsc_fractional_bpp_en_orig;
> +static bool force_dsc_bigjoiner_en_orig;
>   static int force_dsc_restore_fd = -1;
>   static int force_dsc_fractional_bpp_restore_fd = -1;
> +static int force_dsc_bigjoiner_restore_fd = -1;
>   
>   void force_dsc_enable(int drmfd, igt_output_t *output)
>   {
> @@ -201,3 +203,33 @@ bool is_dsc_fractional_bpp_supported(int disp_ver, int drmfd, igt_output_t *outp
>   
>   	return true;
>   }
> +
> +void force_dsc_bigjoiner_enable(int drmfd, igt_output_t *output)
> +{
> +	int ret;
> +
> +	igt_debug("Forcing DSC Big Joiner on %s\n", output->name);
> +	ret = igt_force_bigjoiner_enable(drmfd, output->name);
> +	igt_assert_f(ret == 0, "forcing dsc big joiner debugfs_write failed\n");
> +}
> +
> +void save_force_dsc_bigjoiner_en(int drmfd, igt_output_t *output)
> +{
> +	force_dsc_bigjoiner_en_orig =
> +		igt_is_force_bigjoiner_enabled(drmfd, output->name);
> +	force_dsc_bigjoiner_restore_fd =
> +		igt_get_bigjoiner_debugfs_fd(drmfd, output->name);
> +	igt_assert(force_dsc_bigjoiner_restore_fd >= 0);
> +}
> +
> +void restore_force_dsc_bigjoiner_en(void)
> +{
> +	if (force_dsc_bigjoiner_restore_fd < 0)
> +		return;
> +
> +	igt_debug("Restoring DSC Big Joiner enable\n");
> +	igt_assert(write(force_dsc_bigjoiner_restore_fd, force_dsc_bigjoiner_en_orig ? "1" : "0", 1) == 1);
> +
> +	close(force_dsc_bigjoiner_restore_fd);
> +	force_dsc_bigjoiner_restore_fd = -1;
> +}


Hello Swati,

These functions (force_dsc_enable, save_force_dsc_bigjoiner_en and restore_force_dsc_bigjoiner_en) seems to be generic and not dsc specific.
Can this be somewhere where other IGT"s can use them?


Thanks and Regards
Kunal Joshi


[-- Attachment #2: Type: text/html, Size: 2755 bytes --]