Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_feature_discovery: add HDR, VRR and DSC discovery
Date: Thu, 9 Jul 2026 01:05:45 +0530	[thread overview]
Message-ID: <09e5795b-6974-4f33-a69f-5f1789c1d1f8@intel.com> (raw)
In-Reply-To: <192d86f5-509e-4113-bc00-77a33084bf3b@intel.com>

Hi Santosh

On 15-06-2026 09:05 am, Reddy Guddati, Santhosh wrote:
> Hi Swati,
>
> On 14-06-2026 01:29, Swati Sharma wrote:
>> Add display feature discovery subtests for HDR, VRR and DSC.
>>
>> HDR requires:
>> - IGT_CONNECTOR_MAX_BPC with max bpc >= 10
>> - IGT_CONNECTOR_HDR_OUTPUT_METADATA
>> - EDID HDR capability via igt_is_panel_hdr()
>>
>> VRR checks connector vrr_capable support.
>> DSC checks sink support via igt_is_dsc_supported_by_sink().
>
> Would it be good to consider the feature discovery check for HDCP as 
> well in this patch.

Yes, but prior to that we need lib for HDCP.

>
> Regards,
> Santhosh>
>> Assisted-by: GitHub Copilot:Claude Opus 4.6
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/kms_feature_discovery.c | 75 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 75 insertions(+)
>>
>> diff --git a/tests/kms_feature_discovery.c 
>> b/tests/kms_feature_discovery.c
>> index 28ec89c55..07a0c5e16 100644
>> --- a/tests/kms_feature_discovery.c
>> +++ b/tests/kms_feature_discovery.c
>> @@ -36,6 +36,7 @@
>>   #ifdef HAVE_CHAMELIUM
>>   #include "igt_chamelium.h"
>>   #endif
>> +#include "igt_hdr.h"
>>   #include "igt_kms.h"
>>   #include "igt_psr.h"
>>   #include "igt_sysfs.h"
>> @@ -63,6 +64,18 @@
>>    * SUBTEST: dp-mst
>>    * Description: Make sure that we have DP-MST configuration.
>>    *
>> + * SUBTEST: hdr
>> + * Description: Make sure that we have at least one HDR-capable panel.
>> + * Mega feature: HDR
>> + *
>> + * SUBTEST: vrr
>> + * Description: Make sure that we have at least one VRR-capable panel.
>> + * Mega feature: VRR
>> + *
>> + * SUBTEST: dsc
>> + * Description: Make sure that we have at least one DSC-capable sink.
>> + * Mega feature: DSC
>> + *
>>    * arg[1].values: 1, 2, 3, 4
>>    */
>>   @@ -174,5 +187,67 @@ int igt_main() {
>>               }
>>               igt_require_f(ret == 0, "No DP-MST configuration 
>> found.\n");
>>           }
>> +
>> +        igt_describe("Make sure that we have at least one 
>> HDR-capable panel.");
>> +        igt_subtest("hdr") {
>> +            igt_output_t *output;
>> +            bool found = false;
>> +
>> +            for_each_connected_output(&display, output) {
>> +                if (!igt_output_has_prop(output, 
>> IGT_CONNECTOR_MAX_BPC))
>> +                    continue;
>> +
>> +                if (igt_get_output_max_bpc(output) < 10)
>> +                    continue;
>> +
>> +                if (!igt_output_has_prop(output,
>> + IGT_CONNECTOR_HDR_OUTPUT_METADATA))
>> +                    continue;
>> +
>> +                if (!igt_is_panel_hdr(fd, output))
>> +                    continue;
>> +
>> +                found = true;
>> +                break;
>> +            }
>> +
>> +            igt_require_f(found,
>> +                      "No HDR-capable panel found with max bpc, HDR 
>> metadata, and EDID HDR support.\n");
>> +        }
>> +
>> +        igt_describe("Make sure that we have at least one 
>> VRR-capable panel.");
>> +        igt_subtest("vrr") {
>> +            igt_output_t *output;
>> +            bool found = false;
>> +
>> +            for_each_connected_output(&display, output) {
>> +                if (!igt_output_has_prop(output, 
>> IGT_CONNECTOR_VRR_CAPABLE))
>> +                    continue;
>> +
>> +                if (!igt_output_get_prop(output, 
>> IGT_CONNECTOR_VRR_CAPABLE))
>> +                    continue;
>> +
>> +                found = true;
>> +                break;
>> +            }
>> +
>> +            igt_require_f(found, "No VRR-capable panel found.\n");
>> +        }
>> +
>> +        igt_describe("Make sure that we have at least one 
>> DSC-capable sink.");
>> +        igt_subtest("dsc") {
>> +            igt_output_t *output;
>> +            bool found = false;
>> +
>> +            for_each_connected_output(&display, output) {
>> +                if (!igt_is_dsc_supported_by_sink(fd, output->name))
>> +                    continue;
>> +
>> +                found = true;
>> +                break;
>> +            }
>> +
>> +            igt_require_f(found, "No DSC-capable sink found.\n");
>> +        }
>>       }
>>   }
>

  reply	other threads:[~2026-07-08 19:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 19:59 [PATCH i-g-t] tests/kms_feature_discovery: add HDR, VRR and DSC discovery Swati Sharma
2026-06-13 20:40 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-06-13 20:55 ` ✗ i915.CI.BAT: failure " Patchwork
2026-06-13 21:47 ` ✗ Xe.CI.FULL: " Patchwork
2026-06-15  3:35 ` [PATCH i-g-t] " Reddy Guddati, Santhosh
2026-07-08 19:35   ` Sharma, Swati2 [this message]
2026-06-15 10:06 ` Kamil Konieczny
2026-07-09  6:24   ` Sharma, Swati2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09e5795b-6974-4f33-a69f-5f1789c1d1f8@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=santhosh.reddy.guddati@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox