Re: [PATCH i-g-t] tests/kms_feature_discovery: add HDR, VRR and DSC discovery

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Kamil

On 15-06-2026 03:36 pm, Kamil Konieczny wrote:
> Hi Swati,
> On 2026-06-14 at 01:29:01 +0530, Swati Sharma wrote:
>> Add display feature discovery subtests for HDR, VRR and DSC.
>>
>> HDR requires:
>> - IGT_CONNECTOR_MAX_BPC with max bpc >= 10
>> - IGT_CONNECTOR_HDR_OUTPUT_METADATA
>> - EDID HDR capability via igt_is_panel_hdr()
>>
>> VRR checks connector vrr_capable support.
>> DSC checks sink support via igt_is_dsc_supported_by_sink().
>>
>> Assisted-by: GitHub Copilot:Claude Opus 4.6
>> Signed-off-by: Swati Sharma<swati2.sharma@intel.com>
>> ---
>>   tests/kms_feature_discovery.c | 75 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 75 insertions(+)
>>
>> diff --git a/tests/kms_feature_discovery.c b/tests/kms_feature_discovery.c
>> index 28ec89c55..07a0c5e16 100644
>> --- a/tests/kms_feature_discovery.c
>> +++ b/tests/kms_feature_discovery.c
>> @@ -36,6 +36,7 @@
>>   #ifdef HAVE_CHAMELIUM
>>   #include "igt_chamelium.h"
>>   #endif
>> +#include "igt_hdr.h"
>>   #include "igt_kms.h"
>>   #include "igt_psr.h"
>>   #include "igt_sysfs.h"
>> @@ -63,6 +64,18 @@
>>    * SUBTEST: dp-mst
>>    * Description: Make sure that we have DP-MST configuration.
>>    *
>> + * SUBTEST: hdr
>> + * Description: Make sure that we have at least one HDR-capable panel.
>> + * Mega feature: HDR
>> + *
>> + * SUBTEST: vrr
>> + * Description: Make sure that we have at least one VRR-capable panel.
>> + * Mega feature: VRR
>> + *
>> + * SUBTEST: dsc
>> + * Description: Make sure that we have at least one DSC-capable sink.
>> + * Mega feature: DSC
> What about adding panel- and sink- prefixes to tests names?
> For example:
>
>   * SUBTEST: panel-hdr
>   * SUBTEST: panel-vrr
>   * SUBTEST: sink-dsc
>
> Up to you, maybe in separate patch?
I guess panel- / sink- not required. Other tests are like psr/psr2, etc.
>> + *
>>    * arg[1].values: 1, 2, 3, 4
>>    */
>>   
>> @@ -174,5 +187,67 @@ int igt_main() {
>>   			}
>>   			igt_require_f(ret == 0, "No DP-MST configuration found.\n");
>>   		}
>> +
>> +		igt_describe("Make sure that we have at least one HDR-capable panel.");
>> +		igt_subtest("hdr") {
>> +			igt_output_t *output;
>> +			bool found = false;
> Could you add a counter for how many outputs were checked?
> Maybe in a separate patch, not this one.
>
> Something like:
>
> 			int ocnt = 0;
>
>> +
>> +			for_each_connected_output(&display, output) {
> 				++ocnt;
>
>> +				if (!igt_output_has_prop(output, IGT_CONNECTOR_MAX_BPC))
>> +					continue;
>> +
>> +				if (igt_get_output_max_bpc(output) < 10)
>> +					continue;
>> +
>> +				if (!igt_output_has_prop(output,
>> +							 IGT_CONNECTOR_HDR_OUTPUT_METADATA))
>> +					continue;
>> +
>> +				if (!igt_is_panel_hdr(fd, output))
>> +					continue;
>> +
>> +				found = true;
>> +				break;
>> +			}
>> +
>> +			igt_require_f(found,
>> +				      "No HDR-capable panel found with max bpc, HDR metadata, and EDID HDR support.\n");
> And here print ocnt, like:
> 				      "No HDR-capable panel found with max bpc, HDR metadata, and EDID HDR support, checked %d outputs.\n", ocnt);
Sure, will do in next rev
>
>> +		}
>> +
>> +		igt_describe("Make sure that we have at least one VRR-capable panel.");
>> +		igt_subtest("vrr") {
>> +			igt_output_t *output;
>> +			bool found = false;
>> +
>> +			for_each_connected_output(&display, output) {
>> +				if (!igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE))
>> +					continue;
>> +
>> +				if (!igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE))
>> +					continue;
>> +
>> +				found = true;
>> +				break;
>> +			}
>> +
>> +			igt_require_f(found, "No VRR-capable panel found.\n");
> Same here.
>
>> +		}
>> +
>> +		igt_describe("Make sure that we have at least one DSC-capable sink.");
>> +		igt_subtest("dsc") {
>> +			igt_output_t *output;
>> +			bool found = false;
>> +
>> +			for_each_connected_output(&display, output) {
>> +				if (!igt_is_dsc_supported_by_sink(fd, output->name))
>> +					continue;
>> +
>> +				found = true;
>> +				break;
>> +			}
>> +
>> +			igt_require_f(found, "No DSC-capable sink found.\n");
> Same here.
>
> Regards,
> Kamil
>
>> +		}
>>   	}
>>   }
>> -- 
>> 2.25.1
>>