Re: [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 08/11/2018 11:25, Lionel Landwerlin wrote:
> Make availability of all elements more visible for debug purposes.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>   tests/i915/query.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/query.c b/tests/i915/query.c
> index 08aabf94..3e7fd140 100644
> --- a/tests/i915/query.c
> +++ b/tests/i915/query.c
> @@ -373,12 +373,20 @@ test_query_topology_matches_eu_total(int fd)
>   	for (s = 0; s < topo_info->max_slices; s++) {
>   		int ss;
>   
> -		igt_debug("slice%i:\n", s);
> +		igt_debug("slice%i: (%s)\n", s,
> +			  slice_available(topo_info, s) ? "available" : "fused");
> +
> +		if (!slice_available(topo_info, s))
> +			continue;
>   
>   		for (ss = 0; ss < topo_info->max_subslices; ss++) {
>   			int eu, n_subslice_eus = 0;
>   
> -			igt_debug("\tsubslice: %i\n", ss);
> +			igt_debug("\tsubslice%i: (%s)\n", ss,
> +				  subslice_available(topo_info, s, ss) ? "available" : "fused");
> +
> +			if (!subslice_available(topo_info, s, ss))
> +				continue;
>   
>   			igt_debug("\t\teu_mask: 0b");
>   			for (eu = 0; eu < topo_info->max_eus_per_subslice; eu++) {
> 

Looks like a no-brainer now.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev