From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
igt-dev@lists.freedesktop.org
Cc: tvrtko.ursulin@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout
Date: Thu, 8 Nov 2018 20:59:14 +0000 [thread overview]
Message-ID: <230b467e-a60c-a4b2-6265-c22629a32e4d@intel.com> (raw)
In-Reply-To: <0b36d59b-3841-9a39-46bd-16aaeb4dd595@linux.intel.com>
On 08/11/2018 15:37, Tvrtko Ursulin wrote:
>
> On 08/11/2018 11:25, Lionel Landwerlin wrote:
>> Make availability of all elements more visible for debug purposes.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> ---
>> tests/i915/query.c | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/i915/query.c b/tests/i915/query.c
>> index 08aabf94..3e7fd140 100644
>> --- a/tests/i915/query.c
>> +++ b/tests/i915/query.c
>> @@ -373,12 +373,20 @@ test_query_topology_matches_eu_total(int fd)
>> for (s = 0; s < topo_info->max_slices; s++) {
>> int ss;
>> - igt_debug("slice%i:\n", s);
>> + igt_debug("slice%i: (%s)\n", s,
>> + slice_available(topo_info, s) ? "available" : "fused");
>> +
>> + if (!slice_available(topo_info, s))
>> + continue;
>> for (ss = 0; ss < topo_info->max_subslices; ss++) {
>> int eu, n_subslice_eus = 0;
>> - igt_debug("\tsubslice: %i\n", ss);
>> + igt_debug("\tsubslice%i: (%s)\n", ss,
>> + subslice_available(topo_info, s, ss) ? "available"
>> : "fused");
>> +
>> + if (!subslice_available(topo_info, s, ss))
>> + continue;
>> igt_debug("\t\teu_mask: 0b");
>> for (eu = 0; eu < topo_info->max_eus_per_subslice; eu++) {
>>
>
> Looks like a no-brainer now.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Regards,
>
> Tvrtko
>
Thanks, pushed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-08 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 11:25 [igt-dev] [PATCH i-g-t] tests/i915/query: more accurate available/fused topology printout Lionel Landwerlin
2018-11-08 12:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-11-08 13:00 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-11-08 15:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2018-11-08 20:59 ` Lionel Landwerlin [this message]
2018-11-08 20:22 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230b467e-a60c-a4b2-6265-c22629a32e4d@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox