Re: [PATCH i-g-t 2/4] tests/intel/kms_joiner_helper: iterate CRTCs instead of pipes

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 02 Sep 2026, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Hi Jani,
> On 2026-09-01 at 11:46:38 +0300, Jani Nikula wrote:
>> Reduce the direct pipe usage.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  tests/intel/kms_joiner_helper.c | 11 ++++++-----
>>  1 file changed, 6 insertions(+), 5 deletions(-)
>> 
>> diff --git a/tests/intel/kms_joiner_helper.c b/tests/intel/kms_joiner_helper.c
>> index da0ac7f624f3..5bacf6cb9e27 100644
>> --- a/tests/intel/kms_joiner_helper.c
>> +++ b/tests/intel/kms_joiner_helper.c
>> @@ -101,13 +101,14 @@ static enum pipe get_next_master_pipe(uint32_t pipe_mask)
>>   */
>>  void igt_set_all_master_pipes_for_platform(igt_display_t *display, uint32_t *master_pipes)
>>  {
>> -	enum pipe pipe;
>> +	igt_crtc_t *crtc;
>>  
>>  	*master_pipes = 0;
>> -	for (pipe = PIPE_A; pipe < IGT_MAX_PIPES - 1; pipe++) {
>> -		if (igt_crtc_for_pipe(display, pipe) && igt_crtc_for_pipe(display, pipe + 1)) {
>> -			*master_pipes |= BIT(pipe);
>> -			igt_info("Found master pipe %s\n", kmstest_pipe_name(pipe));
>> +
>> +	for_each_crtc(display, crtc) {
>> +		if (igt_crtc_for_pipe(display, crtc->pipe + 1)) {
>
> I am not sure here as this is not 1:1, original code has two
> conditions. +cc Swati and Karthik.

The original had igt_crtc_for_pipe(display, pipe) to ensure there's a
valid CRTC for that pipe, but for_each_crtc() iterates valid CRTCs
only. Only need to check pipe + 1.

BR,
Jani.

>
>
> Regards,
> Kamil
>
>> +			*master_pipes |= BIT(crtc->pipe);
>> +			igt_info("Found master pipe %s\n", igt_crtc_name(crtc));
>>  		}
>>  	}
>>  }
>> -- 
>> 2.47.3
>> 

-- 
Jani Nikula, Intel