Re: [PATCH i-g-t 3/7] tests/intel/kms_big_joiner: add missing commit after reset

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

On 4/19/2024 3:23 PM, Modem, Bhanuprakash wrote:
>
> On 19-04-2024 12:09 pm, Kunal Joshi wrote:
>> add missing commit after reset
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>> ---
>>   tests/intel/kms_big_joiner.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
>> index 88923be6b..f325a9839 100644
>> --- a/tests/intel/kms_big_joiner.c
>> +++ b/tests/intel/kms_big_joiner.c
>> @@ -267,6 +267,7 @@ static void test_joiner_on_last_pipe(data_t 
>> *data, bool force_joiner)
>>         for (i = 0; i < len; i++) {
>>           igt_display_reset(&data->display);
>> +        igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> Do we really need this commit?

Hello Bhanu,

Yes we need this commit as below reason
if output is already assigned to pipe D, then forcing big joiner is not 
having any affect.


Thanks and Regards
Kunal Joshi

>
>>           output = outputs[i];
>>           igt_output_set_pipe(output, data->pipe_seq[data->n_pipes - 
>> 1]);
>>           mode = igt_output_get_mode(output);