Re: [PATCH i-g-t 1/7] lib/igt_kms: don't run on unsupported platform

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On 19-04-2024 12:09 pm, Kunal Joshi wrote:
> kmd exposes debugfs for all the platforms, so add

This is not correct, KMD exposes the debugfs if display ver >= 11 and 
the connector type is eDP or DP [*].

[*]: 
https://cgit.freedesktop.org/drm/drm-tip/tree/drivers/gpu/drm/i915/display/intel_display_debugfs.c#n1542 


> a check in igt
> 
> v2: dsc is required for gen12, so test only
> for devid 13 and 13+ (Ankit)
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Suggested-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>   lib/igt_kms.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 3216fe7e4..378c97f88 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6246,6 +6246,14 @@ bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
>   	char buf[512];
>   	int debugfs_fd, ret;
>   
> +	/*
> +	 * bigjoiner is supported on display>= 12 with and only on
-----------^
Nit: Use capital letter

Incomplete sentence: With what?

s/and/or/

- Bhanu

> +	 * Pipe A for Display 11
> +	 * For simplicity avoid Display 11 and 12, check for >= 13
> +	 */
> +	if (intel_display_ver(intel_get_drm_devid(drmfd)) < 13)
> +		return false;
> +
>   	igt_assert_f(output->name, "Connector name cannot be NULL\n");
>   	debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
>   	if (debugfs_fd < 0)