From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Kunal Joshi <kunal1.joshi@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Bhanuprakash Modem" <bhanuprakash.modem@intel.com>
Subject: Re: [PATCH i-g-t 1/7] lib/igt_kms: don't run on unsupported platform
Date: Fri, 19 Apr 2024 11:57:26 +0530 [thread overview]
Message-ID: <ed84d4c0-e4fe-421e-90a8-d3f98935dd08@intel.com> (raw)
In-Reply-To: <20240418152817.2352850-2-kunal1.joshi@intel.com>
On 4/18/2024 8:58 PM, Kunal Joshi wrote:
> kmd exposes debugfs for all the platforms, so add
> a check in igt
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Suggested-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> lib/igt_kms.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 3216fe7e4..6f093fed7 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6246,6 +6246,14 @@ bool igt_has_force_joiner_debugfs(int drmfd, igt_output_t *output)
> char buf[512];
> int debugfs_fd, ret;
>
> + /*
> + * bigjoiner is supported on display>= 12 and only on
> + * Pipe A for Display 11
> + * For simplicity avoid Display 11 and check for >= 12
For display 12 joiner needs DSC also. Due to this we cannot force
bigjoiner on machines that are not connected to DSC sinks.
So perhaps I guess it would be better to test for 13 and above, as we
will not require DSC for that.
Regards,
Ankit
> + */
> + if (intel_display_ver(intel_get_drm_devid(drmfd)) < 12)
> + return false;
> +
> igt_assert_f(output->name, "Connector name cannot be NULL\n");
> debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
> if (debugfs_fd < 0)
next prev parent reply other threads:[~2024-04-19 6:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 15:28 [PATCH i-g-t 0/7] cleanup and fixes for kms_big_joiner Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 1/7] lib/igt_kms: don't run on unsupported platform Kunal Joshi
2024-04-19 6:27 ` Nautiyal, Ankit K [this message]
2024-04-18 15:28 ` [PATCH i-g-t 2/7] tests/intel/kms_big_joiner: fix crash in multi joiner test Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 3/7] tests/intel/kms_big_joiner: add missing commit after reset Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 4/7] lib/igt_kms: add support for forcing bigjoiner on particular connector Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 5/7] tests/intel/kms_big_joiner: use kmstest_force_connector_bigjoiner Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 6/7] lib/igt_kms: remove unused igt_force_and_check_bigjoiner_status Kunal Joshi
2024-04-18 15:28 ` [PATCH i-g-t 7/7] HAX: Do not merge Kunal Joshi
2024-04-19 0:35 ` ✗ Fi.CI.BAT: failure for cleanup and fixes for kms_big_joiner (rev2) Patchwork
2024-04-19 0:41 ` ✓ CI.xeBAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-04-19 6:39 [PATCH i-g-t 0/7] cleanup and fixes for kms_big_joiner Kunal Joshi
2024-04-19 6:39 ` [PATCH i-g-t 1/7] lib/igt_kms: don't run on unsupported platform Kunal Joshi
2024-04-19 9:32 ` Modem, Bhanuprakash
2024-04-19 11:31 ` Joshi, Kunal1
2024-04-22 5:34 [PATCH i-g-t 0/7] cleanup and fixes for kms_big_joiner Kunal Joshi
2024-04-22 5:34 ` [PATCH i-g-t 1/7] lib/igt_kms: don't run on unsupported platform Kunal Joshi
2024-04-22 10:40 ` Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed84d4c0-e4fe-421e-90a8-d3f98935dd08@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox