[igt-dev] [PATCH i-g-t] intel_reg: Use static iterator

[igt-dev] [PATCH i-g-t] intel_reg: Use static iterator

[Petri Latvala]

Convert open-coded for loops to __for_each_static_engine. That takes
care of the last direct user of intel_execution_engines2.

More work is needed to make intel_reg support dynamically queried
engines but this restores the old functionality.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tools/intel_reg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/intel_reg.c b/tools/intel_reg.c
index 847fdbed..5f1beba4 100644
--- a/tools/intel_reg.c
+++ b/tools/intel_reg.c
@@ -252,7 +252,7 @@ static const struct intel_execution_engine2 *find_engine(const char *name)
 	if (name[0] == '-')
 		name++;
 
-	for (e = intel_execution_engines2; e->name; e++) {
+	__for_each_static_engine(e) {
 		if (!strcasecmp(e->name, name))
 			return e;
 	}
@@ -783,7 +783,7 @@ static int intel_reg_help(struct config *config, int argc, char *argv[])
 	printf("\n\n");
 
 	printf("ENGINE is one of:\n");
-	for (e = intel_execution_engines2; e->name; e++)
+	__for_each_static_engine(e)
 		printf("%s -%s ", e->name, e->name);
 	printf("\n\n");
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] intel_reg: Use static iterator

[Tvrtko Ursulin]

On 23/01/2020 13:48, Petri Latvala wrote:
> Convert open-coded for loops to __for_each_static_engine. That takes
> care of the last direct user of intel_execution_engines2.
> 
> More work is needed to make intel_reg support dynamically queried
> engines but this restores the old functionality.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   tools/intel_reg.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/intel_reg.c b/tools/intel_reg.c
> index 847fdbed..5f1beba4 100644
> --- a/tools/intel_reg.c
> +++ b/tools/intel_reg.c
> @@ -252,7 +252,7 @@ static const struct intel_execution_engine2 *find_engine(const char *name)
>   	if (name[0] == '-')
>   		name++;
>   
> -	for (e = intel_execution_engines2; e->name; e++) {
> +	__for_each_static_engine(e) {
>   		if (!strcasecmp(e->name, name))
>   			return e;
>   	}
> @@ -783,7 +783,7 @@ static int intel_reg_help(struct config *config, int argc, char *argv[])
>   	printf("\n\n");
>   
>   	printf("ENGINE is one of:\n");
> -	for (e = intel_execution_engines2; e->name; e++)
> +	__for_each_static_engine(e)
>   		printf("%s -%s ", e->name, e->name);
>   	printf("\n\n");
>   
> 

My bad for not grepping outside lib and tests with the previous patch. 
Thanks for jumping in!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for intel_reg: Use static iterator

[Patchwork]

== Series Details ==

Series: intel_reg: Use static iterator
URL   : https://patchwork.freedesktop.org/series/72470/
State : failure

== Summary ==

Series 72470 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev