public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ser, Simon" <simon.ser@intel.com>
To: "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH v2 i-g-t 2/5] tests/kms_hdmi_inject: Provide igt_descriptions
Date: Wed, 19 Jun 2019 06:44:03 +0000	[thread overview]
Message-ID: <0e4030ab65a2b2b4cda230bbef33a599c6dcffaf.camel@intel.com> (raw)
In-Reply-To: <20190618103639.22609-1-arkadiusz.hiler@intel.com>

On Tue, 2019-06-18 at 13:36 +0300, Arkadiusz Hiler wrote:
> This test is quite simple which makes it perfect for the first real
> world example of igt_describe usage.
> 
> v2: keep the original comment (Simon)
> 
> Cc: Simon Ser <simon.ser@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Works for me!

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
>  tests/kms_hdmi_inject.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 8c0d1333..c518c5d8 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -33,7 +33,10 @@
>  #define HDISPLAY_4K	3840
>  #define VDISPLAY_4K	2160
>  
> -IGT_TEST_DESCRIPTION("Tests 4K and audio HDMI injection.");
> +IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> +		     "expected results by forcing a disconnected HDMI "
> +		     "connector with a known EDID and checking that the "
> +		     "metadata exposed to user space matches.");
>  
>  /**
>   * This collection of tests performs EDID and status injection tests. Injection
> @@ -210,9 +213,13 @@ igt_main
>  		igt_require(connector);
>  	}
>  
> +	igt_describe("Make sure that 4K modes exposed by DRM match the "
> +                     "forced EDID and modesetting using it succeed.");
>  	igt_subtest("inject-4k")
>  		hdmi_inject_4k(drm_fd, connector);
>  
> +	igt_describe("Make sure that audio information exposed by ALSA "
> +		     "match the forced EDID.");
>  	igt_subtest("inject-audio")
>  		hdmi_inject_audio(drm_fd, connector);
>  
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-06-19  6:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 10:54 [igt-dev] [PATCH i-g-t 1/5] lib/igt_core: Add support for subtest descriptions Arkadiusz Hiler
2019-06-17 10:54 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_hdmi_inject: Provide igt_descriptions Arkadiusz Hiler
2019-06-17 12:54   ` Ser, Simon
2019-06-18 10:36   ` [igt-dev] [PATCH v2 " Arkadiusz Hiler
2019-06-19  6:44     ` Ser, Simon [this message]
2019-06-17 10:54 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_plane_multiple: Describe the test Arkadiusz Hiler
2019-06-18  9:36   ` Kahola, Mika
2019-06-17 10:54 ` [igt-dev] [PATCH i-g-t 4/5] CONTRIBUTING: Rework a bit and update Arkadiusz Hiler
2019-06-20 13:49   ` Ser, Simon
2019-06-27 12:57     ` Arkadiusz Hiler
2019-06-27 14:00       ` Ser, Simon
2019-06-17 10:54 ` [igt-dev] [PATCH i-g-t 5/5] docs: Embed subtest descriptions in the documentation Arkadiusz Hiler
2019-06-20  8:20   ` Petri Latvala
2019-06-20 10:52     ` Arkadiusz Hiler
2019-06-20 11:05       ` Ser, Simon
2019-06-20 11:16         ` Arkadiusz Hiler
2019-06-20 11:11       ` Petri Latvala
2019-06-20 11:38         ` Arkadiusz Hiler
2019-06-20 12:16           ` Petri Latvala
2019-06-24  8:00   ` Ser, Simon
2019-06-27 12:52     ` Arkadiusz Hiler
2019-06-17 13:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/igt_core: Add support for subtest descriptions Patchwork
2019-06-17 19:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-18 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/igt_core: Add support for subtest descriptions (rev2) Patchwork
2019-06-18 22:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e4030ab65a2b2b4cda230bbef33a599c6dcffaf.camel@intel.com \
    --to=simon.ser@intel.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox