Re: [igt-dev] [PATCH i-g-t 2/5] tests/kms_hdmi_inject: Provide igt_descriptions

["Ser, Simon" <simon.ser@intel.com>]

On Mon, 2019-06-17 at 13:54 +0300, Arkadiusz Hiler wrote:
> This test is quite simple which makes it perfect for the first real
> world example of igt_describe usage.
> 
> Cc: Simon Ser <simon.ser@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
>  tests/kms_hdmi_inject.c | 24 ++++++++----------------
>  1 file changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 8c0d1333..f9c5640d 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -33,22 +33,10 @@
>  #define HDISPLAY_4K	3840
>  #define VDISPLAY_4K	2160
>  
> -IGT_TEST_DESCRIPTION("Tests 4K and audio HDMI injection.");
> -
> -/**
> - * This collection of tests performs EDID and status injection tests. Injection
> - * forces a given EDID and status on a connector. The kernel will parse the
> - * forced EDID and we will check whether correct metadata is exposed to
> - * userspace.
> - *
> - * Currently, this can be used to test:
> - *
> - * - 4K modes exposed via KMS
> - * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
> - *   entries in /proc/asound are verified.
> - *
> - * Injection is performed on a disconnected connector.
> - */

Bleh, I think we're loosing some information here. IMHO trying to shove
everything into a compressed test description makes the whole thing
unclear.

In particular, I think the first paragraph + sating that ELDs are used
+ the last sentence are important. Some of these bits are in the new
description but it's hard to follow when you're reading the test for
the first time.

Thoughts?

> +IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> +		     "expected results by forcing a disconnected HDMI "
> +		     "connector with a known EDID and checking that the "
> +		     "metadata exposed to user space matches.");
>  
>  /** get_connector: get the first disconnected HDMI connector */
>  static drmModeConnector *
> @@ -210,9 +198,13 @@ igt_main
>  		igt_require(connector);
>  	}
>  
> +	igt_describe("Make sure that 4K modes exposed by DRM match the "
> +                     "forced EDID and modesetting using it succeed.");
>  	igt_subtest("inject-4k")
>  		hdmi_inject_4k(drm_fd, connector);
>  
> +	igt_describe("Make sure that audio information exposed by ALSA "
> +		     "match the forced EDID.");
>  	igt_subtest("inject-audio")
>  		hdmi_inject_audio(drm_fd, connector);
>  
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev