Re: [PATCH v8 i-g-t 3/3] scripts/run-tests.sh: Add support to kmemleak and igt_facts

[vitaly prosyak <vprosyak@amd.com>]

Hi Peter,

Version 8 of your three patches looks good to me. However, I haven't tested them locally.
Let me know if you’d like us to run them locally ( not CI)

Thanks for the improvements!

Vitaly

On 2025-03-07 04:34, Peter Senna Tschudin wrote:
> Updates scripts/run-tests.sh to include the following options:
>
>  -f:        enable igt_facts on igt_runner
>  -K <mode>: Linux Kernel kmemleak reports
>             - once: run a kmemleak scan after all tests
>             - each: run a kmemleak scan after each test
>
> These options are simply relayed to igt_runner.
>
> Cc: vitaly.prosyak@amd.com
> Cc: christian.koenig@amd.com
> Cc: alexander.deucher@amd.com
> Cc: jesse.zhang@amd.com
> Cc: harry.wentland@amd.com
> Cc: zbigniew.kempczynski@intel.com
> Cc: kamil.konieczny@linux.intel.com
> Cc: ryszard.knop@intel.com
> Cc: lucas.demarchi@intel.com
> Cc: katarzyna.piecielska@intel.com
> Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
> ---
>  scripts/run-tests.sh | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> index 082ebaa5a..1fb9be478 100755
> --- a/scripts/run-tests.sh
> +++ b/scripts/run-tests.sh
> @@ -132,9 +132,13 @@ print_help() {
>  	echo "  -P              store code coverage results per each test. Should be"
>  	echo "                  used together with -k option"
>  	echo "  -d              download Piglit to $ROOT/piglit"
> +	echo "  -f              enable igt_facts on igt_runner"
>  	echo "  -h              display this help message"
>  	echo "  -k <kernel_dir> Linux Kernel source code directory used to generate code"
>  	echo "                  coverage builds."
> +	echo "  -K <mode>       Linux Kernel kmemleak reports"
> +	echo "                   - once: run a kmemleak scan after all tests"
> +	echo "                   - each: run a kmemleak scan after each test"
>  	echo "  -l              list all available tests"
>  	echo "  -r <directory>  store the results in directory"
>  	echo "                  (default: $RESULTS)"
> @@ -160,12 +164,14 @@ print_help() {
>  	echo "Useful patterns for test filtering are described in the API documentation."
>  }
>  
> -while getopts ":c:dhk:lPr:st:T:vx:Rnpb:m:" opt; do
> +while getopts ":c:dfhk:K:lPr:st:T:vx:Rnpb:m:" opt; do
>  	case $opt in
>  		c) COV_ARGS="$COV_ARGS --collect-code-cov --collect-script $OPTARG " ;;
>  		d) download_piglit; exit ;;
> +		f) IGT_FACTS="-f" ;;
>  		h) print_help; exit ;;
>  		k) IGT_KERNEL_TREE="$OPTARG" ;;
> +		K) KMEMLEAK="--kmemleak=$OPTARG" ;;
>  		l) LIST_TESTS="true" ;;
>  		P) COV_ARGS="$COV_ARGS --coverage-per-test"; COV_PER_TEST=1 ;;
>  		r) RESULTS="$OPTARG" ;;
> @@ -256,7 +262,7 @@ if [ "x$RESUME_RUN" != "x" ]; then
>  	execute_runner 1 $RESUME $RESUME_ARGS $COV_ARGS "$RESULTS"
>  else
>  	mkdir -p "$RESULTS"
> -	execute_runner 1 $RUNNER $RUN_ARGS -o -s "$RESULTS" $COV_ARGS $VERBOSE $FILTER --prune-mode $PRUNE_MODE
> +	execute_runner 1 $RUNNER $RUN_ARGS -o $IGT_FACTS $KMEMLEAK -s "$RESULTS" $COV_ARGS $VERBOSE $FILTER --prune-mode $PRUNE_MODE
>  fi
>  
>  if [ "$SUMMARY" = "html" ]; then