Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: vitaly prosyak <vprosyak@amd.com>
To: Peter Senna Tschudin <peter.senna@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: vitaly.prosyak@amd.com, christian.koenig@amd.com,
	alexander.deucher@amd.com, jesse.zhang@amd.com,
	harry.wentland@amd.com, zbigniew.kempczynski@intel.com,
	kamil.konieczny@linux.intel.com, ryszard.knop@intel.com,
	lucas.demarchi@intel.com, katarzyna.piecielska@intel.com
Subject: Re: [PATCH v8 i-g-t 3/3] scripts/run-tests.sh: Add support to kmemleak and igt_facts
Date: Wed, 12 Mar 2025 18:35:44 -0400	[thread overview]
Message-ID: <80b7d4e8-2c1e-4b9c-b662-974cc3926a14@amd.com> (raw)
In-Reply-To: <7992ba86-f665-469b-907b-89f1057a7238@amd.com>

Hi Peter,

We ran the updated igt-runner in our CI with your merged patches, and the memleak feature is working (using the -keach command). However, we noticed what seems to be false positives related to the ACPI driver. The stack is provided below.

I haven’t had a chance to investigate this further, but I think it would be a good idea to share our findings upstream for memleaks found outside of the AMDGPU or i915 drivers.

Here the stack:

comm "swapper/0", pid 1, jiffies 4294672730

 hex dump (first 32 bytes):

   00 00 00 00 00 00 00 00 0d 01 a2 00 00 00 00 00  ................

   f0 7c 03 00 00 c9 ff ff 00 00 00 00 00 00 00 00  .|..............

 backtrace (crc 2df71a7e):

   [<ffffffff824cd71b>] kmemleak_alloc+0x4b/0x80

   [<ffffffff814e169b>] kmem_cache_alloc_noprof+0x2ab/0x370

   [<ffffffff81c2f4dc>] acpi_ps_alloc_op+0xdc/0xf0

   [<ffffffff81c2d650>] acpi_ps_create_op+0x1c0/0x400

   [<ffffffff81c2c8dc>] acpi_ps_parse_loop+0x16c/0xa60

   [<ffffffff81c2e94f>] acpi_ps_parse_aml+0x22f/0x5f0

   [<ffffffff81c2fa82>] acpi_ps_execute_method+0x152/0x380

   [<ffffffff81c233ed>] acpi_ns_evaluate+0x31d/0x5e0

   [<ffffffff81c2a606>] acpi_evaluate_object+0x206/0x490

   [<ffffffff81bf1202>] __acpi_power_off.isra.0+0x22/0x70

   [<ffffffff81bf275b>] acpi_turn_off_unused_power_resources+0xbb/0xf0

   [<ffffffff83867799>] acpi_scan_init+0x119/0x290

   [<ffffffff8386711a>] acpi_init+0x23a/0x590

   [<ffffffff81002c71>] do_one_initcall+0x61/0x3d0

   [<ffffffff837dce32>] kernel_init_freeable+0x3e2/0x680

   [<ffffffff824ca53b>] kernel_init+0x1b/0x170unreferenced object 0xffff888102a2ed18 (size 80):

 comm "swapper/0", pid 1, jiffies 4294672730

 hex dump (first 32 bytes):

   38 e6 a2 02 81 88 ff ff 0d 11 2d 00 00 00 00 00  8.........-.....

   f2 7c 03 00 00 c9 ff ff 58 ea a2 02 81 88 ff ff  .|......X.......

Thanks, Vitaly


On 2025-03-10 16:05, vitaly prosyak wrote:
> Hi Peter and Kamil,
>
> We'll run the tests and I'll follow up on this thread.
>
> Really appreciate you merging this—thank you!
>
> Best,
> Vitaly
>
> On 2025-03-10 03:07, Peter Senna Tschudin wrote:
>> Hi Vitaly,
>>
>> On 10.03.2025 04:07, vitaly prosyak wrote:
>>> Hi Peter,
>>>
>>> Version 8 of your three patches looks good to me. However, I haven't tested them locally.
>>> Let me know if you’d like us to run them locally ( not CI)
>> I ran local tests before sending the patches, so I’m confident there are no major issues.
>> That said, if you’re able to test them locally as well, it would help confirm that
>> everything is working as expected. I’d appreciate it if you could run the tests.
>>
>>> Thanks for the improvements!
>> Thank you for reviewing the patches!
>>
>> Peter
>>
>> [...]

  reply	other threads:[~2025-03-12 22:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  9:34 [PATCH v8 i-g-t 0/3] Integrate kmemleak scans in igt_runner Peter Senna Tschudin
2025-03-07  9:34 ` [PATCH v8 i-g-t 1/3] runner/kmemleak: library to interact with kmemleak Peter Senna Tschudin
2025-03-10 10:37   ` Kamil Konieczny
2025-03-07  9:34 ` [PATCH v8 i-g-t 2/3] runner/executor: Integrate igt_kmemleak scans Peter Senna Tschudin
2025-03-07  9:34 ` [PATCH v8 i-g-t 3/3] scripts/run-tests.sh: Add support to kmemleak and igt_facts Peter Senna Tschudin
2025-03-10  3:07   ` vitaly prosyak
2025-03-10  7:07     ` Peter Senna Tschudin
2025-03-10 20:05       ` vitaly prosyak
2025-03-12 22:35         ` vitaly prosyak [this message]
2025-03-17  8:43           ` Peter Senna Tschudin
2025-03-18  0:28             ` vitaly prosyak
2025-03-07 23:55 ` ✓ Xe.CI.BAT: success for Integrate kmemleak scans in igt_runner (rev6) Patchwork
2025-03-08  0:14 ` ✓ i915.CI.BAT: " Patchwork
2025-03-08  1:44 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-08  7:48   ` Peter Senna Tschudin
2025-03-10 16:17     ` Ravali, JupallyX
2025-03-09 10:52 ` ✗ Xe.CI.Full: " Patchwork
2025-03-10  7:01   ` Peter Senna Tschudin
2025-03-10 11:05 ` [PATCH v8 i-g-t 0/3] Integrate kmemleak scans in igt_runner Kamil Konieczny
2025-03-10 16:14 ` ✓ i915.CI.Full: success for Integrate kmemleak scans in igt_runner (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80b7d4e8-2c1e-4b9c-b662-974cc3926a14@amd.com \
    --to=vprosyak@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jesse.zhang@amd.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=katarzyna.piecielska@intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=peter.senna@linux.intel.com \
    --cc=ryszard.knop@intel.com \
    --cc=vitaly.prosyak@amd.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox