public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
@ 2019-06-19 22:19 Andi Shyti
  2019-06-19 23:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Andi Shyti @ 2019-06-19 22:19 UTC (permalink / raw)
  To: IGT dev; +Cc: Andi Shyti

The execution buffer flag value has now the engine index as it is
mapped in the context. Retrieve its mapped index from the
class/instance coordinate.

Return -EINVAL if the engine is not mapped in the given context.

Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
 lib/i915/gem_engine_topology.c | 12 ++++++++++++
 lib/i915/gem_engine_topology.h |  3 +++
 2 files changed, 15 insertions(+)

diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index fdd1b951672b..23208102021f 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -270,6 +270,18 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,
 	return 0;
 }
 
+int64_t gem_context_get_eb_flags(int fd, uint32_t ctx_id,
+				 int class, int instance)
+{
+	struct intel_execution_engine2 *e;
+
+	for_each_context_engine(fd, ctx_id, e)
+		if (class == e->class && instance == e->instance)
+			return e->flags;
+
+	return -EINVAL;
+}
+
 void gem_context_set_all_engines(int fd, uint32_t ctx)
 {
 	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx, GEM_MAX_ENGINES);
diff --git a/lib/i915/gem_engine_topology.h b/lib/i915/gem_engine_topology.h
index 2415fd1e379b..f575b8968476 100644
--- a/lib/i915/gem_engine_topology.h
+++ b/lib/i915/gem_engine_topology.h
@@ -53,6 +53,9 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,
 
 void gem_context_set_all_engines(int fd, uint32_t ctx);
 
+int64_t gem_context_get_eb_flags(int fd, uint32_t ctx_id,
+				  int class, int instance);
+
 #define __for_each_static_engine(e__) \
 	for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-19 22:19 [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes Andi Shyti
@ 2019-06-19 23:33 ` Patchwork
  2019-06-20  5:59 ` [igt-dev] [PATCH] " Tvrtko Ursulin
  2019-06-20 14:38 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-06-19 23:33 UTC (permalink / raw)
  To: Andi Shyti; +Cc: igt-dev

== Series Details ==

Series: lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
URL   : https://patchwork.freedesktop.org/series/62414/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6312 -> IGTPW_3179
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62414/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3179 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-copy:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [INCOMPLETE][3] ([fdo#107718]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#109485]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][7] ([fdo#103167]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485


Participating hosts (49 -> 42)
------------------------------

  Additional (4): fi-icl-dsi fi-cml-u2 fi-bxt-j4205 fi-cml-u 
  Missing    (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-pnv-d510 fi-icl-y fi-icl-guc fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5061 -> IGTPW_3179

  CI_DRM_6312: 034e3ac6a2d180d188da927388b60c7e62c5655b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3179: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/
  IGT_5061: c88ced79a7b71aec58f1d9c5c599ac2f431bcf7a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-19 22:19 [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes Andi Shyti
  2019-06-19 23:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-06-20  5:59 ` Tvrtko Ursulin
  2019-06-20  7:52   ` Andi Shyti
  2019-06-20 14:38 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  2 siblings, 1 reply; 7+ messages in thread
From: Tvrtko Ursulin @ 2019-06-20  5:59 UTC (permalink / raw)
  To: Andi Shyti, IGT dev; +Cc: Andi Shyti


On 19/06/2019 23:19, Andi Shyti wrote:
> The execution buffer flag value has now the engine index as it is
> mapped in the context. Retrieve its mapped index from the
> class/instance coordinate.

First sentence reads a bit unclear. It may s/have/need/ the engine index _if_ context has engine map. That would be more accurate I think.

Also s/coordiantes/coordinates/ in the subject, although we never used coordinates in this context so maybe just s/coordinates/class:instance/?
 
> Return -EINVAL if the engine is not mapped in the given context.
> 
> Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> ---
>   lib/i915/gem_engine_topology.c | 12 ++++++++++++
>   lib/i915/gem_engine_topology.h |  3 +++
>   2 files changed, 15 insertions(+)
> 
> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> index fdd1b951672b..23208102021f 100644
> --- a/lib/i915/gem_engine_topology.c
> +++ b/lib/i915/gem_engine_topology.c
> @@ -270,6 +270,18 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,
>   	return 0;
>   }
>   
> +int64_t gem_context_get_eb_flags(int fd, uint32_t ctx_id,
> +				 int class, int instance)
> +{

I'd just return int since I don't see 64-bit is giving any benefit. Plus I'd pass in struct i915_engine_class_instance as input.

> +	struct intel_execution_engine2 *e;
> +
> +	for_each_context_engine(fd, ctx_id, e)
> +		if (class == e->class && instance == e->instance)
> +			return e->flags;

And most important difference, I wouldn't configure the context from this helper. Instead I think all we need is:

int gem_context_get_eb_flags(int fd, uint32_t ctx, struct i915_engine_class_instance ci)
{
	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx, GEM_MAX_ENGINES);
	int ret

	ret = gem_topology_get_param(fd, &param);
	if (ret) {
		const struct intel_execution_engine2 *e;

		/* Legacy kernels. */
		__for_each_static_engine(e) {
			if (e->class == ci.engine_class &&
			    e->instance == ci.engine_instance)
				return e->flags;
		}

		return -EINVAL;
	}

	/* Engine map with no engines. */
	if (!param.size)
		return -EINVAL;

	/* Engine map lookup. */
	for (unsigned int i = 0; i < param.size; i++) {
		if (engines.engines[i].engine_class == ci.engine_class &&
		    engines.engines[i].engine_instance == ci.engine_instance)
			return i;
	}

	return -EINVAL;
}

Regards,

Tvrtko

> +
> +	return -EINVAL;
> +}
> +
>   void gem_context_set_all_engines(int fd, uint32_t ctx)
>   {
>   	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx, GEM_MAX_ENGINES);
> diff --git a/lib/i915/gem_engine_topology.h b/lib/i915/gem_engine_topology.h
> index 2415fd1e379b..f575b8968476 100644
> --- a/lib/i915/gem_engine_topology.h
> +++ b/lib/i915/gem_engine_topology.h
> @@ -53,6 +53,9 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,
>   
>   void gem_context_set_all_engines(int fd, uint32_t ctx);
>   
> +int64_t gem_context_get_eb_flags(int fd, uint32_t ctx_id,
> +				  int class, int instance);
> +
>   #define __for_each_static_engine(e__) \
>   	for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-20  5:59 ` [igt-dev] [PATCH] " Tvrtko Ursulin
@ 2019-06-20  7:52   ` Andi Shyti
  2019-06-20  8:12     ` Tvrtko Ursulin
  0 siblings, 1 reply; 7+ messages in thread
From: Andi Shyti @ 2019-06-20  7:52 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: IGT dev, Andi Shyti

Hi Tvrtko,

> > +	struct intel_execution_engine2 *e;
> > +
> > +	for_each_context_engine(fd, ctx_id, e)
> > +		if (class == e->class && instance == e->instance)
> > +			return e->flags;
> 
> And most important difference, I wouldn't configure the context from this helper. Instead I think all we need is:
> 
> int gem_context_get_eb_flags(int fd, uint32_t ctx, struct i915_engine_class_instance ci)
> {
> 	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx, GEM_MAX_ENGINES);
> 	int ret
> 
> 	ret = gem_topology_get_param(fd, &param);
> 	if (ret) {
> 		const struct intel_execution_engine2 *e;
> 
> 		/* Legacy kernels. */
> 		__for_each_static_engine(e) {
> 			if (e->class == ci.engine_class &&
> 			    e->instance == ci.engine_instance)
> 				return e->flags;
> 		}
> 
> 		return -EINVAL;
> 	}
> 
> 	/* Engine map with no engines. */
> 	if (!param.size)
> 		return -EINVAL;

this means that tests have responsibility to alway create a
context and do the mapping before (we haven't always assumed it
in other tests).

> 	/* Engine map lookup. */
> 	for (unsigned int i = 0; i < param.size; i++) {
> 		if (engines.engines[i].engine_class == ci.engine_class &&
> 		    engines.engines[i].engine_instance == ci.engine_instance)
> 			return i;
> 	}
> 
> 	return -EINVAL;
> }

This version, a the end, becomes a slim version of
'intel_init_engine_list', with the only difference that it
wouldn't do any mapping (which I agree would be too much but we
did it in other tests), that's why, at the end I preferred the
short version I sent.

OK, we can definitely do it this way, too

Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-20  7:52   ` Andi Shyti
@ 2019-06-20  8:12     ` Tvrtko Ursulin
  2019-06-20  8:26       ` Chris Wilson
  0 siblings, 1 reply; 7+ messages in thread
From: Tvrtko Ursulin @ 2019-06-20  8:12 UTC (permalink / raw)
  To: Andi Shyti; +Cc: IGT dev


On 20/06/2019 08:52, Andi Shyti wrote:
> Hi Tvrtko,
> 
>>> +	struct intel_execution_engine2 *e;
>>> +
>>> +	for_each_context_engine(fd, ctx_id, e)
>>> +		if (class == e->class && instance == e->instance)
>>> +			return e->flags;
>>
>> And most important difference, I wouldn't configure the context from this helper. Instead I think all we need is:
>>
>> int gem_context_get_eb_flags(int fd, uint32_t ctx, struct i915_engine_class_instance ci)
>> {
>> 	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx, GEM_MAX_ENGINES);
>> 	int ret
>>
>> 	ret = gem_topology_get_param(fd, &param);
>> 	if (ret) {
>> 		const struct intel_execution_engine2 *e;
>>
>> 		/* Legacy kernels. */
>> 		__for_each_static_engine(e) {
>> 			if (e->class == ci.engine_class &&
>> 			    e->instance == ci.engine_instance)
>> 				return e->flags;
>> 		}
>>
>> 		return -EINVAL;
>> 	}
>>
>> 	/* Engine map with no engines. */
>> 	if (!param.size)
>> 		return -EINVAL;
> 
> this means that tests have responsibility to alway create a
> context and do the mapping before (we haven't always assumed it
> in other tests).

This particular check? This should be map with zero engines, a very 
special case we currently do not configure in scope of engine topology code.

>> 	/* Engine map lookup. */
>> 	for (unsigned int i = 0; i < param.size; i++) {
>> 		if (engines.engines[i].engine_class == ci.engine_class &&
>> 		    engines.engines[i].engine_instance == ci.engine_instance)
>> 			return i;
>> 	}
>>
>> 	return -EINVAL;
>> }
> 
> This version, a the end, becomes a slim version of
> 'intel_init_engine_list', with the only difference that it
> wouldn't do any mapping (which I agree would be too much but we
> did it in other tests), that's why, at the end I preferred the
> short version I sent.
> 
> OK, we can definitely do it this way, too

I think it would be wrong to configure the context from this helper. The 
name of the function translates to "give me correct eb.flags for this 
context to submit to this class:instance". All function needs to do is 
to answer this question both on legacy and new kernels.

Also, it is okay to refactor the library code if there is enough 
commonality for extracting or something.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-20  8:12     ` Tvrtko Ursulin
@ 2019-06-20  8:26       ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-06-20  8:26 UTC (permalink / raw)
  To: Andi Shyti, Tvrtko Ursulin; +Cc: IGT dev

Quoting Tvrtko Ursulin (2019-06-20 09:12:55)
> 
> On 20/06/2019 08:52, Andi Shyti wrote:
> > Hi Tvrtko,
> > 
> >>> +   struct intel_execution_engine2 *e;
> >>> +
> >>> +   for_each_context_engine(fd, ctx_id, e)
> >>> +           if (class == e->class && instance == e->instance)
> >>> +                   return e->flags;
> >>
> >> And most important difference, I wouldn't configure the context from this helper. Instead I think all we need is:
> >>
> >> int gem_context_get_eb_flags(int fd, uint32_t ctx, struct i915_engine_class_instance ci)
> >> {

[snip]

> I think it would be wrong to configure the context from this helper. The 
> name of the function translates to "give me correct eb.flags for this 
> context to submit to this class:instance". All function needs to do is 
> to answer this question both on legacy and new kernels.

Yes. I think it would be most surprising if a getter reconfigured the
context.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
  2019-06-19 22:19 [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes Andi Shyti
  2019-06-19 23:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-06-20  5:59 ` [igt-dev] [PATCH] " Tvrtko Ursulin
@ 2019-06-20 14:38 ` Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-06-20 14:38 UTC (permalink / raw)
  To: Andi Shyti; +Cc: igt-dev

== Series Details ==

Series: lib/i915: gem_engine_topology: get eb flags from engine's coordiantes
URL   : https://patchwork.freedesktop.org/series/62414/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6312_full -> IGTPW_3179_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62414/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3179_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-contexts-immediate:
    - shard-kbl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-kbl7/igt@gem_eio@in-flight-contexts-immediate.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-kbl2/igt@gem_eio@in-flight-contexts-immediate.html

  * igt@gem_eio@wait-wedge-10ms:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl7/igt@gem_eio@wait-wedge-10ms.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl8/igt@gem_eio@wait-wedge-10ms.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-snb:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +5 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl7/igt@gem_workarounds@suspend-resume.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl1/igt@gem_workarounds@suspend-resume.html

  * igt@i915_hangman@error-state-basic:
    - shard-snb:          [PASS][9] -> [DMESG-WARN][10] ([fdo#110789] / [fdo#110913 ])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb1/igt@i915_hangman@error-state-basic.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb1/igt@i915_hangman@error-state-basic.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [PASS][11] -> [SKIP][12] ([fdo#109271])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb2/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen:
    - shard-kbl:          [PASS][13] -> [FAIL][14] ([fdo#103232])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
    - shard-apl:          [PASS][15] -> [FAIL][16] ([fdo#103232])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][17] -> [FAIL][18] ([fdo#105767])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-hsw:          [PASS][19] -> [SKIP][20] ([fdo#109271]) +19 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-hsw4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-hsw1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl6/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl4/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-snb:          [DMESG-WARN][23] ([fdo#110789] / [fdo#110913 ]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-apl:          [DMESG-WARN][25] ([fdo#110913 ]) -> [PASS][26] +4 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl3/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
    - shard-snb:          [DMESG-WARN][27] ([fdo#110913 ]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-kbl:          [DMESG-WARN][29] ([fdo#110913 ]) -> [PASS][30] +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-kbl1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-kbl2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
    - shard-snb:          [SKIP][31] ([fdo#109271] / [fdo#109278]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb2/igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb5/igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-glk:          [FAIL][33] ([fdo#104873]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [SKIP][35] ([fdo#109271]) -> [PASS][36] +22 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
    - shard-snb:          [SKIP][39] ([fdo#109271]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-snb2/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-snb2/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][41] ([fdo#99912]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6312/shard-kbl1/igt@kms_setmode@basic.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/shard-kbl6/igt@kms_setmode@basic.html

  
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

  * IGT: IGT_5061 -> IGTPW_3179
  * Piglit: piglit_4509 -> None

  CI_DRM_6312: 034e3ac6a2d180d188da927388b60c7e62c5655b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3179: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/
  IGT_5061: c88ced79a7b71aec58f1d9c5c599ac2f431bcf7a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3179/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-06-20 14:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 22:19 [igt-dev] [PATCH] lib/i915: gem_engine_topology: get eb flags from engine's coordiantes Andi Shyti
2019-06-19 23:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-20  5:59 ` [igt-dev] [PATCH] " Tvrtko Ursulin
2019-06-20  7:52   ` Andi Shyti
2019-06-20  8:12     ` Tvrtko Ursulin
2019-06-20  8:26       ` Chris Wilson
2019-06-20 14:38 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox