Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s
@ 2018-03-21  0:29 Paulo Zanoni
  2018-03-21  1:06 ` Chris Wilson
  2018-03-21  9:15 ` [igt-dev] ✗ Fi.CI.BAT: warning for " Patchwork
  0 siblings, 2 replies; 5+ messages in thread
From: Paulo Zanoni @ 2018-03-21  0:29 UTC (permalink / raw)
  To: igt-dev

From: "Lofstedt, Marta" <marta.lofstedt@intel.com>

This is a partial revert of:
64590c7b768dc8d8dd962f812d5ff5a39e7e8b54 ("kms_frontbuffer_tracking:
reduce the FBC wait timeout to 2s")

The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* have
non-consistent results, pending between fail and pass. The fails are
always due to "FBC disabled".  With this increase in timeout the
flip-flop behavior is no longer reproducible.

We did not bisect why exactly this change is now required, since the
retire handler should happen about once per second and only be delayed
if user space is "hostile". Anyway, bumping from 2s to 5s really
reduces the chance that a skipped retirement cycle would affect the
results of the test. In case this still proves to be an issue we may
want to call igt_drop_caches_set(device, DROP_RETIRE), but then we'll
probably need a test that exercises the case where we don't use this
ioctl. For more information, see the discussion of this patch on the
mailing list (Aug/Sep 2017 on intel-gfx). For now let's merge this in
the hope that CI will have less failures.

v2 (from Paulo): update commit message and rebase.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 619186a5..64a80b6d 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -935,7 +935,7 @@ static bool fbc_is_compressing(void)
 
 static bool fbc_wait_for_compression(void)
 {
-	return igt_wait(fbc_is_compressing(), 2000, 1);
+	return igt_wait(fbc_is_compressing(), 5000, 1);
 }
 
 static bool fbc_not_enough_stolen(void)
@@ -958,7 +958,7 @@ static bool fbc_wait_until_enabled(void)
 {
 	last_fbc_buf[0] = '\0';
 
-	return igt_wait(fbc_is_enabled(IGT_LOG_DEBUG), 2000, 1);
+	return igt_wait(fbc_is_enabled(IGT_LOG_DEBUG), 5000, 1);
 }
 
 static bool psr_wait_until_enabled(void)
-- 
2.14.3

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-21 18:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-21  0:29 [igt-dev] [PATCH igt] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s Paulo Zanoni
2018-03-21  1:06 ` Chris Wilson
2018-03-21  8:02   ` Lofstedt, Marta
2018-03-21 18:17   ` Paulo Zanoni
2018-03-21  9:15 ` [igt-dev] ✗ Fi.CI.BAT: warning for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox