* [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
@ 2018-04-06 12:19 Marta Lofstedt
2018-04-06 14:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marta Lofstedt @ 2018-04-06 12:19 UTC (permalink / raw)
To: igt-dev
The kms_frontbuffer_tracking@*suspend subtests spend 20 seconds
sleeping around igt_system_suspend_autoresume. I find no other
igt test that require sleeping in relation to suspend-resume, so
it should be removed.
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
tests/kms_frontbuffer_tracking.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index a20e7118..d26078cc 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -2830,15 +2830,11 @@ static void suspend_subtest(const struct test_mode *t)
struct modeset_params *params = pick_params(t);
prepare_subtest(t, NULL);
- sleep(5);
igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
- sleep(5);
do_assertions(ASSERT_DRRS_LOW);
unset_all_crtcs();
- sleep(5);
igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
- sleep(5);
do_assertions(ASSERT_FBC_DISABLED | ASSERT_PSR_DISABLED |
DONT_ASSERT_CRC | ASSERT_DRRS_INACTIVE);
--
2.11.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
2018-04-06 12:19 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep Marta Lofstedt
@ 2018-04-06 14:47 ` Patchwork
2018-04-06 17:02 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-09 17:55 ` [igt-dev] [PATCH i-g-t] " Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-06 14:47 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
URL : https://patchwork.freedesktop.org/series/41269/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
8a7353abf41eb3dbbde240ac5f7ac26f92ed693a tests/kms_psr_sink_crc: Save runtime by not waiting in crc function
with latest DRM-Tip kernel build CI_DRM_4030
8ff6fb0c22f1 drm-tip: 2018y-04m-06d-12h-37m-26s UTC integration manifest
No testlist changes.
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
incomplete -> PASS (fi-bdw-5557u) fdo#104944
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104944 https://bugs.freedesktop.org/show_bug.cgi?id=104944
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:431s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:441s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:515s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:522s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:511s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:413s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:561s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:513s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:597s
fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:429s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:315s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:485s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:412s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:425s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:472s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:440s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:474s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:467s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:513s
fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:665s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:453s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:543s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:505s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:502s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:432s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:453s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:571s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:401s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1233/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
2018-04-06 12:19 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep Marta Lofstedt
2018-04-06 14:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-06 17:02 ` Patchwork
2018-04-09 17:55 ` [igt-dev] [PATCH i-g-t] " Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-06 17:02 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
URL : https://patchwork.freedesktop.org/series/41269/
State : success
== Summary ==
---- Known issues:
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Subgroup plain-flip-ts-check:
pass -> FAIL (shard-hsw) fdo#100368 +2
Test kms_plane_multiple:
Subgroup atomic-pipe-a-tiling-x:
pass -> FAIL (shard-snb) fdo#103166
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
pass -> FAIL (shard-snb) fdo#103925
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
shard-apl total:2680 pass:1836 dwarn:1 dfail:0 fail:7 skip:836 time:12703s
shard-hsw total:2680 pass:1785 dwarn:1 dfail:0 fail:2 skip:891 time:11435s
shard-snb total:2680 pass:1376 dwarn:1 dfail:0 fail:4 skip:1299 time:6906s
Blacklisted hosts:
shard-kbl total:2680 pass:1960 dwarn:1 dfail:0 fail:8 skip:711 time:9278s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1233/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep.
2018-04-06 12:19 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep Marta Lofstedt
2018-04-06 14:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-06 17:02 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-09 17:55 ` Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Paulo Zanoni @ 2018-04-09 17:55 UTC (permalink / raw)
To: Marta Lofstedt, igt-dev
Em Sex, 2018-04-06 às 15:19 +0300, Marta Lofstedt escreveu:
> The kms_frontbuffer_tracking@*suspend subtests spend 20 seconds
> sleeping around igt_system_suspend_autoresume. I find no other
> igt test that require sleeping in relation to suspend-resume, so
> it should be removed.
If, and only if, you have data showing this won't cause problems on CI:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
> tests/kms_frontbuffer_tracking.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c
> b/tests/kms_frontbuffer_tracking.c
> index a20e7118..d26078cc 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2830,15 +2830,11 @@ static void suspend_subtest(const struct
> test_mode *t)
> struct modeset_params *params = pick_params(t);
>
> prepare_subtest(t, NULL);
> - sleep(5);
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> SUSPEND_TEST_NONE);
> - sleep(5);
> do_assertions(ASSERT_DRRS_LOW);
>
> unset_all_crtcs();
> - sleep(5);
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> SUSPEND_TEST_NONE);
> - sleep(5);
> do_assertions(ASSERT_FBC_DISABLED | ASSERT_PSR_DISABLED |
> DONT_ASSERT_CRC | ASSERT_DRRS_INACTIVE);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-09 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-06 12:19 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Save runtime by removing sleep Marta Lofstedt
2018-04-06 14:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-06 17:02 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-09 17:55 ` [igt-dev] [PATCH i-g-t] " Paulo Zanoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox