public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Anshuman Gupta via igt-dev <igt-dev@lists.freedesktop.org>
To: igt-dev@lists.freedesktop.org
Cc: jyoti.r.yadav@intel.com, anshuman.gupta@intel.com
Subject: [igt-dev] [PATCH i-g-t v5 4/5] tests/pm_dc: Added test for DC5 during DPMS
Date: Fri, 15 Feb 2019 14:16:05 +0530	[thread overview]
Message-ID: <1550220366-21575-5-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1550220366-21575-1-git-send-email-anshuman.gupta@intel.com>

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Added new subtest for DC5 entry during DPMS on/off cycle.
During DPMS on/off cycle DC5 counter is incremented.

v2: Rename the subtest with meaningful name.
v3: Rebased.
v4: Addressed review comments by removing leftover code
    cleanup().
v5: Addressed the review comment by removing redundant
    read_dc_counter() suggested by Imre.
    Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/pm_dc.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/tests/pm_dc.c b/tests/pm_dc.c
index b26f3d8..8bc684e 100644
--- a/tests/pm_dc.c
+++ b/tests/pm_dc.c
@@ -173,6 +173,29 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
 	cleanup(&data);
 }
 
+static void dpms_off_on(data_t *data)
+{
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+					   DRM_MODE_DPMS_OFF);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+				   DRM_MODE_DPMS_ON);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
+}
+
+static void test_dc_state_dpms(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter;
+
+	dc_counter = read_dc_counter(data->drm_fd, dc_flag);
+	dpms_off_on(data);
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter);
+}
+
 int main(int argc, char *argv[])
 {
 	bool has_runtime_pm;
@@ -208,6 +231,11 @@ int main(int argc, char *argv[])
 			      "Sink does not support PSR\n");
 		test_dc_state_psr(&data, CHECK_DC6);
 	}
+
+	igt_subtest("dc5-dpms") {
+		test_dc_state_dpms(&data, CHECK_DC5);
+	}
+
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-02-15  8:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  8:46 [igt-dev] [PATCH i-g-t v5 0/5] DC states igt tests patch series Anshuman Gupta via igt-dev
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 1/5] lib/igt_pm: Moves Dmc_loaded() function into library Anshuman Gupta via igt-dev
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 2/5] tests/pm_dc: Added new test to verify Display C States Anshuman Gupta via igt-dev
2019-02-20 16:52   ` [igt-dev] [PATCH i-g-t v6 " Anshuman Gupta
2019-02-20 23:08     ` Dhinakaran Pandiyan
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 3/5] tests/pm_dc: Added test for DC6 during PSR Anshuman Gupta via igt-dev
2019-02-15  8:46 ` Anshuman Gupta via igt-dev [this message]
2019-02-20 16:56   ` [igt-dev] [PATCH i-g-t v6 4/5] tests/pm_dc: Added test for DC5 during DPMS Anshuman Gupta
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 5/5] tests/pm_dc: Added test for DC6 " Anshuman Gupta via igt-dev
2019-02-16 20:42 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series Patchwork
2019-02-16 21:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-21 15:31   ` Imre Deak
2019-02-22 15:01     ` Anshuman Gupta
2019-02-25 10:42       ` Imre Deak
2019-02-26  6:07         ` Anshuman Gupta
2019-02-28 14:01           ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1550220366-21575-5-git-send-email-anshuman.gupta@intel.com \
    --to=igt-dev@lists.freedesktop.org \
    --cc=anshuman.gupta@intel.com \
    --cc=jyoti.r.yadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox