public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, jyoti.r.yadav@intel.com
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series
Date: Mon, 25 Feb 2019 12:42:35 +0200	[thread overview]
Message-ID: <20190225104235.GC9900@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20190222150154.GA27911@genxfsim-desktop>

On Fri, Feb 22, 2019 at 08:31:54PM +0530, Anshuman Gupta wrote:
> > > [...]
> > > #### Possible regressions ####
> > > 
> > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> > >     - shard-apl:          PASS -> FAIL
> > > 
> > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > >     - shard-glk:          NOTRUN -> FAIL
> > 
> > The problem here is that the device gets runtime suspended, after which
> > the DMC FW will get reprogrammed during runtime resume. This means the
> > FW's DC counters will get reset too.
> > 
> > I think it makes sense to test DC5 independent of runtime s/r (where
> > we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
> > runtime suspend disabled on platforms that support DC9.
> > 
> > Could you please add that?
>
> I did not get it how to achieve DC9 with i915 runtime suspend
> disabled.  AFAIK DC9 is enabled by suspend callback
> intel_runtime_suspend, i915_drm_suspend_late.  Please let me know if
> it can be enabled by some other code flow.

We want to prevent DC9, because that clears the DC5/6 counters in the
firmware, leading to the above test failure.

--Imre

> 
> > 
> > >     - shard-apl:          NOTRUN -> FAIL
> > > 
> > >   
> > > New tests
> > > ---------
> > > 
> > >   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> > > 
> > > ### New IGT tests (4) ###
> > > 
> > >   * igt@pm_dc@dc5-dpms:
> > >     - Statuses : 2 fail(s) 2 skip(s)
> > >     - Exec time: [0.0, 1.65] s
> > > 
> > >   * igt@pm_dc@dc5-psr:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0] s
> > > 
> > >   * igt@pm_dc@dc6-dpms:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0, 0.00] s
> > > 
> > >   * igt@pm_dc@dc6-psr:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0] s
> > > 
> > >   
> > > 
> > > Known issues
> > > ------------
> > > 
> > >   Here are the changes found in IGTPW_2432_full that come from known issues:
> > > 
> > > ### IGT changes ###
> > > 
> > > #### Issues hit ####
> > > 
> > >   * igt@kms_atomic_transition@plane-all-modeset-transition:
> > >     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> > >     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > >     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> > > 
> > >   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> > >     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> > > 
> > >   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> > >     - shard-glk:          PASS -> FAIL [fdo#108145]
> > > 
> > >   * igt@kms_cursor_crc@cursor-64x21-random:
> > >     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> > > 
> > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > >     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > >     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> > >     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> > >     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> > > 
> > >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > >     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
> > >     - shard-glk:          PASS -> FAIL [fdo#103166] +4
> > >     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> > > 
> > >   * igt@kms_setmode@basic:
> > >     - shard-apl:          PASS -> FAIL [fdo#99912]
> > >     - shard-hsw:          PASS -> FAIL [fdo#99912]
> > > 
> > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > >     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > 
> > >   * {igt@pm_dc@dc5-psr} (NEW):
> > >     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > 
> > >   * {igt@pm_dc@dc6-psr} (NEW):
> > >     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
> > >     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > 
> > >   
> > > #### Possible fixes ####
> > > 
> > >   * igt@gem_eio@unwedge-stress:
> > >     - shard-snb:          FAIL -> PASS
> > > 
> > >   * igt@gem_linear_blits@normal:
> > >     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> > > 
> > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
> > >     - shard-apl:          FAIL -> PASS
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > >     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> > > 
> > >   * igt@kms_cursor_crc@cursor-128x128-random:
> > >     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> > > 
> > >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> > >     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
> > >     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> > >     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> > > 
> > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> > >     - shard-apl:          FAIL [fdo#108145] -> PASS
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> > >     - shard-glk:          FAIL [fdo#103166] -> PASS
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> > >     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> > > 
> > >   * igt@pm_rc6_residency@rc6-accuracy:
> > >     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> > > 
> > >   
> > >   {name}: This element is suppressed. This means it is ignored when computing
> > >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > > 
> > >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > >   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> > >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > >   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> > >   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> > >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> > >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> > > 
> > > 
> > > Participating hosts (7 -> 4)
> > > ------------------------------
> > > 
> > >   Missing    (3): shard-skl shard-kbl shard-iclb 
> > > 
> > > 
> > > Build changes
> > > -------------
> > > 
> > >     * IGT: IGT_4833 -> IGTPW_2432
> > >     * Piglit: piglit_4509 -> None
> > > 
> > >   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
> > >   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > >   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> > > 
> > > == Logs ==
> > > 
> > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> Thanks ,
> Anshuman Gupta.
> -- 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-02-25 10:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  8:46 [igt-dev] [PATCH i-g-t v5 0/5] DC states igt tests patch series Anshuman Gupta via igt-dev
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 1/5] lib/igt_pm: Moves Dmc_loaded() function into library Anshuman Gupta via igt-dev
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 2/5] tests/pm_dc: Added new test to verify Display C States Anshuman Gupta via igt-dev
2019-02-20 16:52   ` [igt-dev] [PATCH i-g-t v6 " Anshuman Gupta
2019-02-20 23:08     ` Dhinakaran Pandiyan
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 3/5] tests/pm_dc: Added test for DC6 during PSR Anshuman Gupta via igt-dev
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 4/5] tests/pm_dc: Added test for DC5 during DPMS Anshuman Gupta via igt-dev
2019-02-20 16:56   ` [igt-dev] [PATCH i-g-t v6 " Anshuman Gupta
2019-02-15  8:46 ` [igt-dev] [PATCH i-g-t v5 5/5] tests/pm_dc: Added test for DC6 " Anshuman Gupta via igt-dev
2019-02-16 20:42 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series Patchwork
2019-02-16 21:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-21 15:31   ` Imre Deak
2019-02-22 15:01     ` Anshuman Gupta
2019-02-25 10:42       ` Imre Deak [this message]
2019-02-26  6:07         ` Anshuman Gupta
2019-02-28 14:01           ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225104235.GC9900@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jyoti.r.yadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox