From: Kevin Strasser <kevin.strasser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [RFC 5/5] tests/kms_plane_scaling: Skip testing unsupported fp16 features
Date: Sat, 2 Mar 2019 17:39:06 -0800 [thread overview]
Message-ID: <1551577146-2348-6-git-send-email-kevin.strasser@intel.com> (raw)
In-Reply-To: <1551577146-2348-1-git-send-email-kevin.strasser@intel.com>
Disallow Yf tiling and Y-tiled 90/270 rotation for fp16 on Intel hardware.
Signed-off-by: Kevin Strasser <kevin.strasser@intel.com>
---
tests/kms_plane_scaling.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 1015c80..fed6b3d 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -193,6 +193,14 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
igt_rotation_t rot = rotations[i];
for (int j = 0; j < plane->drm_plane->count_formats; j++) {
unsigned format = plane->drm_plane->formats[j];
+
+ // Y-tiled 90/270 rotation isn't supported for fp16 on Intel
+ if (is_i915_device(d->drm_fd) &&
+ igt_format_is_fp16(format) &&
+ (rot == IGT_ROTATION_90 ||
+ rot == IGT_ROTATION_270))
+ continue;
+
if (igt_fb_supported_format(format) &&
can_rotate(d, format))
check_scaling_pipe_plane_rot(d, plane, format,
@@ -227,6 +235,12 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
for (int j = 0; j < plane->drm_plane->count_formats; j++) {
uint32_t format = plane->drm_plane->formats[j];
+ // Yf Tiling not supported for fp16 on Intel
+ if (is_i915_device(d->drm_fd) &&
+ igt_format_is_fp16(format) &&
+ tiling == LOCAL_I915_FORMAT_MOD_Yf_TILED)
+ continue;
+
if (igt_fb_supported_format(format))
check_scaling_pipe_plane_rot(d, plane,
format, tiling,
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-03 1:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 1:39 [igt-dev] [RFC 0/5] Add support for fp16 formats Kevin Strasser
2019-03-03 1:39 ` [igt-dev] [RFC 1/5] lib: Add halffloat implementation Kevin Strasser
2019-03-04 8:16 ` Maarten Lankhorst
2019-03-04 17:03 ` Strasser, Kevin
2019-03-05 11:21 ` Maarten Lankhorst
2019-03-03 1:39 ` [igt-dev] [RFC 2/5] include: Add fp16 format defines Kevin Strasser
2019-03-03 1:39 ` [igt-dev] [RFC 3/5] tests/kms_available_modes_crc: Add cases for 64bit formats Kevin Strasser
2019-03-04 8:17 ` Maarten Lankhorst
2019-03-03 1:39 ` [igt-dev] [RFC 4/5] lib/igt_fb: Add support for fp16 formats through conversion Kevin Strasser
2019-03-03 1:39 ` Kevin Strasser [this message]
2019-03-04 8:35 ` [igt-dev] [RFC 5/5] tests/kms_plane_scaling: Skip testing unsupported fp16 features Maarten Lankhorst
2019-03-04 17:21 ` Strasser, Kevin
2019-03-03 2:11 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for fp16 formats Patchwork
2019-03-03 3:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551577146-2348-6-git-send-email-kevin.strasser@intel.com \
--to=kevin.strasser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox