From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Strasser, Kevin" <kevin.strasser@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [RFC 1/5] lib: Add halffloat implementation
Date: Tue, 5 Mar 2019 12:21:10 +0100 [thread overview]
Message-ID: <a77cc5b7-3605-711c-1947-3d454f2262f5@linux.intel.com> (raw)
In-Reply-To: <51B6C3CD1F10FB47A5702881E0E230A793D47397@ORSMSX104.amr.corp.intel.com>
Op 04-03-2019 om 18:03 schreef Strasser, Kevin:
> Maarten Lankhorst wrote:
>> 4 function calls for every pixel is a bit much. Is there any cleaner way we
>> could accomplish the same?
>>
>> void igt_float_to_half(const float *, uint16_t *, int num)
>>
>> void igt_half_to_float(const uint16_t *, float *, int num)
>>
>> If no swizzle is required, it could do an entire line in 1 go, else per 4 or 3.
>>
>> Might be worth it to still do a line in 1 go, even for xrgb, with format
>> always set to rba128f, hardware will ignore the X component anyway. :)
>>
>> And then if required reswizzle.
> Interesting ideas, I agree we should be able to shave off some overhead with the
> function calls. I'm not so sure the payoff would be worth the extra conversions
> in the xrgb case, but I'll do some experimentation and fix accordingly.
>
> Thanks,
> Kevin
Just treat xrgb as argb, alpha channel should be ignored by hw. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-05 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 1:39 [igt-dev] [RFC 0/5] Add support for fp16 formats Kevin Strasser
2019-03-03 1:39 ` [igt-dev] [RFC 1/5] lib: Add halffloat implementation Kevin Strasser
2019-03-04 8:16 ` Maarten Lankhorst
2019-03-04 17:03 ` Strasser, Kevin
2019-03-05 11:21 ` Maarten Lankhorst [this message]
2019-03-03 1:39 ` [igt-dev] [RFC 2/5] include: Add fp16 format defines Kevin Strasser
2019-03-03 1:39 ` [igt-dev] [RFC 3/5] tests/kms_available_modes_crc: Add cases for 64bit formats Kevin Strasser
2019-03-04 8:17 ` Maarten Lankhorst
2019-03-03 1:39 ` [igt-dev] [RFC 4/5] lib/igt_fb: Add support for fp16 formats through conversion Kevin Strasser
2019-03-03 1:39 ` [igt-dev] [RFC 5/5] tests/kms_plane_scaling: Skip testing unsupported fp16 features Kevin Strasser
2019-03-04 8:35 ` Maarten Lankhorst
2019-03-04 17:21 ` Strasser, Kevin
2019-03-03 2:11 ` [igt-dev] ✓ Fi.CI.BAT: success for Add support for fp16 formats Patchwork
2019-03-03 3:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a77cc5b7-3605-711c-1947-3d454f2262f5@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kevin.strasser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox