* [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11
@ 2019-05-08 6:31 Anshuman Gupta
2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Anshuman Gupta @ 2019-05-08 6:31 UTC (permalink / raw)
To: igt-dev; +Cc: jyoti.r.yadav
This patch series adds new tests to validate Display C states.
DC states like DC5 and DC6 are validated during PSR entry/exit and during DPMS on/off cycle.
This is an update after fixing the IGT failure crashes in i915_pm_rpm
caused by enable/restore SATA link power changes in lib/igt_pm.c.
Below is the summary of major changes since first revision.
1. Changed the name of test from "pm_dc" to "i915_pm_dc" aligned to other PM tests.
2. Changed the DC5/6 counter check timeout from 1 sec to 3 sec,
as in case of PSR on some platfrom like KBL it requires more than 2 second to
disable 'DC off' power well after vblank event.
3. Changed the test name from tests/pm_dc to tests tests/i915/i915_pm_dc in
name of individual patch.
4. Addressed the review comment by saving POWER_DIR values in igt_disable_runtime_pm().
5. CI fixures for dc5-dpms failure.
Checking DC5 counter value after DPMS off, broke the dpms_on_off
function to dpms_on and dpms_off.
6. Used igt_pm_enable_sata_link_power_management() function in order to use
min_power policy for SATA.
7. igt_pm_enable_sata_link_power_management() function to restore the
original SATA link power policy using an exit handler.
8. IGT crashes fixture in i915_pm_rpm.c.
Jyoti Yadav (5):
lib/igt_pm: igt lib helper routines to support DC5/6 tests
tests/i915/i915_pm_dc: Added new test to verify Display C States
tests/i915/i915_pm_dc: Added test for DC6 during PSR
tests/i915/i915_pm_dc: Added test for DC5 during DPMS
tests/i915/i915_pm_dc: Added test for DC6 during DPMS
lib/igt_pm.c | 190 +++++++++++++++++++++------
lib/igt_pm.h | 6 +-
tests/Makefile.sources | 3 +
tests/i915/i915_pm_backlight.c | 6 +-
tests/i915/i915_pm_dc.c | 286 +++++++++++++++++++++++++++++++++++++++++
tests/i915/i915_pm_rpm.c | 24 +---
tests/meson.build | 1 +
7 files changed, 449 insertions(+), 67 deletions(-)
create mode 100644 tests/i915/i915_pm_dc.c
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* [igt-dev] [PATCH i-g-t v12 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta @ 2019-05-08 6:31 ` Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 3/5] tests/i915/i915_pm_dc: Added test for DC6 during PSR Anshuman Gupta ` (6 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Anshuman Gupta @ 2019-05-08 6:31 UTC (permalink / raw) To: igt-dev; +Cc: jyoti.r.yadav From: Jyoti Yadav <jyoti.r.yadav@intel.com> This patch does the following chnegs to lib/igt_pm.c -dmc_loaded() will be used by new test i915_pm_dc.c which will validate Display C States. So moving the same to igt_pm library. -Introduced igt_disable_runtime_pm() in order to disable runtime suspend for the function which support dc9. -Changed the igt_pm_enable_sata_link_power_management() and igt_pm_restore_sata_link_power_management() in order to save and restore the sata link power policy by an exit handler. v2: Simplify the comment section. v3: Remove . from the subject line. v4: Rebased, resolve conflicts in pm_rpm.c Included patch set version change log. v5: Listing actual change in patch set changelog to make review easier. v6: igt's lib added support for disabling runtime suspend, change in commit log. rebased due to test name pm_rpm changed to i915_pm_rpm. v7: Addressed review comment by saving POWER_DIR values in igt_disable_runtime_pm(). [Imre] v8: Addressed the review comment, igt_pm_enable_sata_link_power_management function to restore the original SATA link power policy if things fail by using an exit handler. [Imre] v9: IGT failure fixture in i915_pm_backlight and i915_pm_rpm. Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- lib/igt_pm.c | 190 ++++++++++++++++++++++++++++++++--------- lib/igt_pm.h | 6 +- tests/i915/i915_pm_backlight.c | 6 +- tests/i915/i915_pm_rpm.c | 24 +----- 4 files changed, 159 insertions(+), 67 deletions(-) diff --git a/lib/igt_pm.c b/lib/igt_pm.c index fd22273..9b83fbb 100644 --- a/lib/igt_pm.c +++ b/lib/igt_pm.c @@ -38,6 +38,7 @@ #include "drmtest.h" #include "igt_pm.h" #include "igt_aux.h" +#include "igt_sysfs.h" /** * SECTION:igt_pm @@ -63,11 +64,15 @@ enum { #define MIN_POWER_STR "min_power\n" /* Remember to fix this if adding longer strings */ #define MAX_POLICY_STRLEN strlen(MAX_PERFORMANCE_STR) +int8_t *__sata_link_pm_policies; static char __igt_pm_audio_runtime_power_save[64]; static char * __igt_pm_audio_runtime_control_path; static char __igt_pm_audio_runtime_control[64]; +static void __igt_pm_sata_link_pm_exit_handler(int sig); +static void __igt_pm_restore_sata_link_power_management(void); + static int __igt_pm_audio_restore_runtime_pm(void) { int fd; @@ -280,28 +285,12 @@ void igt_pm_enable_audio_runtime_pm(void) igt_debug("Failed to enable audio runtime PM! (%d)\n", -err); } -/** - * igt_pm_enable_sata_link_power_management: - * - * Enable the min_power policy for SATA link power management. - * Without this we cannot reach deep runtime power states. - * - * We don't have any assertions on open since the system might not have - * a SATA host. - * - * Returns: - * An opaque pointer to the data needed to restore the default values - * after the test has terminated, or NULL if SATA link power management - * is not supported. This pointer should be freed when no longer used - * (typically after having called restore_sata_link_power_management()). - */ -int8_t *igt_pm_enable_sata_link_power_management(void) +static void __igt_pm_enable_sata_link_power_management(void) { int fd, i; ssize_t len; char *buf; char *file_name; - int8_t *link_pm_policies = NULL; file_name = malloc(PATH_MAX); buf = malloc(MAX_POLICY_STRLEN + 1); @@ -313,6 +302,9 @@ int8_t *igt_pm_enable_sata_link_power_management(void) "/sys/class/scsi_host/host%d/link_power_management_policy", i); + /* We don't have any assertions on open since the system + * might not have a SATA host. + */ fd = open(file_name, O_RDWR); if (fd < 0) break; @@ -333,11 +325,13 @@ int8_t *igt_pm_enable_sata_link_power_management(void) policy = POLICY_UNKNOWN; if (!(i % 256)) - link_pm_policies = realloc(link_pm_policies, - (i / 256 + 1) * 256 + 1); + __sata_link_pm_policies = + realloc(__sata_link_pm_policies, + (i / 256 + 1) * 256 + 1); - link_pm_policies[i] = policy; - link_pm_policies[i + 1] = 0; + __sata_link_pm_policies[i] = policy; + __sata_link_pm_policies[i + 1] = 0; + igt_install_exit_handler(__igt_pm_sata_link_pm_exit_handler); /* If the policy is something we don't know about, * don't touch it, since we might potentially break things. @@ -355,39 +349,27 @@ int8_t *igt_pm_enable_sata_link_power_management(void) } free(buf); free(file_name); - - return link_pm_policies; } -/** - * igt_pm_restore_sata_link_power_management: - * @pm_data: An opaque pointer with saved link PM policies; - * If NULL is passed we force enable the "max_performance" policy. - * - * Restore the link power management policies to the values - * prior to enabling min_power. - * - * Caveat: If the system supports hotplugging and hotplugging takes - * place during our testing so that the hosts change numbers - * we might restore the settings to the wrong hosts. - */ -void igt_pm_restore_sata_link_power_management(int8_t *pm_data) - +static void __igt_pm_restore_sata_link_power_management(void) { int fd, i; char *file_name; + if (!__sata_link_pm_policies) + return; + /* Disk runtime PM policies. */ file_name = malloc(PATH_MAX); for (i = 0; ; i++) { int8_t policy; - if (!pm_data) + if (!__sata_link_pm_policies) policy = POLICY_MAX_PERFORMANCE; - else if (pm_data[i] == POLICY_UNKNOWN) + else if (__sata_link_pm_policies[i] == POLICY_UNKNOWN) continue; else - policy = pm_data[i]; + policy = __sata_link_pm_policies[i]; snprintf(file_name, PATH_MAX, "/sys/class/scsi_host/host%d/link_power_management_policy", @@ -421,7 +403,53 @@ void igt_pm_restore_sata_link_power_management(int8_t *pm_data) close(fd); } free(file_name); + free(__sata_link_pm_policies); + __sata_link_pm_policies = NULL; +} + +/** + * igt_pm_enable_sata_link_power_management: + * + * Enable the min_power policy for SATA link power management. + * Without this we cannot reach deep runtime power states. + * Returns: Void + */ +void igt_pm_enable_sata_link_power_management(void) +{ + int err; + + /* Check if has been already saved. */ + if (__sata_link_pm_policies) + return; + + __igt_pm_enable_sata_link_power_management(); +} + +/** + * igt_pm_restore_sata_link_power_management: + * + * Restore the link power management policies to the values + * prior to enabling min_power. + * + * Caveat: If the system supports hotplugging and hotplugging takes + * place during our testing so that the hosts change numbers + * we might restore the settings to the wrong hosts. + */ +void igt_pm_restore_sata_link_power_management(void) +{ + int err; + + if (!__sata_link_pm_policies) + return; + + __igt_pm_restore_sata_link_power_management(); } + +static void __igt_pm_sata_link_pm_exit_handler(int sig) +{ + __igt_pm_restore_sata_link_power_management(); +} + #define POWER_DIR "/sys/devices/pci0000:00/0000:00:02.0/power" /* We just leak this on exit ... */ int pm_status_fd = -1; @@ -585,6 +613,61 @@ bool igt_setup_runtime_pm(void) return true; } +bool igt_disable_runtime_pm(void) +{ + int fd; + ssize_t size; + char buf[6]; + + if (pm_status_fd < 0) { + fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR); + if (fd < 0) + return false; + + size = read(fd, __igt_pm_runtime_autosuspend, + sizeof(__igt_pm_runtime_autosuspend)); + + if (size <= 0) { + close(fd); + return false; + } + + strchomp(__igt_pm_runtime_autosuspend); + igt_install_exit_handler(__igt_pm_runtime_exit_handler); + close(fd); + } + + /* We know we support runtime PM, let's try to disable it now. */ + fd = open(POWER_DIR "/control", O_RDWR); + igt_assert_f(fd >= 0, "Can't open " POWER_DIR "/control\n"); + + if (pm_status_fd < 0) { + igt_assert(read(fd, __igt_pm_runtime_control, + sizeof(__igt_pm_runtime_control)) > 0); + strchomp(__igt_pm_runtime_control); + + igt_debug("Saved runtime power management as '%s' and '%s'\n", + __igt_pm_runtime_autosuspend, + __igt_pm_runtime_control); + } + + size = write(fd, "on\n", 3); + igt_assert(size == 3); + lseek(fd, 0, SEEK_SET); + size = read(fd, buf, ARRAY_SIZE(buf)); + igt_assert(size == 3); + igt_assert(strncmp(buf, "on\n", 3) == 0); + close(fd); + + if (pm_status_fd < 0) { + pm_status_fd = open(POWER_DIR "/runtime_status", O_RDONLY); + igt_assert_f(pm_status_fd >= 0, + "Can't open " POWER_DIR "/runtime_status\n"); + } + + return true; +} + /** * igt_get_runtime_pm_status: * @@ -628,3 +711,30 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status) { return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100); } + +/** + * dmc_loaded: + * @debugfs: fd to the debugfs dir. + + * Check whether DMC FW is loaded or not. DMC FW is require for few Display C + * states like DC5 and DC6. FW does the Context Save and Restore during Display + * C States entry and exit. + * + * Returns: + * True if DMC FW is loaded otherwise false. + */ +bool igt_pm_dmc_loaded(int debugfs) +{ + igt_require(debugfs != -1); + char buf[15]; + int len; + + len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1); + if (len < 0) + return true; /* no CSR support, no DMC requirement */ + + buf[len] = '\0'; + + igt_info("DMC: %s\n", buf); + return strstr(buf, "fw loaded: yes"); +} diff --git a/lib/igt_pm.h b/lib/igt_pm.h index 10cc679..979b346 100644 --- a/lib/igt_pm.h +++ b/lib/igt_pm.h @@ -25,8 +25,8 @@ #define IGT_PM_H void igt_pm_enable_audio_runtime_pm(void); -int8_t *igt_pm_enable_sata_link_power_management(void); -void igt_pm_restore_sata_link_power_management(int8_t *pm_data); +void igt_pm_enable_sata_link_power_management(void); +void igt_pm_restore_sata_link_power_management(void); /** * igt_runtime_pm_status: @@ -47,8 +47,10 @@ enum igt_runtime_pm_status { }; bool igt_setup_runtime_pm(void); +bool igt_disable_runtime_pm(void); void igt_restore_runtime_pm(void); enum igt_runtime_pm_status igt_get_runtime_pm_status(void); bool igt_wait_for_pm_status(enum igt_runtime_pm_status status); +bool igt_pm_dmc_loaded(int debugfs); #endif /* IGT_PM_H */ diff --git a/tests/i915/i915_pm_backlight.c b/tests/i915/i915_pm_backlight.c index 4c1bff5..9a5f4c3 100644 --- a/tests/i915/i915_pm_backlight.c +++ b/tests/i915/i915_pm_backlight.c @@ -47,7 +47,6 @@ struct context { #define FADESPEED 100 /* milliseconds between steps */ IGT_TEST_DESCRIPTION("Basic backlight sysfs test"); -static int8_t *pm_data = NULL; static int backlight_read(int *result, const char *fname) { @@ -235,7 +234,7 @@ igt_main igt_plane_set_fb(primary, &fb); igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); - pm_data = igt_pm_enable_sata_link_power_management(); + igt_pm_enable_sata_link_power_management(); } igt_subtest("basic-brightness") @@ -255,8 +254,7 @@ igt_main igt_display_fini(&display); igt_remove_fb(display.drm_fd, &fb); - igt_pm_restore_sata_link_power_management(pm_data); - free(pm_data); + igt_pm_restore_sata_link_power_management(); close(display.drm_fd); } } diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index a2c9d0e..2d2f77b 100644 --- a/tests/i915/i915_pm_rpm.c +++ b/tests/i915/i915_pm_rpm.c @@ -122,8 +122,6 @@ struct modeset_params lpsp_mode_params; struct modeset_params non_lpsp_mode_params; struct modeset_params *default_mode_params; -static int8_t *pm_data = NULL; - static int modprobe(const char *driver) { return igt_kmod_load(driver, NULL); @@ -710,21 +708,6 @@ static void setup_pc8(void) has_pc8 = true; } -static bool dmc_loaded(void) -{ - char buf[15]; - int len; - - len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1); - if (len < 0) - return true; /* no CSR support, no DMC requirement */ - - buf[len] = '\0'; - - igt_info("DMC: %s\n", buf); - return strstr(buf, "fw loaded: yes"); -} - static void dump_file(int dir, const char *filename) { char *contents; @@ -751,7 +734,7 @@ static bool setup_environment(void) init_mode_set_data(&ms_data); - pm_data = igt_pm_enable_sata_link_power_management(); + igt_pm_enable_sata_link_power_management(); has_runtime_pm = igt_setup_runtime_pm(); setup_pc8(); @@ -759,7 +742,7 @@ static bool setup_environment(void) igt_info("Runtime PM support: %d\n", has_runtime_pm); igt_info("PC8 residency support: %d\n", has_pc8); igt_require(has_runtime_pm); - igt_require(dmc_loaded()); + igt_require(igt_pm_dmc_loaded(debugfs)); out: disable_all_screens(&ms_data); @@ -776,8 +759,7 @@ static void teardown_environment(void) igt_restore_runtime_pm(); - igt_pm_restore_sata_link_power_management(pm_data); - free(pm_data); + igt_pm_restore_sata_link_power_management(); fini_mode_set_data(&ms_data); -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t v12 3/5] tests/i915/i915_pm_dc: Added test for DC6 during PSR 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta @ 2019-05-08 6:31 ` Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 4/5] tests/i915/i915_pm_dc: Added test for DC5 during DPMS Anshuman Gupta ` (5 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Anshuman Gupta @ 2019-05-08 6:31 UTC (permalink / raw) To: igt-dev; +Cc: jyoti.r.yadav From: Jyoti Yadav <jyoti.r.yadav@intel.com> This patch add subtest to check DC6 entry on PSR for the supported platforms. v2: Rename the subtest with more meaningful name. v3: Rebased. v4: Rebased, to fix compilation error in psr_enable(). Addressed review comment by fixing typo in comment description of DC6 PSR subtest. v5: Addressed the review comment by removing redundant read_dc_counter(), clubbed cleanup() function in test_dc_state_psr() suggested by Imre. Listing actual change in patch set changelog to make review easier. v6: Rebased due to test name pm_dc changed to i915_pm_dc, aligning to other PM tests. Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- tests/i915/i915_pm_dc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index 94890e2..f261ecb 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -202,6 +202,14 @@ int main(int argc, char *argv[]) test_dc_state_psr(&data, CHECK_DC5); } + igt_subtest("dc6-psr") { + data.op_psr_mode = PSR_MODE_1; + psr_enable(data.debugfs_fd, data.op_psr_mode); + igt_require_f(edp_psr_sink_support(&data), + "Sink does not support PSR\n"); + test_dc_state_psr(&data, CHECK_DC6); + } + igt_fixture { close(data.debugfs_fd); display_fini(&data); -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t v12 4/5] tests/i915/i915_pm_dc: Added test for DC5 during DPMS 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 3/5] tests/i915/i915_pm_dc: Added test for DC6 during PSR Anshuman Gupta @ 2019-05-08 6:31 ` Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 5/5] tests/i915/i915_pm_dc: Added test for DC6 " Anshuman Gupta ` (4 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Anshuman Gupta @ 2019-05-08 6:31 UTC (permalink / raw) To: igt-dev; +Cc: jyoti.r.yadav From: Jyoti Yadav <jyoti.r.yadav@intel.com> Added new subtest for DC5 entry during DPMS on/off cycle. During DPMS on/off cycle DC5 counter is incremented. v2: Rename the subtest with meaningful name. v3: Rebased. v4: Addressed review comments by removing leftover code cleanup(). v5: Addressed the review comment by removing redundant read_dc_counter() suggested by Imre. Listing actual change in patch set changelog to make review easier. v6: Three way patch applied, no functional change. v7: Disabling runtime suspend for the platform which support, DC9. rebased due to test name pm_dc changed to i915_pm_dc, aligning to other PM tests. v8: Introduced setup_dc_dpms() in order to disable runtime pm, restoring POWER_DIR values to its original and enabling runtime pm for other followed sub-tests. v9: Check DC5 counter value after DPMS off, broke the dpms_on_off function to dpms_on and dpms_off. [Imre] Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- tests/i915/i915_pm_dc.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index f261ecb..0f78b6b 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -46,6 +46,7 @@ typedef struct { enum psr_mode op_psr_mode; drmModeModeInfo *mode; igt_output_t *output; + bool runtime_suspend_disabled; } data_t; bool dc_state_wait_entry(int drm_fd, int dc_flag, int prev_dc_count); @@ -173,6 +174,62 @@ static void test_dc_state_psr(data_t *data, int dc_flag) cleanup(data); } +static void setup_dc_dpms(data_t *data) +{ + if (IS_BROXTON(data->devid) || IS_GEMINILAKE(data->devid) || + IS_ICELAKE(data->devid)) { + data->runtime_suspend_disabled = igt_disable_runtime_pm(); + igt_require_f(data->runtime_suspend_disabled, + "unable to disable runtime pm for i915\n"); + } else { + data->runtime_suspend_disabled = false; + } +} + +static void dpms_off(data_t *data) +{ + for (int i = 0; i < data->display.n_outputs; i++) { + kmstest_set_connector_dpms(data->drm_fd, + data->display.outputs[i].config.connector, + DRM_MODE_DPMS_OFF); + } + + if (!data->runtime_suspend_disabled) + igt_assert(igt_wait_for_pm_status + (IGT_RUNTIME_PM_STATUS_SUSPENDED)); +} + +static void dpms_on(data_t *data) +{ + for (int i = 0; i < data->display.n_outputs; i++) { + kmstest_set_connector_dpms(data->drm_fd, + data->display.outputs[i].config.connector, + DRM_MODE_DPMS_ON); + } + + if (!data->runtime_suspend_disabled) + igt_assert(igt_wait_for_pm_status + (IGT_RUNTIME_PM_STATUS_ACTIVE)); +} + +static void test_dc_state_dpms(data_t *data, int dc_flag) +{ + uint32_t dc_counter; + + dc_counter = read_dc_counter(data->drm_fd, dc_flag); + dpms_off(data); + check_dc_counter(data->drm_fd, dc_flag, dc_counter); + dpms_on(data); + + /* if runtime PM is disabled for i915 restore it, + * so any other sub-test can use runtime-PM. + */ + if (data->runtime_suspend_disabled) { + igt_restore_runtime_pm(); + igt_setup_runtime_pm(); + } +} + int main(int argc, char *argv[]) { bool has_runtime_pm; @@ -210,6 +267,11 @@ int main(int argc, char *argv[]) test_dc_state_psr(&data, CHECK_DC6); } + igt_subtest("dc5-dpms") { + setup_dc_dpms(&data); + test_dc_state_dpms(&data, CHECK_DC5); + } + igt_fixture { close(data.debugfs_fd); display_fini(&data); -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t v12 5/5] tests/i915/i915_pm_dc: Added test for DC6 during DPMS 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta ` (2 preceding siblings ...) 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 4/5] tests/i915/i915_pm_dc: Added test for DC5 during DPMS Anshuman Gupta @ 2019-05-08 6:31 ` Anshuman Gupta 2019-05-08 7:15 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev10) Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Anshuman Gupta @ 2019-05-08 6:31 UTC (permalink / raw) To: igt-dev; +Cc: jyoti.r.yadav From: Jyoti Yadav <jyoti.r.yadav@intel.com> Added new subtest for DC6 entry during DPMS on/off cycle. During DPMS on/off cycle DC6 counter is incremented. v2: Renamed the subtest name. v3: Rebased. v4: Addressed review comment by replacing igt_display_init() to igt_display_require(), changes got done in patch set 2. v5: Addressed the review comment by removing redundant read_dc_counter() suggested by Imre. Listing actual change in patch set changelog to make review easier. v6: Rebased due to test name pm_dc changed to i915_pm_dc, aligning to other PM tests. v7: Introduced setup_dc_dpms() inorder to disable i915 runtime PM for the platform supports DC9. Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- tests/i915/i915_pm_dc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index 0f78b6b..ba891d8 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -272,6 +272,11 @@ int main(int argc, char *argv[]) test_dc_state_dpms(&data, CHECK_DC5); } + igt_subtest("dc6-dpms") { + setup_dc_dpms(&data); + test_dc_state_dpms(&data, CHECK_DC6); + } + igt_fixture { close(data.debugfs_fd); display_fini(&data); -- 2.7.4 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev10) 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta ` (3 preceding siblings ...) 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 5/5] tests/i915/i915_pm_dc: Added test for DC6 " Anshuman Gupta @ 2019-05-08 7:15 ` Patchwork 2019-05-08 10:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-05-08 7:15 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev == Series Details == Series: DC states igt tests patch series (rev10) URL : https://patchwork.freedesktop.org/series/56713/ State : success == Summary == CI Bug Log - changes from IGT_4973 -> IGTPW_2949 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/10/mbox/ Known issues ------------ Here are the changes found in IGTPW_2949 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@read_all_entries: - fi-ilk-650: [PASS][1] -> [DMESG-WARN][2] ([fdo#106387]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/fi-ilk-650/igt@debugfs_test@read_all_entries.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/fi-ilk-650/igt@debugfs_test@read_all_entries.html * igt@i915_selftest@live_hangcheck: - fi-skl-iommu: [PASS][3] -> [INCOMPLETE][4] ([fdo#108602] / [fdo#108744]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@i915_selftest@live_hangcheck: - {fi-icl-y}: [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/fi-icl-y/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/fi-icl-y/igt@i915_selftest@live_hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602 [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744 Participating hosts (51 -> 43) ------------------------------ Additional (2): fi-icl-u2 fi-apl-guc Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * IGT: IGT_4973 -> IGTPW_2949 CI_DRM_6063: 44ae4003d35743cbc7883825c5fe777d136b5247 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2949: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/ IGT_4973: 3e3ff0e48989abd25fce4916e85e8fef20a3c63a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@i915_pm_dc@dc5-dpms +igt@i915_pm_dc@dc5-psr +igt@i915_pm_dc@dc6-dpms +igt@i915_pm_dc@dc6-psr == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for DC states igt tests patch series (rev10) 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta ` (4 preceding siblings ...) 2019-05-08 7:15 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev10) Patchwork @ 2019-05-08 10:04 ` Patchwork 2019-06-04 15:58 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev11) Patchwork 2019-06-05 7:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 7 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-05-08 10:04 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev == Series Details == Series: DC states igt tests patch series (rev10) URL : https://patchwork.freedesktop.org/series/56713/ State : success == Summary == CI Bug Log - changes from IGT_4973_full -> IGTPW_2949_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/10/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_2949_full: ### IGT changes ### #### Possible regressions #### * {igt@i915_pm_dc@dc6-dpms} (NEW): - shard-iclb: NOTRUN -> [FAIL][1] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html - shard-kbl: NOTRUN -> [FAIL][2] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-kbl2/igt@i915_pm_dc@dc6-dpms.html New tests --------- New tests have been introduced between IGT_4973_full and IGTPW_2949_full: ### New IGT tests (4) ### * igt@i915_pm_dc@dc5-dpms: - Statuses : 4 pass(s) 2 skip(s) - Exec time: [0.0, 2.22] s * igt@i915_pm_dc@dc5-psr: - Statuses : 1 pass(s) 5 skip(s) - Exec time: [0.0, 3.37] s * igt@i915_pm_dc@dc6-dpms: - Statuses : 2 fail(s) 3 skip(s) - Exec time: [0.0, 3.62] s * igt@i915_pm_dc@dc6-psr: - Statuses : 1 fail(s) 4 skip(s) - Exec time: [0.0, 3.62] s Known issues ------------ Here are the changes found in IGTPW_2949_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-apl7/igt@i915_suspend@sysfs-reader.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-apl3/igt@i915_suspend@sysfs-reader.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109349]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][7] -> [FAIL][8] ([fdo#102887] / [fdo#105363]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw: - shard-glk: [PASS][9] -> [FAIL][10] ([fdo#103167]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping: - shard-glk: [PASS][13] -> [SKIP][14] ([fdo#109271] / [fdo#109278]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk6/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@tools_test@tools_test: - shard-snb: [PASS][17] -> [SKIP][18] ([fdo#109271]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-snb4/igt@tools_test@tools_test.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-snb5/igt@tools_test@tools_test.html #### Possible fixes #### * igt@gem_tiled_swapping@non-threaded: - shard-glk: [DMESG-WARN][19] ([fdo#108686]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk7/igt@gem_tiled_swapping@non-threaded.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk5/igt@gem_tiled_swapping@non-threaded.html * igt@i915_suspend@debugfs-reader: - shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [PASS][22] +4 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-apl4/igt@i915_suspend@debugfs-reader.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-apl8/igt@i915_suspend@debugfs-reader.html * igt@kms_cursor_crc@cursor-64x21-sliding: - shard-apl: [FAIL][23] ([fdo#103232]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-apl3/igt@kms_cursor_crc@cursor-64x21-sliding.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-apl2/igt@kms_cursor_crc@cursor-64x21-sliding.html - shard-kbl: [FAIL][25] ([fdo#103232]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-kbl3/igt@kms_cursor_crc@cursor-64x21-sliding.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-kbl5/igt@kms_cursor_crc@cursor-64x21-sliding.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][27] ([fdo#105363]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@2x-flip-vs-suspend: - shard-hsw: [INCOMPLETE][29] ([fdo#103540]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-hsw7/igt@kms_flip@2x-flip-vs-suspend.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-hsw1/igt@kms_flip@2x-flip-vs-suspend.html * igt@kms_flip@plain-flip-fb-recreate: - shard-kbl: [FAIL][31] ([fdo#100368]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: [FAIL][33] ([fdo#103167]) -> [PASS][34] +7 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_plane@pixel-format-pipe-c-planes-source-clamping: - shard-glk: [SKIP][35] ([fdo#109271]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-glk1/igt@kms_plane@pixel-format-pipe-c-planes-source-clamping.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-glk9/igt@kms_plane@pixel-format-pipe-c-planes-source-clamping.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [FAIL][37] ([fdo#103166]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][39] ([fdo#109441]) -> [PASS][40] +4 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-iclb5/igt@kms_psr@psr2_no_drrs.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@kms_setmode@basic: - shard-apl: [FAIL][41] ([fdo#99912]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-apl8/igt@kms_setmode@basic.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-apl1/igt@kms_setmode@basic.html - shard-kbl: [FAIL][43] ([fdo#99912]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-kbl3/igt@kms_setmode@basic.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-kbl4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4973/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (7 -> 6) ------------------------------ Missing (1): shard-skl Build changes ------------- * IGT: IGT_4973 -> IGTPW_2949 CI_DRM_6063: 44ae4003d35743cbc7883825c5fe777d136b5247 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2949: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/ IGT_4973: 3e3ff0e48989abd25fce4916e85e8fef20a3c63a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2949/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev11) 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta ` (5 preceding siblings ...) 2019-05-08 10:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2019-06-04 15:58 ` Patchwork 2019-06-05 7:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 7 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-06-04 15:58 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev == Series Details == Series: DC states igt tests patch series (rev11) URL : https://patchwork.freedesktop.org/series/56713/ State : success == Summary == CI Bug Log - changes from CI_DRM_6186 -> IGTPW_3104 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/11/mbox/ Known issues ------------ Here are the changes found in IGTPW_3104 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_addfb_basic@basic: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-icl-u3/igt@kms_addfb_basic@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-icl-u3/igt@kms_addfb_basic@basic.html #### Possible fixes #### * igt@gem_ctx_switch@basic-default: - {fi-icl-guc}: [INCOMPLETE][3] ([fdo#107713] / [fdo#108569]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-icl-guc/igt@gem_ctx_switch@basic-default.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-icl-guc/igt@gem_ctx_switch@basic-default.html * igt@i915_pm_rpm@module-reload: - fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-icl-u3/igt@i915_pm_rpm@module-reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-icl-u3/igt@i915_pm_rpm@module-reload.html * {igt@i915_selftest@live_blt}: - fi-skl-iommu: [INCOMPLETE][7] ([fdo#108602]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-skl-iommu/igt@i915_selftest@live_blt.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-skl-iommu/igt@i915_selftest@live_blt.html * {igt@i915_selftest@live_mman}: - fi-icl-y: [TIMEOUT][9] ([fdo#110818 ]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-icl-y/igt@i915_selftest@live_mman.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-icl-y/igt@i915_selftest@live_mman.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-blb-e6850: [INCOMPLETE][11] ([fdo#107718]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602 [fdo#110818 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110818 Participating hosts (53 -> 45) ------------------------------ Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bdw-samus Build changes ------------- * IGT: IGT_5037 -> IGTPW_3104 CI_DRM_6186: a629ccaaa66bb4effc461a00de5b3f92b6ea9c4c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3104: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/ IGT_5037: a98c9cd50aa48933217ca41055279ccb1680d25b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Testlist changes == +igt@i915_pm_dc@dc5-dpms +igt@i915_pm_dc@dc5-psr +igt@i915_pm_dc@dc6-dpms +igt@i915_pm_dc@dc6-psr == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for DC states igt tests patch series (rev11) 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta ` (6 preceding siblings ...) 2019-06-04 15:58 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev11) Patchwork @ 2019-06-05 7:55 ` Patchwork 7 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-06-05 7:55 UTC (permalink / raw) To: Anshuman Gupta; +Cc: igt-dev == Series Details == Series: DC states igt tests patch series (rev11) URL : https://patchwork.freedesktop.org/series/56713/ State : success == Summary == CI Bug Log - changes from CI_DRM_6186_full -> IGTPW_3104_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/11/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_3104_full: ### IGT changes ### #### Possible regressions #### * {igt@i915_pm_dc@dc6-dpms} (NEW): - shard-kbl: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-kbl4/igt@i915_pm_dc@dc6-dpms.html New tests --------- New tests have been introduced between CI_DRM_6186_full and IGTPW_3104_full: ### New IGT tests (4) ### * igt@i915_pm_dc@dc5-dpms: - Statuses : 4 pass(s) 2 skip(s) - Exec time: [0.0, 2.18] s * igt@i915_pm_dc@dc5-psr: - Statuses : 1 pass(s) 5 skip(s) - Exec time: [0.0, 3.39] s * igt@i915_pm_dc@dc6-dpms: - Statuses : 1 fail(s) 3 skip(s) - Exec time: [0.0, 3.36] s * igt@i915_pm_dc@dc6-psr: - Statuses : 1 pass(s) 5 skip(s) - Exec time: [0.0, 3.37] s Known issues ------------ Here are the changes found in IGTPW_3104_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@reset-stress: - shard-iclb: [PASS][2] -> [INCOMPLETE][3] ([fdo#107713]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb1/igt@gem_eio@reset-stress.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb1/igt@gem_eio@reset-stress.html * igt@i915_pm_rps@reset: - shard-glk: [PASS][4] -> [FAIL][5] ([fdo#102250]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-glk9/igt@i915_pm_rps@reset.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-glk2/igt@i915_pm_rps@reset.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][6] -> [DMESG-WARN][7] ([fdo#108566]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-apl7/igt@i915_suspend@sysfs-reader.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-apl1/igt@i915_suspend@sysfs-reader.html * igt@kms_color@pipe-c-ctm-green-to-red: - shard-kbl: [PASS][8] -> [FAIL][9] ([fdo#107201]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-kbl3/igt@kms_color@pipe-c-ctm-green-to-red.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-kbl4/igt@kms_color@pipe-c-ctm-green-to-red.html * igt@kms_flip@2x-plain-flip-ts-check-interruptible: - shard-hsw: [PASS][10] -> [SKIP][11] ([fdo#109271]) +12 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-hsw5/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][12] -> [FAIL][13] ([fdo#103167]) +4 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_setmode@basic: - shard-apl: [PASS][14] -> [FAIL][15] ([fdo#99912]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-apl8/igt@kms_setmode@basic.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-apl5/igt@kms_setmode@basic.html * igt@kms_sysfs_edid_timing: - shard-hsw: [PASS][16] -> [FAIL][17] ([fdo#100047]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-hsw2/igt@kms_sysfs_edid_timing.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-hsw1/igt@kms_sysfs_edid_timing.html #### Possible fixes #### * {igt@gem_ctx_param@vm}: - shard-hsw: [DMESG-WARN][18] ([fdo#110836]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-hsw6/igt@gem_ctx_param@vm.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-hsw4/igt@gem_ctx_param@vm.html * igt@gem_mmap_gtt@forked-medium-copy-odd: - shard-iclb: [INCOMPLETE][20] ([fdo#107713]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb8/igt@gem_mmap_gtt@forked-medium-copy-odd.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb4/igt@gem_mmap_gtt@forked-medium-copy-odd.html * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible: - shard-glk: [FAIL][22] ([fdo#103060]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-glk3/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-glk2/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][24] ([fdo#103167]) -> [PASS][25] +3 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_psr@psr2_basic: - shard-iclb: [SKIP][26] ([fdo#109441]) -> [PASS][27] +2 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb7/igt@kms_psr@psr2_basic.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb2/igt@kms_psr@psr2_basic.html * igt@kms_setmode@basic: - shard-kbl: [FAIL][28] ([fdo#99912]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-kbl7/igt@kms_setmode@basic.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-kbl6/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-apl: [DMESG-WARN][30] ([fdo#108566]) -> [PASS][31] +1 similar issue [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@perf@blocking: - shard-iclb: [FAIL][32] ([fdo#110728]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb6/igt@perf@blocking.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb3/igt@perf@blocking.html #### Warnings #### * igt@gem_mmap_gtt@forked-big-copy-odd: - shard-iclb: [INCOMPLETE][34] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][35] ([fdo#109673]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb2/igt@gem_mmap_gtt@forked-big-copy-odd.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb6/igt@gem_mmap_gtt@forked-big-copy-odd.html * igt@gem_mmap_gtt@forked-big-copy-xy: - shard-iclb: [TIMEOUT][36] ([fdo#109673]) -> [INCOMPLETE][37] ([fdo#107713] / [fdo#109100]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6186/shard-iclb3/igt@gem_mmap_gtt@forked-big-copy-xy.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/shard-iclb7/igt@gem_mmap_gtt@forked-big-copy-xy.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250 [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#110836]: https://bugs.freedesktop.org/show_bug.cgi?id=110836 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 6) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * IGT: IGT_5037 -> IGTPW_3104 * Piglit: piglit_4509 -> None CI_DRM_6186: a629ccaaa66bb4effc461a00de5b3f92b6ea9c4c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3104: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/ IGT_5037: a98c9cd50aa48933217ca41055279ccb1680d25b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3104/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-05 7:55 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-05-08 6:31 [igt-dev] [PATCH i-g-t v12 0/5] DC states igt tests patch series v11 Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 3/5] tests/i915/i915_pm_dc: Added test for DC6 during PSR Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 4/5] tests/i915/i915_pm_dc: Added test for DC5 during DPMS Anshuman Gupta 2019-05-08 6:31 ` [igt-dev] [PATCH i-g-t v12 5/5] tests/i915/i915_pm_dc: Added test for DC6 " Anshuman Gupta 2019-05-08 7:15 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev10) Patchwork 2019-05-08 10:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-06-04 15:58 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev11) Patchwork 2019-06-05 7:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox