From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>, Kunal Joshi <knljoshi98@gmail.com>
Subject: [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c skip test if chamelium is not connected
Date: Thu, 12 Dec 2019 14:57:10 +0530 [thread overview]
Message-ID: <1576142830-31269-1-git-send-email-kunal1.joshi@intel.com> (raw)
From: Kunal Joshi <knljoshi98@gmail.com>
If chamelium is not present at the specified IP in igtrc file
the test should be skipped instead of failing.Modified it
to skip on any network related issue and assert on any other.
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com,
ankit.k.nautiyal@intel.com,
manasi.d.navare@intel.com
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_chamelium.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 9971f51..79eddde 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
format_str, va_args);
va_end(va_args);
- igt_assert_f(!chamelium->env.fault_occurred,
- "Chamelium RPC call failed: %s\n",
- chamelium->env.fault_string);
+ if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
+ igt_skip("Chamelium not found at specified IP");
+ else
+ igt_assert_f(!chamelium->env.fault_occurred,
+ "Chamelium RPC call failed: %s\n",
+ chamelium->env.fault_string);
return res;
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-12-12 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 9:27 Kunal Joshi [this message]
2019-12-16 14:10 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_chamelium.c skip test if chamelium is not connected Patchwork
2019-12-16 14:54 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-12-16 17:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576142830-31269-1-git-send-email-kunal1.joshi@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=knljoshi98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox