public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c skip test if chamelium is not connected
@ 2019-12-12  9:27 Kunal Joshi
  2019-12-16 14:10 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kunal Joshi @ 2019-12-12  9:27 UTC (permalink / raw)
  To: igt-dev; +Cc: Kunal Joshi, Kunal Joshi

From: Kunal Joshi <knljoshi98@gmail.com>

If chamelium is not present at the specified IP in igtrc file
the test should be skipped instead of failing.Modified it 
to skip on any network related issue and assert on any other.

To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com,
    ankit.k.nautiyal@intel.com,
    manasi.d.navare@intel.com

Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 lib/igt_chamelium.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 9971f51..79eddde 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -344,9 +344,12 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
 				 format_str, va_args);
 	va_end(va_args);
 
-	igt_assert_f(!chamelium->env.fault_occurred,
-		     "Chamelium RPC call failed: %s\n",
-		     chamelium->env.fault_string);
+	if (chamelium->env.fault_code == XMLRPC_NETWORK_ERROR)
+		igt_skip("Chamelium not found at specified IP");
+	else
+		igt_assert_f(!chamelium->env.fault_occurred,
+				"Chamelium RPC call failed: %s\n",
+				chamelium->env.fault_string);
 
 	return res;
 }
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-16 17:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12  9:27 [igt-dev] [PATCH i-g-t] lib/igt_chamelium.c skip test if chamelium is not connected Kunal Joshi
2019-12-16 14:10 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2019-12-16 14:54 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-12-16 17:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox